From: Mark Brown <broonie@kernel•org>
To: Chuanhong Guo <gch981213@gmail•com>
Cc: Mark Rutland <mark.rutland@arm•com>,
devicetree@vger•kernel.org, Vignesh Raghavendra <vigneshr@ti•com>,
Richard Weinberger <richard@nod•at>,
linux-kernel@vger•kernel.org, linux-spi@vger•kernel.org,
Rob Herring <robh+dt@kernel•org>,
linux-mtd@lists•infradead.org,
Miquel Raynal <miquel.raynal@bootlin•com>,
Matthias Brugger <matthias.bgg@gmail•com>,
linux-mediatek@lists•infradead.org,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem
Date: Tue, 18 Feb 2020 12:55:57 +0000 [thread overview]
Message-ID: <20200218125557.GD4232@sirena.org.uk> (raw)
In-Reply-To: <20200215065826.739102-1-gch981213@gmail.com>
[-- Attachment #1.1: Type: text/plain, Size: 1041 bytes --]
On Sat, Feb 15, 2020 at 02:58:24PM +0800, Chuanhong Guo wrote:
> To keep patchset small for easier reviewing, there will be 3 patchsets
> including this one.
> 1. add the new driver, which is this patchset.
> 2. update existing dts for the new driver:
> spi-max-frequency is missing in current mtk-quadspi binding. Old
> driver parses child node manually so it doesn't need this, but
> new spi-mem driver is probed via spi subsystem which requires the
> presence of spi-max-frequency. Since this doesn't break old driver
> support, I'll send this separately as a standalone patch.
This is an ABI break so you shouldn't be doing this, if the existing
binding works it should continue to work.
> 3. removing the old driver. I'll create this commit after 1 and 2 are
> applied to avoid possible rebasing due to any changes in the old
> driver.
This isn't great as it means we have a period with two drivers for the
same thing in tree which is at best going to be confusing. There's no
advantage to splitting this out.
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-18 12:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-15 6:58 [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem Chuanhong Guo
2020-02-15 6:58 ` [PATCH 1/2] spi: add support for mediatek spi-nor controller Chuanhong Guo
2020-02-15 6:58 ` [PATCH 2/2] dt-bindings: convert mtk-quadspi binding doc for spi-mtk-nor Chuanhong Guo
2020-02-18 12:55 ` Mark Brown [this message]
2020-02-19 23:58 ` [PATCH 0/2] rewrite mtk-quadspi spi-nor driver with spi-mem Chuanhong Guo
2020-02-20 19:51 ` Mark Brown
2020-02-25 17:31 ` Rob Herring
2020-02-26 1:31 ` Chuanhong Guo
2020-02-26 11:36 ` Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200218125557.GD4232@sirena.org.uk \
--to=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=gch981213@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-mtd@lists$(echo .)infradead.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=miquel.raynal@bootlin$(echo .)com \
--cc=richard@nod$(echo .)at \
--cc=robh+dt@kernel$(echo .)org \
--cc=vigneshr@ti$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox