Re: [PATCH] backlight: add led-backlight driver

From: Lee Jones <lee.jones@linaro•org>
To: Tony Lindgren <tony@atomide•com>
Cc: daniel.thompson@linaro•org, mpartap@gmx•net,
	jingoohan1@gmail•com, merlijn@wizzup•org,
	martin_rysavy@centrum•cz,
	kernel list <linux-kernel@vger•kernel.org>,
	dri-devel@lists•freedesktop.org, sre@kernel•org,
	nekit1000@gmail•com, tomi.valkeinen@ti•com,
	Pavel Machek <pavel@ucw•cz>,
	jjhiblot@ti•com, linux-omap@vger•kernel.org, agx@sigxcpu•org,
	linux-arm-kernel <linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH] backlight: add led-backlight driver
Date: Thu, 20 Feb 2020 07:48:49 +0000	[thread overview]
Message-ID: <20200220074849.GF3494@dell> (raw)
In-Reply-To: <20200219194540.GD37466@atomide.com>

On Wed, 19 Feb 2020, Tony Lindgren wrote:

> * Pavel Machek <pavel@ucw•cz> [200219 19:15]:
> > From: Tomi Valkeinen <tomi.valkeinen@ti•com>
> > 
> > This patch adds a led-backlight driver (led_bl), which is similar to
> > pwm_bl except the driver uses a LED class driver to adjust the
> > brightness in the HW. Multiple LEDs can be used for a single backlight.
> > 
> > Signed-off-by: Tomi Valkeinen <tomi.valkeinen@ti•com>
> > Signed-off-by: Jean-Jacques Hiblot <jjhiblot@ti•com>
> > Acked-by: Pavel Machek <pavel@ucw•cz>
> > Reviewed-by: Daniel Thompson <daniel.thompson@linaro•org>
> > Acked-by: Lee Jones <lee.jones@linaro•org>
> > Acked-by: Tony Lindgren <tony@atomide•com>
> > Tested-by: Tony Lindgren <tony@atomide•com>
> > Signed-off-by: Pavel Machek <pavel@ucw•cz>
> > ---
> >  drivers/video/backlight/Kconfig  |   7 ++
> >  drivers/video/backlight/Makefile |   1 +
> >  drivers/video/backlight/led_bl.c | 260 +++++++++++++++++++++++++++++++++++++++
> >  3 files changed, 268 insertions(+)
> >  create mode 100644 drivers/video/backlight/led_bl.c
> > 
> > Hi!
> > 
> > Here's the version of the driver I have. AFAICT
> > default-brightness-level handling is ok, so does not need to be
> > changed.
> > 
> > Lee, it would be easiest for me if you could apply it to your tree and
> > push, but given enough time I can push it to Linus, too.
> 
> Oh you're using quoted-printable for patches.. Got it applied now,
> and it still works. Below is also the related dts change that
> I tested with.
> 
> Feel free to pick the dts change too, naturally that should
> not be applied before the driver.
> 
> If you guys instead want me to pick these both into my fixes
> branch, just let me know and I'll do the explaining why these
> are needed as fixes. Basically we no longer have a way to enable
> the LCD backlight for droid4 manually starting with v5.6-rc1
> unlike earlier.

Please do.  You already have my Ack.

--
Lee Jones [李琼斯]
Linaro Services Technical Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel