Re: [PATCH net-next 2/8] net: dsa: propagate resolved link config via mac_link_up() - Russell King

From: Russell King - ARM Linux admin <linux@armlinux•org.uk>
To: Vladimir Oltean <olteanv@gmail•com>
Cc: Andrew Lunn <andrew@lunn•ch>,
	Linux Doc Mailing List <linux-doc@vger•kernel.org>,
	Thomas Petazzoni <thomas.petazzoni@bootlin•com>,
	Ioana Ciornei <ioana.ciornei@nxp•com>,
	linux-stm32@st-md-mailman•stormreply.com,
	Florian Fainelli <f.fainelli@gmail•com>,
	Jonathan Corbet <corbet@lwn•net>,
	Michal Simek <michal.simek@xilinx•com>,
	Jose Abreu <joabreu@synopsys•com>,
	Jakub Kicinski <kuba@kernel•org>,
	Mark Lee <Mark-MC.Lee@mediatek•com>,
	Sean Wang <sean.wang@mediatek•com>,
	Alexandre Torgue <alexandre.torgue@st•com>,
	Hauke Mehrtens <hauke@hauke-m•de>,
	Radhey Shyam Pandey <radhey.shyam.pandey@xilinx•com>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-mediatek@lists•infradead.org>,
	John Crispin <john@phrozen•org>,
	Matthias Brugger <matthias.bgg@gmail•com>,
	Giuseppe Cavallaro <peppe.cavallaro@st•com>,
	"moderated list:ARM/Mediatek SoC support"
	<linux-arm-kernel@lists•infradead.org>,
	netdev <netdev@vger•kernel.org>,
	Vivien Didelot <vivien.didelot@gmail•com>,
	Maxime Coquelin <mcoquelin.stm32@gmail•com>,
	Felix Fietkau <nbd@nbd•name>,
	"David S. Miller" <davem@davemloft•net>,
	Heiner Kallweit <hkallweit1@gmail•com>
Subject: Re: [PATCH net-next 2/8] net: dsa: propagate resolved link config via mac_link_up()
Date: Tue, 25 Feb 2020 23:23:07 +0000	[thread overview]
Message-ID: <20200225232307.GU25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <CA+h21hp8KCqhCasOAGz17k0eRteHVVYK-eANQmn4h443qv=2JQ@mail.gmail.com>

On Tue, Feb 25, 2020 at 11:09:35PM +0200, Vladimir Oltean wrote:
> Hi Russell,
> 
> On Tue, 25 Feb 2020 at 11:39, Russell King <rmk+kernel@armlinux•org.uk> wrote:
> >
> > Propagate the resolved link configuration down via DSA's
> > phylink_mac_link_up() operation to allow split PCS/MAC to work.
> >
> > Signed-off-by: Russell King <rmk+kernel@armlinux•org.uk>
> > ---
> >  drivers/net/dsa/b53/b53_common.c       | 4 +++-
> >  drivers/net/dsa/b53/b53_priv.h         | 4 +++-
> >  drivers/net/dsa/bcm_sf2.c              | 4 +++-
> >  drivers/net/dsa/lantiq_gswip.c         | 4 +++-
> >  drivers/net/dsa/mt7530.c               | 4 +++-
> >  drivers/net/dsa/mv88e6xxx/chip.c       | 4 +++-
> >  drivers/net/dsa/sja1105/sja1105_main.c | 4 +++-
> >  include/net/dsa.h                      | 4 +++-
> >  net/dsa/port.c                         | 3 ++-
> >  9 files changed, 26 insertions(+), 9 deletions(-)
> >
> 
> It looks like you missed the felix_phylink_mac_link_up() conversion in
> this patch? (which also makes it fail to build, by the way, I'm
> supposed the Kbuild robot didn't already jump)
> Nonetheless, I've manually added the missing speed, duplex, tx_pause
> and rx_pause parameters, and it appears to work as before.
> Same for sja1105.

Quite possibly; the patch was developed against 5.5 plus the phylink
changes, but applied to net-next. Hmm, it seems my coccinelle script
that detects .mac_link_up initialiser prototypes, but not the DSA
equivalent using the old prototype.

Thanks for pointing it out.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel