From: Tony Lindgren <tony@atomide•com>
To: afzal mohammed <afzal.mohd.ma@gmail•com>
Cc: Andrew Lunn <andrew@lunn•ch>, Jason Cooper <jason@lakedaemon•net>,
Arnd Bergmann <arnd@arndb•de>, Lubomir Rintel <lkundrak@v3•sk>,
Enrico Weigelt <info@metux•net>,
Viresh Kumar <vireshk@kernel•org>,
Gregory Clement <gregory.clement@bootlin•com>,
Kevin Hilman <khilman@kernel•org>,
linux-kernel@vger•kernel.org,
Russell King <linux@armlinux•org.uk>,
Hartley Sweeten <hsweeten@visionengravers•com>,
Krzysztof Halasa <khalasa@piap•pl>,
Allison Randal <allison@lohutok•net>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Aaro Koskinen <aaro.koskinen@iki•fi>,
Thomas Gleixner <tglx@linutronix•de>,
linux-omap@vger•kernel.org,
Alexander Sverdlin <alexander.sverdlin@gmail•com>,
Shiraz Hashim <shiraz.linux.kernel@gmail•com>,
linux-arm-kernel@lists•infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
Subject: Re: [PATCH v2 02/18] ARM: replace setup_irq() by request_irq()
Date: Wed, 26 Feb 2020 08:31:40 -0800 [thread overview]
Message-ID: <20200226163140.GP37466@atomide.com> (raw)
In-Reply-To: <cbc4859788bd30d6ddc9d9483ed641d6f2d0fd42.1582471508.git.afzal.mohd.ma@gmail.com>
* afzal mohammed <afzal.mohd.ma@gmail•com> [200224 00:49]:
> request_irq() is preferred over setup_irq(). The early boot setup_irq()
> invocations happen either via 'init_IRQ()' or 'time_init()', while
> memory allocators are ready by 'mm_init()'.
>
> Per tglx[1], setup_irq() existed in olden days when allocators were not
> ready by the time early interrupts were initialized.
>
> Hence replace setup_irq() by request_irq().
>
> Seldom remove_irq() usage has been observed coupled with setup_irq(),
> wherever that has been found, it too has been replaced by free_irq().
>
> [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail•com>
> Acked-by: Viresh Kumar <viresh.kumar@linaro•org>
> Acked-by: Alexander Sverdlin <alexander.sverdlin@gmail•com> # EP93xx
> Tested-by: Alexander Sverdlin <alexander.sverdlin@gmail•com> # EP93xx
Works for me:
Tested-by: Tony Lindgren <tony@atomide•com> # omap1 osk
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-26 16:31 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-24 0:47 [PATCH v2 00/18] genirq: Remove setup_irq() afzal mohammed
2020-02-24 0:49 ` [PATCH v2 02/18] ARM: replace setup_irq() by request_irq() afzal mohammed
2020-02-24 10:13 ` Lubomir Rintel
2020-02-26 16:31 ` Tony Lindgren [this message]
2020-02-24 0:50 ` [PATCH v2 08/18] MIPS: Replace " afzal mohammed
2020-02-24 0:52 ` [PATCH v2 16/18] clocksource: " afzal mohammed
2020-02-25 2:52 ` kbuild test robot
2020-02-25 7:51 ` afzal mohammed
2020-02-27 10:59 ` [PATCH v3 " afzal mohammed
2020-02-27 11:18 ` Daniel Lezcano
2020-03-12 6:48 ` [PATCH v4] clocksource/drivers/timer-cs5535: request irq with non-NULL dev_id afzal mohammed
2020-03-12 7:10 ` afzal mohammed
2020-03-12 18:23 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200226163140.GP37466@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=aaro.koskinen@iki$(echo .)fi \
--cc=afzal.mohd.ma@gmail$(echo .)com \
--cc=alexander.sverdlin@gmail$(echo .)com \
--cc=allison@lohutok$(echo .)net \
--cc=andrew@lunn$(echo .)ch \
--cc=arnd@arndb$(echo .)de \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=hsweeten@visionengravers$(echo .)com \
--cc=info@metux$(echo .)net \
--cc=jason@lakedaemon$(echo .)net \
--cc=khalasa@piap$(echo .)pl \
--cc=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=lkundrak@v3$(echo .)sk \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=shiraz.linux.kernel@gmail$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=vireshk@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox