From: Sam Ravnborg <sam@ravnborg•org>
To: Jitao Shi <jitao.shi@mediatek•com>
Cc: Mark Rutland <mark.rutland@arm•com>,
devicetree@vger•kernel.org, srv_heupstream@mediatek•com,
David Airlie <airlied@linux•ie>,
huijuan.xie@mediatek•com, stonea168@163•com,
linux-kernel@vger•kernel.org, dri-devel@lists•freedesktop.org,
cawa.cheng@mediatek•com, Rob Herring <robh+dt@kernel•org>,
linux-mediatek@lists•infradead.org,
Daniel Vetter <daniel@ffwll•ch>,
Matthias Brugger <matthias.bgg@gmail•com>,
yingjoe.chen@mediatek•com, eddie.huang@mediatek•com,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v10 2/5] dt-bindings: display: mediatek: control dpi pins mode to avoid leakage
Date: Fri, 28 Feb 2020 06:52:07 +0100 [thread overview]
Message-ID: <20200228055207.GA6324@ravnborg.org> (raw)
In-Reply-To: <20200228052128.82136-3-jitao.shi@mediatek.com>
Hi Jitao.
On Fri, Feb 28, 2020 at 01:21:25PM +0800, Jitao Shi wrote:
> Add property "pinctrl-names" to swap pin mode between gpio and dpi mode. Set
> the dpi pins to gpio mode and output-low to avoid leakage current when dpi
> disabled.
>
> Signed-off-by: Jitao Shi <jitao.shi@mediatek•com>
> ---
> .../devicetree/bindings/display/mediatek/mediatek,dpi.txt | 7 +++++++
When this has landed it would be great if you could follow-up with a
conversion to DT Schema of this file (.yaml).
Sam
> 1 file changed, 7 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
> index 58914cf681b8..77ca32a32399 100644
> --- a/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
> +++ b/Documentation/devicetree/bindings/display/mediatek/mediatek,dpi.txt
> @@ -17,6 +17,10 @@ Required properties:
> Documentation/devicetree/bindings/graph.txt. This port should be connected
> to the input port of an attached HDMI or LVDS encoder chip.
>
> +Optional properties:
> +- pinctrl-names: Contain "gpiomode" and "dpimode".
> + pinctrl-names see Documentation/devicetree/bindings/pinctrlpinctrl-bindings.txt
> +
> Example:
>
> dpi0: dpi@1401d000 {
> @@ -27,6 +31,9 @@ dpi0: dpi@1401d000 {
> <&mmsys CLK_MM_DPI_ENGINE>,
> <&apmixedsys CLK_APMIXED_TVDPLL>;
> clock-names = "pixel", "engine", "pll";
> + pinctrl-names = "active", "idle";
> + pinctrl-0 = <&dpi_pin_func>;
> + pinctrl-1 = <&dpi_pin_idle>;
>
> port {
> dpi0_out: endpoint {
> --
> 2.21.0
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists•freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-02-28 5:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 5:21 [PATCH v10 0/5] mt8183 dpi supports dual edge and pin mode swap Jitao Shi
2020-02-28 5:21 ` [PATCH v10 1/5] dt-bindings: media: add pclk-sample dual edge property Jitao Shi
2020-02-28 5:21 ` [PATCH v10 2/5] dt-bindings: display: mediatek: control dpi pins mode to avoid leakage Jitao Shi
2020-02-28 5:52 ` Sam Ravnborg [this message]
2020-02-28 5:21 ` [PATCH v10 3/5] dt-bindings: display: mediatek: dpi sample data in dual edge support Jitao Shi
2020-02-28 5:21 ` [PATCH v10 4/5] drm/mediatek: dpi sample mode support Jitao Shi
2020-02-28 5:21 ` [PATCH v10 5/5] drm/mediatek: set dpi pin mode to gpio low to avoid leakage current Jitao Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200228055207.GA6324@ravnborg.org \
--to=sam@ravnborg$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=cawa.cheng@mediatek$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=eddie.huang@mediatek$(echo .)com \
--cc=huijuan.xie@mediatek$(echo .)com \
--cc=jitao.shi@mediatek$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=srv_heupstream@mediatek$(echo .)com \
--cc=stonea168@163$(echo .)com \
--cc=yingjoe.chen@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox