From: Thomas Bogendoerfer <tsbogend@alpha•franken.de>
To: afzal mohammed <afzal.mohd.ma@gmail•com>
Cc: Florian Fainelli <f.fainelli@gmail•com>,
Paul Burton <paulburton@kernel•org>,
linux-mips@vger•kernel.org, Ralf Baechle <ralf@linux-mips•org>,
linux-kernel@vger•kernel.org,
bcm-kernel-feedback-list@broadcom•com,
Jiaxun Yang <jiaxun.yang@flygoat•com>,
"Maciej W. Rozycki" <macro@linux-mips•org>,
John Crispin <john@phrozen•org>, Huacai Chen <chenhc@lemote•com>,
Keguang Zhang <keguang.zhang@gmail•com>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH v4] MIPS: Replace setup_irq() by request_irq()
Date: Fri, 6 Mar 2020 13:47:55 +0100 [thread overview]
Message-ID: <20200306124755.GA10251@alpha.franken.de> (raw)
In-Reply-To: <20200305115759.3186-1-afzal.mohd.ma@gmail.com>
On Thu, Mar 05, 2020 at 05:27:53PM +0530, afzal mohammed wrote:
> request_irq() is preferred over setup_irq(). Invocations of setup_irq()
> occur after memory allocators are ready.
>
> Per tglx[1], setup_irq() existed in olden days when allocators were not
> ready by the time early interrupts were initialized.
>
> Hence replace setup_irq() by request_irq().
>
> remove_irq() has been replaced by free_irq() as well.
>
> There were build error's during previous version, couple of which was
> reported by kbuild test robot <lkp@intel•com> of which one was reported
> by Thomas Bogendoerfer <tsbogend@alpha•franken.de> as well. There were a
> few more issues including build errors, those also have been fixed.
>
> [1] https://lkml.kernel.org/r/alpine.DEB.2.20.1710191609480.1971@nanos
>
> Signed-off-by: afzal mohammed <afzal.mohd.ma@gmail•com>
thank you, applied to mips-next.
Thomas.
--
Crap can work. Given enough thrust pigs will fly, but it's not necessarily a
good idea. [ RFC1925, 2.3 ]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-06 12:48 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-04 0:55 [PATCH v3] MIPS: Replace setup_irq() by request_irq() afzal mohammed
2020-03-04 20:31 ` Thomas Bogendoerfer
2020-03-05 11:57 ` [PATCH v4] " afzal mohammed
2020-03-06 12:47 ` Thomas Bogendoerfer [this message]
2020-03-11 5:31 ` Nathan Chancellor
2020-03-11 7:56 ` afzal mohammed
2020-03-11 9:03 ` afzal mohammed
2020-03-11 10:42 ` Thomas Bogendoerfer
2020-03-11 13:12 ` afzal mohammed
2020-03-11 16:03 ` Thomas Bogendoerfer
2020-03-11 16:32 ` afzal mohammed
2020-03-13 12:11 ` afzal mohammed
2020-03-14 8:13 ` [PATCH v2] MIPS: pass non-NULL dev_id on shared request_irq() afzal mohammed
2020-03-14 17:19 ` Guenter Roeck
2020-03-15 7:11 ` Nathan Chancellor
2020-03-16 15:32 ` Thomas Bogendoerfer
2020-03-14 6:55 ` [PATCH v4] MIPS: Replace setup_irq() by request_irq() afzal mohammed
2020-03-11 15:27 ` [PATCH] MIPS: pass non-NULL dev_id on shared request_irq() afzal mohammed
2020-03-11 16:06 ` afzal mohammed
2020-03-13 16:47 ` [PATCH v4] MIPS: Replace setup_irq() by request_irq() Guenter Roeck
2020-03-14 1:07 ` afzal mohammed
2020-03-14 5:21 ` maobibo
2020-03-14 6:49 ` afzal mohammed
2020-03-14 10:28 ` Guenter Roeck
2020-03-14 11:42 ` afzal mohammed
2020-03-05 12:29 ` [PATCH v3] " afzal mohammed
2020-03-05 12:42 ` afzal mohammed
2020-03-04 20:38 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200306124755.GA10251@alpha.franken.de \
--to=tsbogend@alpha$(echo .)franken.de \
--cc=afzal.mohd.ma@gmail$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=chenhc@lemote$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=jiaxun.yang@flygoat$(echo .)com \
--cc=john@phrozen$(echo .)org \
--cc=keguang.zhang@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=macro@linux-mips$(echo .)org \
--cc=paulburton@kernel$(echo .)org \
--cc=ralf@linux-mips$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox