From: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
To: Robert Foss <robert.foss@linaro•org>
Cc: mark.rutland@arm•com, devicetree@vger•kernel.org,
gregkh@linuxfoundation•org, linux-kernel@vger•kernel.org,
Tomasz Figa <tfiga@chromium•org>,
ben.kao@intel•com, robh+dt@kernel•org,
linux-mediatek@lists•infradead.org,
Dongchun Zhu <dongchun.zhu@mediatek•com>,
Jonathan.Cameron@huawei•com, matthias.bgg@gmail•com,
mchehab@kernel•org, davem@davemloft•net,
linux-arm-kernel@lists•infradead.org,
linux-media@vger•kernel.org
Subject: Re: [v1 3/3] media: ov8856: Implement sensor module revision identification
Date: Tue, 10 Mar 2020 16:30:14 +0200 [thread overview]
Message-ID: <20200310143014.GL1922688@smile.fi.intel.com> (raw)
In-Reply-To: <20200310134603.30260-4-robert.foss@linaro.org>
On Tue, Mar 10, 2020 at 02:46:03PM +0100, Robert Foss wrote:
> Query the sensor for its module revision, and compare it
> to known revisions.
> Currently only the '1B' revision has been added.
Are you sure you send latest version?
I have a déjà vu that I have seen this already and this one doesn't address any
comment given.
...
> + dev_info(&client->dev, "OV8856 revision %x (%s) at address 0x%02x\n",
> + val,
> + val == OV8856_1B_MODULE ? "1B" : "unknown revision",
This is weird. Can you add a bit more general way of showing revision?
> + client->addr);
--
With Best Regards,
Andy Shevchenko
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-10 14:30 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-10 13:46 [v1 0/3] media: ov8856: Add sensor modes & devicetree support Robert Foss
2020-03-10 13:46 ` [v1 1/3] media: dt-bindings: ov8856: Document YAML bindings Robert Foss
2020-03-10 13:57 ` Fabio Estevam
2020-03-10 15:51 ` Robert Foss
2020-03-12 10:13 ` Robert Foss
2020-03-10 18:38 ` Rob Herring
2020-03-10 13:46 ` [v1 2/3] media: ov8856: Add devicetree support Robert Foss
2020-03-10 14:03 ` Fabio Estevam
2020-03-10 15:46 ` Robert Foss
2020-03-10 14:26 ` Andy Shevchenko
2020-03-10 15:55 ` Robert Foss
2020-03-11 9:05 ` Andy Shevchenko
2020-03-11 11:48 ` Sakari Ailus
2020-03-11 13:32 ` Robert Foss
2020-03-11 16:16 ` Sakari Ailus
2020-03-10 13:46 ` [v1 3/3] media: ov8856: Implement sensor module revision identification Robert Foss
2020-03-10 14:30 ` Andy Shevchenko [this message]
2020-03-12 16:37 ` Robert Foss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200310143014.GL1922688@smile.fi.intel.com \
--to=andriy.shevchenko@linux$(echo .)intel.com \
--cc=Jonathan.Cameron@huawei$(echo .)com \
--cc=ben.kao@intel$(echo .)com \
--cc=davem@davemloft$(echo .)net \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dongchun.zhu@mediatek$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-media@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mchehab@kernel$(echo .)org \
--cc=robert.foss@linaro$(echo .)org \
--cc=robh+dt@kernel$(echo .)org \
--cc=tfiga@chromium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox