Subject: Re: [PATCH] ARM: dts: imx6q-dhcom: Add DH 560-200 display unit support

From: Shawn Guo <[email-masked]>
Date: Mon, 16 Mar 2020 09:00:49 +0800

On Tue, Mar 10, 2020 at 10:10:36PM +0100, Marek Vasut wrote:
> On 3/10/20 10:08 AM, Christoph Niedermaier wrote:
> > Hi Marek,
> 
> Hi,
> 
> > From: linux-arm-kernel [mailto:[email-masked]] On Behalf Of Marek Vasut
> > Sent: Monday, March 9, 2020 9:08 PM
> > 
> >> +	display_bl: display-bl {
> >> +		compatible = "pwm-backlight";
> >> +		pwms = <&pwm1 0 50000 PWM_POLARITY_INVERTED>;
> >> +		brightness-levels = <0 16 22 30 40 55 75 102 138 188 255>;
> >> +		default-brightness-level = <8>;
> >> +		enable-gpios = <&gpio3 27 GPIO_ACTIVE_HIGH>;
> >> +		status = "okay";
> >> +	};
> > ...
> >> +&pwm1 {
> >> +	pinctrl-names = "default";
> >> +	pinctrl-0 = <&pinctrl_pwm1>;
> >> +	status = "okay";
> >> +};
> > 
> > To get PWM_POLARITY_INVERTED, shouldn't we add the following line to pwm1:
> > #pwm-cells = <3>;
> 
> It seems some boards do set it, some do not, although that might also be
> a bug in the DT of those other board files or I'm reading it wrong.
> Let's see what the maintainers have to say.

The binding doc says we should have it.

Shawn

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel