From: Alexandre Belloni <alexandre.belloni@bootlin•com>
To: Anson Huang <anson.huang@nxp•com>
Cc: Peng Fan <peng.fan@nxp•com>,
"m.felsch@pengutronix•de" <m.felsch@pengutronix•de>,
Leonard Crestez <leonard.crestez@nxp•com>,
"festevam@gmail•com" <festevam@gmail•com>,
"linux-rtc@vger•kernel.org" <linux-rtc@vger•kernel.org>,
"robh@kernel•org" <robh@kernel•org>,
"amit.kucheria@verdurent•com" <amit.kucheria@verdurent•com>,
"wim@linux-watchdog•org" <wim@linux-watchdog•org>,
"daniel.lezcano@linaro•org" <daniel.lezcano@linaro•org>,
"krzk@kernel•org" <krzk@kernel•org>,
dl-linux-imx <linux-imx@nxp•com>,
"linux-input@vger•kernel.org" <linux-input@vger•kernel.org>,
"rui.zhang@intel•com" <rui.zhang@intel•com>,
"ronald@innovation•ch" <ronald@innovation•ch>,
"linux@roeck-us•net" <linux@roeck-us•net>,
"linux-watchdog@vger•kernel.org" <linux-watchdog@vger•kernel.org>,
"arnd@arndb•de" <arnd@arndb•de>,
"linux-pm@vger•kernel.org" <linux-pm@vger•kernel.org>,
"s.hauer@pengutronix•de" <s.hauer@pengutronix•de>,
"tglx@linutronix•de" <tglx@linutronix•de>,
"andriy.shevchenko@linux•intel.com"
<andriy.shevchenko@linux•intel.com>,
Daniel Baluta <daniel.baluta@nxp•com>,
"linux-arm-kernel@lists•infradead.org"
<linux-arm-kernel@lists•infradead.org>,
Aisheng Dong <aisheng.dong@nxp•com>,
"a.zummo@towertech•it" <a.zummo@towertech•it>,
"gregkh@linuxfoundation•org" <gregkh@linuxfoundation•org>,
"dmitry.torokhov@gmail•com" <dmitry.torokhov@gmail•com>,
"linux-kernel@vger•kernel.org" <linux-kernel@vger•kernel.org>,
"linux@rempel-privat•de" <linux@rempel-privat•de>,
"kernel@pengutronix•de" <kernel@pengutronix•de>,
Shawn Guo <shawnguo@kernel•org>
Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case
Date: Mon, 16 Mar 2020 10:00:53 +0100 [thread overview]
Message-ID: <20200316090053.GH4518@piout.net> (raw)
In-Reply-To: <DB3PR0402MB391663DB37A8D241092AD708F5F90@DB3PR0402MB3916.eurprd04.prod.outlook.com>
On 16/03/2020 08:44:10+0000, Anson Huang wrote:
>
>
> > Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU
> > case
> >
> > On 16/03/2020 08:04:17+0000, Anson Huang wrote:
> > > Hi, Shawn
> > >
> > > > Subject: Re: [PATCH V3 1/7] firmware: imx: Add stubs for
> > > > !CONFIG_IMX_SCU case
> > > >
> > > > On Mon, Mar 16, 2020 at 03:18:43AM +0000, Peng Fan wrote:
> > > > > Just sent out. One more thing, I think all drivers depends on
> > > > > IMX_SCU should not have COMPILE_TEST if we plan not to add dummy
> > > > > functions. I see you picked up Anson's patch in imx/drivers branch,
> > please check more.
> > > >
> > > > Ha, yes. COMPILE_TEST should be dropped for IMX_SCU_PD in Anson's
> > patch.
> > > > Thanks for reminding.
> > >
> > > I still NOT quite understand why we won't support COMPILE_TEST for SCU
> > > drivers, with whose stubs, the build should be OK, if there is any
> > > build error, we should try to fix it, NOT just remove the COMPILE_TEST
> > support, any special reason?
> > >
> >
> > COMPILE_TEST is supported as long as IMX_SCU is selected like is it for any
> > driver depending on any bus.
>
> But without having " || COMPILE_TEST " in kconfig, COMPILE_TEST will NOT be supported,
> I think as long as we have stubs for those SCU APIs, all drivers depending on IMX_SCU can
> support COMPILE_TEST independently.
>
Why do you absolutely need to compile them independently? From a code
coverage point of view, having:
COMPILE_TEST=y
CONFIG_IMX_SCU=y
is enough to select and compile the remaining drivers.
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-03-16 9:01 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-09 0:38 [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Anson Huang
2020-03-09 0:38 ` [PATCH V3 2/7] firmware: imx: add COMPILE_TEST support Anson Huang
2020-03-16 0:53 ` Shawn Guo
2020-03-16 3:37 ` Shawn Guo
2020-03-09 0:38 ` [PATCH V3 3/7] rtc: add COMPILE_TEST support for i.MX SC RTC Anson Huang
2020-03-09 0:38 ` [PATCH V3 4/7] input: keyboard: add COMPILE_TEST support for KEYBOARD_IMX_SC_KEY Anson Huang
2020-03-09 0:38 ` [PATCH V3 5/7] input: keyboard: imx_sc_key: Fix build warning for !CONFIG_IMX_SCU case Anson Huang
2020-03-09 0:38 ` [PATCH V3 6/7] watchdog: add COMPILE_TEST support for IMX_SC_WDT Anson Huang
2020-03-09 0:38 ` [PATCH V3 7/7] thermal: add COMPILE_TEST support for IMX_SC_THERMAL Anson Huang
2020-03-09 11:06 ` [PATCH V3 1/7] firmware: imx: Add stubs for !CONFIG_IMX_SCU case Alexandre Belloni
2020-03-09 12:20 ` Anson Huang
2020-03-09 13:27 ` Guenter Roeck
2020-03-09 13:37 ` Anson Huang
2020-03-09 16:47 ` Alexandre Belloni
2020-03-09 17:10 ` Guenter Roeck
2020-03-09 17:30 ` Alexandre Belloni
2020-03-09 18:19 ` Guenter Roeck
2020-03-09 13:40 ` Peng Fan
2020-03-09 14:09 ` Anson Huang
2020-03-16 0:52 ` Shawn Guo
2020-03-16 2:51 ` Peng Fan
2020-03-16 3:07 ` Shawn Guo
2020-03-16 3:18 ` Peng Fan
2020-03-16 3:34 ` Shawn Guo
2020-03-16 8:04 ` Anson Huang
2020-03-16 8:40 ` Alexandre Belloni
2020-03-16 8:44 ` Anson Huang
2020-03-16 9:00 ` Alexandre Belloni [this message]
2020-03-16 9:08 ` Anson Huang
2020-03-16 9:15 ` Alexandre Belloni
2020-03-16 9:40 ` Anson Huang
2020-03-16 10:00 ` Alexandre Belloni
2020-03-16 10:18 ` Anson Huang
2020-03-17 2:18 ` Peng Fan
2020-03-17 2:29 ` Anson Huang
2020-03-17 2:32 ` Guenter Roeck
2020-03-17 2:35 ` Anson Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200316090053.GH4518@piout.net \
--to=alexandre.belloni@bootlin$(echo .)com \
--cc=a.zummo@towertech$(echo .)it \
--cc=aisheng.dong@nxp$(echo .)com \
--cc=amit.kucheria@verdurent$(echo .)com \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=anson.huang@nxp$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=daniel.baluta@nxp$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=dmitry.torokhov@gmail$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=kernel@pengutronix$(echo .)de \
--cc=krzk@kernel$(echo .)org \
--cc=leonard.crestez@nxp$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-input@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-rtc@vger$(echo .)kernel.org \
--cc=linux-watchdog@vger$(echo .)kernel.org \
--cc=linux@rempel-privat$(echo .)de \
--cc=linux@roeck-us$(echo .)net \
--cc=m.felsch@pengutronix$(echo .)de \
--cc=peng.fan@nxp$(echo .)com \
--cc=robh@kernel$(echo .)org \
--cc=ronald@innovation$(echo .)ch \
--cc=rui.zhang@intel$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=wim@linux-watchdog$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox