From: Alyssa Rosenzweig <alyssa.rosenzweig@collabora•com>
To: Lukasz Luba <lukasz.luba@arm•com>
Cc: nm@ti•com, juri.lelli@redhat•com, peterz@infradead•org,
viresh.kumar@linaro•org, liviu.dudau@arm•com,
dri-devel@lists•freedesktop.org, bjorn.andersson@linaro•org,
bsegall@google•com, festevam@gmail•com, Morten.Rasmussen@arm•com,
robh@kernel•org, amit.kucheria@verdurent•com,
lorenzo.pieralisi@arm•com, khilman@kernel•org, agross@kernel•org,
daniel.lezcano@linaro•org, steven.price@arm•com,
cw00.choi@samsung•com, mingo@redhat•com, linux-imx@nxp•com,
rui.zhang@intel•com, mgorman@suse•de, orjan.eide@arm•com,
daniel@ffwll•ch, linux-pm@vger•kernel.org,
linux-arm-msm@vger•kernel.org, s.hauer@pengutronix•de,
rostedt@goodmis•org, linux-mediatek@lists•infradead.org,
matthias.bgg@gmail•com, linux-omap@vger•kernel.org,
Dietmar.Eggemann@arm•com, linux-arm-kernel@lists•infradead.org,
airlied@linux•ie, javi.merino@arm•com,
tomeu.vizoso@collabora•com, qperret@google•com, sboyd@kernel•org,
mka@chromium•org, rdunlap@infradead•org, rjw@rjwysocki•net,
linux-kernel@vger•kernel.org, b.zolnierkie@samsung•com,
kernel@pengutronix•de, sudeep.holla@arm•com,
patrick.bellasi@matbug•net, shawnguo@kernel•org
Subject: Re: [PATCH v5 5/5] drm/panfrost: Register devfreq cooling and attempt to add Energy Model
Date: Wed, 18 Mar 2020 09:11:14 -0400 [thread overview]
Message-ID: <20200318131114.GA1812@kevin> (raw)
In-Reply-To: <20200318114548.19916-6-lukasz.luba@arm.com>
[-- Attachment #1.1: Type: text/plain, Size: 1368 bytes --]
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora•com>
On Wed, Mar 18, 2020 at 11:45:48AM +0000, Lukasz Luba wrote:
> Register devfreq cooling device and attempt to register Energy Model. This
> will add the devfreq device to the Energy Model framework. It will create
> a dedicated and unified data structures used i.e. in thermal framework.
> The last NULL parameter indicates that the power model is simplified and
> created based on DT 'dynamic-power-coefficient', voltage and frequency.
>
> Reviewed-by: Steven Price <steven.price@arm•com>
> Signed-off-by: Lukasz Luba <lukasz.luba@arm•com>
> ---
> drivers/gpu/drm/panfrost/panfrost_devfreq.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/panfrost/panfrost_devfreq.c b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> index 413987038fbf..8759a73db153 100644
> --- a/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> +++ b/drivers/gpu/drm/panfrost/panfrost_devfreq.c
> @@ -105,7 +105,7 @@ int panfrost_devfreq_init(struct panfrost_device *pfdev)
> }
> pfdev->devfreq.devfreq = devfreq;
>
> - cooling = of_devfreq_cooling_register(dev->of_node, devfreq);
> + cooling = devfreq_cooling_em_register(devfreq, NULL);
> if (IS_ERR(cooling))
> DRM_DEV_INFO(dev, "Failed to register cooling device\n");
> else
> --
> 2.17.1
>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2020-03-18 13:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200318114548.19916-1-lukasz.luba@arm.com>
[not found] ` <20200318114548.19916-6-lukasz.luba@arm.com>
2020-03-18 13:11 ` Alyssa Rosenzweig [this message]
2020-03-23 13:50 ` [PATCH v5 5/5] drm/panfrost: Register devfreq cooling and attempt to add Energy Model Lukasz Luba
[not found] ` <20200318114548.19916-5-lukasz.luba@arm.com>
2020-04-01 10:49 ` [PATCH v5 4/5] thermal: devfreq_cooling: Refactor code and switch to use " Lukasz Luba
2020-04-03 17:44 ` Daniel Lezcano
2020-04-06 13:35 ` Lukasz Luba
[not found] ` <20200318114548.19916-2-lukasz.luba@arm.com>
2020-04-03 16:05 ` [PATCH v5 1/5] PM / EM: add devices to " Daniel Lezcano
2020-04-06 13:29 ` Lukasz Luba
2020-04-06 14:58 ` Daniel Lezcano
2020-04-06 16:07 ` Lukasz Luba
2020-04-06 21:17 ` Daniel Lezcano
2020-04-07 9:32 ` Lukasz Luba
[not found] ` <20200318114548.19916-3-lukasz.luba@arm.com>
2020-04-01 7:19 ` [PATCH v5 2/5] OPP: refactor dev_pm_opp_of_register_em() and update related drivers Lukasz Luba
2020-04-03 16:21 ` Daniel Lezcano
2020-04-06 14:05 ` Lukasz Luba
[not found] ` <20200318114548.19916-4-lukasz.luba@arm.com>
2020-04-03 16:43 ` [PATCH v5 3/5] thermal: devfreq_cooling: Use PM QoS to set frequency limits Daniel Lezcano
2020-04-03 17:18 ` Matthias Kaehlcke
2020-04-03 17:19 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200318131114.GA1812@kevin \
--to=alyssa.rosenzweig@collabora$(echo .)com \
--cc=Dietmar.Eggemann@arm$(echo .)com \
--cc=Morten.Rasmussen@arm$(echo .)com \
--cc=agross@kernel$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=amit.kucheria@verdurent$(echo .)com \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=bsegall@google$(echo .)com \
--cc=cw00.choi@samsung$(echo .)com \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=daniel@ffwll$(echo .)ch \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=festevam@gmail$(echo .)com \
--cc=javi.merino@arm$(echo .)com \
--cc=juri.lelli@redhat$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=liviu.dudau@arm$(echo .)com \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=lukasz.luba@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mgorman@suse$(echo .)de \
--cc=mingo@redhat$(echo .)com \
--cc=mka@chromium$(echo .)org \
--cc=nm@ti$(echo .)com \
--cc=orjan.eide@arm$(echo .)com \
--cc=patrick.bellasi@matbug$(echo .)net \
--cc=peterz@infradead$(echo .)org \
--cc=qperret@google$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=rjw@rjwysocki$(echo .)net \
--cc=robh@kernel$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=rui.zhang@intel$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=sboyd@kernel$(echo .)org \
--cc=shawnguo@kernel$(echo .)org \
--cc=steven.price@arm$(echo .)com \
--cc=sudeep.holla@arm$(echo .)com \
--cc=tomeu.vizoso@collabora$(echo .)com \
--cc=viresh.kumar@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox