From: Jonathan Cameron <jic23@kernel•org>
To: Aishwarya R <aishwaryarj100@gmail•com>
Cc: Kate Stewart <kstewart@linuxfoundation•org>,
Enrico Weigelt <info@metux•net>,
Lars-Peter Clausen <lars@metafoo•de>,
Peter Meerwald-Stadler <pmeerw@pmeerw•net>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
linux-iio@vger•kernel.org, Fabio Estevam <festevam@gmail•com>,
Sascha Hauer <s.hauer@pengutronix•de>,
linux-kernel@vger•kernel.org, Stephen Boyd <swboyd@chromium•org>,
NXP Linux Team <linux-imx@nxp•com>,
Pengutronix Kernel Team <kernel@pengutronix•de>,
Hartmut Knaack <knaack.h@gmx•de>,
Thomas Gleixner <tglx@linutronix•de>,
Shawn Guo <shawnguo@kernel•org>,
linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH] iio: adc: fsl-imx25-gcq: Use devm_platform_ioremap_resource
Date: Sun, 12 Apr 2020 11:25:41 +0100 [thread overview]
Message-ID: <20200412112541.2a2097fa@archlinux> (raw)
In-Reply-To: <20200409151306.308-1-aishwaryarj100@gmail.com>
On Thu, 9 Apr 2020 20:43:05 +0530
Aishwarya R <aishwaryarj100@gmail•com> wrote:
> Use the helper function that wraps the calls to
> platform_get_resource() and devm_ioremap_resource()
> together.
>
> Signed-off-by: Aishwarya R <aishwaryarj100@gmail•com>
Please update the commit message for v2. In particular if an automated
tool was used to identify this location then mention that. If not just
say 'by inspection' or similar!
Also, same thing about the signed-off-by as in previous patch.
Thanks,
Jonathan
> ---
> drivers/iio/adc/fsl-imx25-gcq.c | 4 +---
> 1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/iio/adc/fsl-imx25-gcq.c b/drivers/iio/adc/fsl-imx25-gcq.c
> index fa71489195c6..b0a4dc88ba9b 100644
> --- a/drivers/iio/adc/fsl-imx25-gcq.c
> +++ b/drivers/iio/adc/fsl-imx25-gcq.c
> @@ -294,7 +294,6 @@ static int mx25_gcq_probe(struct platform_device *pdev)
> struct mx25_gcq_priv *priv;
> struct mx25_tsadc *tsadc = dev_get_drvdata(pdev->dev.parent);
> struct device *dev = &pdev->dev;
> - struct resource *res;
> void __iomem *mem;
> int ret;
> int i;
> @@ -305,8 +304,7 @@ static int mx25_gcq_probe(struct platform_device *pdev)
>
> priv = iio_priv(indio_dev);
>
> - res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> - mem = devm_ioremap_resource(dev, res);
> + mem = devm_platform_ioremap_resource(pdev, 0);
> if (IS_ERR(mem))
> return PTR_ERR(mem);
>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-12 10:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-09 15:13 [PATCH] iio: adc: fsl-imx25-gcq: Use devm_platform_ioremap_resource Aishwarya R
2020-04-12 10:25 ` Jonathan Cameron [this message]
2020-04-12 13:50 ` Aishwarya R
2020-04-13 15:37 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200412112541.2a2097fa@archlinux \
--to=jic23@kernel$(echo .)org \
--cc=aishwaryarj100@gmail$(echo .)com \
--cc=festevam@gmail$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=info@metux$(echo .)net \
--cc=kernel@pengutronix$(echo .)de \
--cc=knaack.h@gmx$(echo .)de \
--cc=kstewart@linuxfoundation$(echo .)org \
--cc=lars@metafoo$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=pmeerw@pmeerw$(echo .)net \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=shawnguo@kernel$(echo .)org \
--cc=swboyd@chromium$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox