From: Russell King - ARM Linux admin <linux@armlinux•org.uk>
To: Robin Murphy <robin.murphy@arm•com>
Cc: Mark Rutland <mark.rutland@arm•com>, Andrew Lunn <andrew@lunn•ch>,
Jason Cooper <jason@lakedaemon•net>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger•kernel.org>,
Linus Walleij <linus.walleij@linaro•org>,
linux-pwm@vger•kernel.org,
"open list:GPIO SUBSYSTEM" <linux-gpio@vger•kernel.org>,
Rob Herring <robh+dt@kernel•org>,
Thierry Reding <thierry.reding@gmail•com>,
Uwe Kleine-Konig <u.kleine-koenig@pengutronix•de>,
Bartosz Golaszewski <bgolaszewski@baylibre•com>,
Gregory Clement <gregory.clement@bootlin•com>,
Linux ARM <linux-arm-kernel@lists•infradead.org>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail•com>
Subject: Re: [PATCH RFC 0/6] PWM fan support on Clearfog gt8k
Date: Thu, 16 Apr 2020 15:55:17 +0100 [thread overview]
Message-ID: <20200416145517.GK25745@shell.armlinux.org.uk> (raw)
In-Reply-To: <5c7cb0ff-bf49-640a-3c4a-ef71495af7b7@arm.com>
On Thu, Apr 16, 2020 at 03:37:40PM +0100, Robin Murphy wrote:
> On 2020-04-16 2:50 pm, Andrew Lunn wrote:
> [...]
> > Clocking with Marvell devices has always been interesting. Core IP
> > like this gets reused between different generations of SoCs. The
> > original Orion5x had no clock control at all. Latter SoCs have had
> > more and more complex clock trees. So care has to be taken to not
> > change old behaviour when adding support for new clocks.
>
> FWIW, that sounds like a good argument for encoding the clock requirements
> of each variant in the of_match_data, so the driver doesn't have to simply
> trust the DT and hope.
Please read my patches. This is exactly what I'm doing. I'm preserving
as closely as possible the current driver behaviour while adding support
for the Armada 8040 PWM while keeping compatibility with older DT.
And I'm doing that by keying off the match data, exactly as you're
suggesting above.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 10.2Mbps down 587kbps up
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-16 14:55 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-03-29 10:45 [PATCH RFC 0/6] PWM fan support on Clearfog gt8k Russell King - ARM Linux admin
2020-03-29 10:48 ` [PATCH RFC 1/6] gpio: mvebu: convert pwm to regmap Russell King
2020-03-29 10:48 ` [PATCH RFC 2/6] gpio: mvebu: honour EPROBE_DEFER for devm_clk_get() Russell King
2020-03-29 13:16 ` Uwe Kleine-König
2020-03-29 13:34 ` Russell King - ARM Linux admin
2020-03-29 18:00 ` Uwe Kleine-König
2020-03-29 18:22 ` Russell King - ARM Linux admin
2020-03-31 16:29 ` Uwe Kleine-König
2020-03-29 10:48 ` [PATCH RFC 3/6] gpio: mvebu: add PWM support for Armada 8k Russell King
2020-03-29 11:00 ` Russell King - ARM Linux admin
2020-03-29 10:48 ` [PATCH RFC 4/6] arm64: dts: armada-cp11x: add pwm support to GPIO blocks Russell King
2020-03-29 10:48 ` [PATCH RFC 5/6] arm64: dts: clearfog-gt-8k: add pwm-fan Russell King
2020-03-29 10:48 ` [PATCH RFC 6/6] arm64: dts: clearfog-gt-8k: add cooling maps Russell King
2020-04-16 7:51 ` [PATCH RFC 0/6] PWM fan support on Clearfog gt8k Linus Walleij
2020-04-16 8:14 ` Russell King - ARM Linux admin
2020-04-16 12:08 ` Linus Walleij
2020-04-16 14:53 ` Russell King - ARM Linux admin
2020-04-16 13:50 ` Andrew Lunn
2020-04-16 14:29 ` Russell King - ARM Linux admin
2020-04-16 14:36 ` Andrew Lunn
2020-04-16 14:41 ` Russell King - ARM Linux admin
2020-04-16 14:37 ` Robin Murphy
2020-04-16 14:42 ` Andrew Lunn
2020-04-16 16:20 ` Robin Murphy
2020-04-16 16:49 ` Andrew Lunn
2020-04-16 14:55 ` Russell King - ARM Linux admin [this message]
2020-04-16 15:55 ` Robin Murphy
2020-04-16 16:37 ` Russell King - ARM Linux admin
2020-04-16 16:49 ` Russell King - ARM Linux admin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200416145517.GK25745@shell.armlinux.org.uk \
--to=linux@armlinux$(echo .)org.uk \
--cc=andrew@lunn$(echo .)ch \
--cc=bgolaszewski@baylibre$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=jason@lakedaemon$(echo .)net \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-pwm@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=robin.murphy@arm$(echo .)com \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox