From: Peter Zijlstra <peterz@infradead•org>
To: Zhenyu Ye <yezhenyu2@huawei•com>
Cc: mark.rutland@arm•com, catalin.marinas@arm•com,
linux-mm@kvack•org, guohanjun@huawei•com, will@kernel•org,
linux-arch@vger•kernel.org, yuzhao@google•com, maz@kernel•org,
steven.price@arm•com, arm@kernel•org, Dave.Martin@arm•com,
arnd@arndb•de, suzuki.poulose@arm•com, npiggin@gmail•com,
zhangshaokun@hisilicon•com, broonie@kernel•org,
rostedt@goodmis•org, prime.zeng@hisilicon•com,
kuhn.chenqun@huawei•com, tglx@linutronix•de,
linux-arm-kernel@lists•infradead.org, xiexiangyou@huawei•com,
linux-kernel@vger•kernel.org, aneesh.kumar@linux•ibm.com,
akpm@linux-foundation•org
Subject: Re: [PATCH v1 6/6] arm64: tlb: Set the TTL field in flush_tlb_range
Date: Mon, 20 Apr 2020 14:10:55 +0200 [thread overview]
Message-ID: <20200420121055.GF20696@hirez.programming.kicks-ass.net> (raw)
In-Reply-To: <20200403090048.938-7-yezhenyu2@huawei.com>
On Fri, Apr 03, 2020 at 05:00:48PM +0800, Zhenyu Ye wrote:
> This patch uses the cleared_* in struct mmu_gather to set the
> TTL field in flush_tlb_range().
>
> Signed-off-by: Zhenyu Ye <yezhenyu2@huawei•com>
> ---
> arch/arm64/include/asm/tlb.h | 26 +++++++++++++++++++++++++-
> arch/arm64/include/asm/tlbflush.h | 14 ++++++++------
> 2 files changed, 33 insertions(+), 7 deletions(-)
>
> diff --git a/arch/arm64/include/asm/tlb.h b/arch/arm64/include/asm/tlb.h
> index b76df828e6b7..d5ab72eccff4 100644
> --- a/arch/arm64/include/asm/tlb.h
> +++ b/arch/arm64/include/asm/tlb.h
> @@ -21,11 +21,34 @@ static void tlb_flush(struct mmu_gather *tlb);
>
> #include <asm-generic/tlb.h>
>
> +/*
> + * get the tlbi levels in arm64. Default value is 0 if more than one
> + * of cleared_* is set or neither is set.
> + * Arm64 doesn't support p4ds now.
> + */
> +static inline int tlb_get_level(struct mmu_gather *tlb)
> +{
> + int sum = tlb->cleared_ptes + tlb->cleared_pmds +
> + tlb->cleared_puds + tlb->cleared_p4ds;
> +
> + if (sum != 1)
> + return 0;
> + else if (tlb->cleared_ptes)
> + return 3;
> + else if (tlb->cleared_pmds)
> + return 2;
> + else if (tlb->cleared_puds)
> + return 1;
> +
> + return 0;
> +}
That's some mighty wonky code. Please look at the generated asm.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-20 12:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-03 9:00 [PATCH v1 0/6] arm64: tlb: add support for TTL feature Zhenyu Ye
2020-04-03 9:00 ` [PATCH v1 1/6] arm64: Detect the ARMv8.4 " Zhenyu Ye
2020-04-21 16:53 ` Christoph Hellwig
2020-04-21 17:13 ` Peter Zijlstra
2020-04-21 17:16 ` Christoph Hellwig
2020-04-22 2:13 ` Zhenyu Ye
2020-04-03 9:00 ` [PATCH v1 2/6] arm64: Add level-hinted TLB invalidation helper Zhenyu Ye
2020-04-03 9:00 ` [PATCH v1 3/6] arm64: Add tlbi_user_level " Zhenyu Ye
2020-04-03 9:00 ` [PATCH v1 4/6] tlb: mmu_gather: add tlb_set_*_range APIs Zhenyu Ye
2020-04-20 11:46 ` Peter Zijlstra
2020-04-03 9:00 ` [PATCH v1 5/6] mm: tlb: Provide flush_*_tlb_range wrappers Zhenyu Ye
2020-04-20 12:09 ` Peter Zijlstra
2020-04-21 14:18 ` Zhenyu Ye
2020-04-03 9:00 ` [PATCH v1 6/6] arm64: tlb: Set the TTL field in flush_tlb_range Zhenyu Ye
2020-04-20 12:10 ` Peter Zijlstra [this message]
2020-04-21 0:06 ` Steven Rostedt
2020-04-21 8:30 ` Peter Zijlstra
2020-04-21 12:22 ` Zhenyu Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200420121055.GF20696@hirez.programming.kicks-ass.net \
--to=peterz@infradead$(echo .)org \
--cc=Dave.Martin@arm$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=aneesh.kumar@linux$(echo .)ibm.com \
--cc=arm@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=broonie@kernel$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=guohanjun@huawei$(echo .)com \
--cc=kuhn.chenqun@huawei$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=maz@kernel$(echo .)org \
--cc=npiggin@gmail$(echo .)com \
--cc=prime.zeng@hisilicon$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=steven.price@arm$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=will@kernel$(echo .)org \
--cc=xiexiangyou@huawei$(echo .)com \
--cc=yezhenyu2@huawei$(echo .)com \
--cc=yuzhao@google$(echo .)com \
--cc=zhangshaokun@hisilicon$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox