From: Daniel Lezcano <daniel.lezcano@linaro•org>
To: Lukasz Luba <lukasz.luba@arm•com>
Cc: nm@ti•com, juri.lelli@redhat•com, peterz@infradead•org,
viresh.kumar@linaro•org, liviu.dudau@arm•com,
dri-devel@lists•freedesktop.org, bjorn.andersson@linaro•org,
bsegall@google•com, alyssa.rosenzweig@collabora•com,
festevam@gmail•com, mka@chromium•org, robh@kernel•org,
amit.kucheria@verdurent•com, lorenzo.pieralisi@arm•com,
khilman@kernel•org, agross@kernel•org, b.zolnierkie@samsung•com,
steven.price@arm•com, cw00.choi@samsung•com, mingo@redhat•com,
linux-imx@nxp•com, rui.zhang@intel•com, mgorman@suse•de,
orjan.eide@arm•com, daniel@ffwll•ch, linux-pm@vger•kernel.org,
linux-arm-msm@vger•kernel.org, s.hauer@pengutronix•de,
rostedt@goodmis•org, linux-mediatek@lists•infradead.org,
matthias.bgg@gmail•com, linux-omap@vger•kernel.org,
Dietmar.Eggemann@arm•com, linux-arm-kernel@lists•infradead.org,
airlied@linux•ie, tomeu.vizoso@collabora•com, qperret@google•com,
sboyd@kernel•org, rdunlap@infradead•org, rjw@rjwysocki•net,
linux-kernel@vger•kernel.org, kernel@pengutronix•de,
sudeep.holla@arm•com, patrick.bellasi@matbug•net,
shawnguo@kernel•org
Subject: Re: [PATCH v6 03/10] PM / EM: update callback structure and add device pointer
Date: Thu, 23 Apr 2020 15:22:43 +0200 [thread overview]
Message-ID: <20200423132243.GA65632@linaro.org> (raw)
In-Reply-To: <20200410084210.24932-4-lukasz.luba@arm.com>
On Fri, Apr 10, 2020 at 09:42:03AM +0100, Lukasz Luba wrote:
> The Energy Model framework is going to support devices other that CPUs. In
> order to make this happen change the callback function and add pointer to
> a device as an argument.
>
> Update the related users to use new function and new callback from the
> Energy Model.
>
> Signed-off-by: Lukasz Luba <lukasz.luba@arm•com>
> ---
[ ... ]
> +static struct em_perf_domain *
> +em_create_pd(struct device *dev, int nr_states, struct em_data_callback *cb,
> + cpumask_t *span)
> {
> unsigned long opp_eff, prev_opp_eff = ULONG_MAX;
> unsigned long power, freq, prev_freq = 0;
> @@ -106,7 +107,7 @@ static struct em_perf_domain *em_create_pd(cpumask_t *span, int nr_states,
> * lowest performance state of 'cpu' above 'freq' and updates
> * 'power' and 'freq' accordingly.
> */
> - ret = cb->active_power(&power, &freq, cpu);
> + ret = cb->active_power(&power, &freq, dev);
> if (ret) {
> pr_err("pd%d: invalid perf. state: %d\n", cpu, ret);
> goto free_ps_table;
Why are the changes 'cpu' to 'dev' in the patch 4/10 instead of this one ?
> @@ -237,7 +238,7 @@ int em_dev_register_perf_domain(struct device *dev, unsigned int nr_states,
> }
>
> /* Create the performance domain and add it to the Energy Model. */
> - pd = em_create_pd(span, nr_states, cb);
> + pd = em_create_pd(dev, nr_states, cb, span);
> if (!pd) {
> ret = -EINVAL;
> goto unlock;
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-04-23 13:23 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-10 8:42 [PATCH v6 00/10] Add support for devices in the Energy Model Lukasz Luba
2020-04-10 8:42 ` [PATCH v6 01/10] PM / EM: change naming convention from 'capacity' to 'performance' Lukasz Luba
2020-04-23 9:55 ` Daniel Lezcano
2020-04-10 8:42 ` [PATCH v6 02/10] PM / EM: introduce em_dev_register_perf_domain function Lukasz Luba
2020-04-23 10:46 ` Daniel Lezcano
2020-04-10 8:42 ` [PATCH v6 03/10] PM / EM: update callback structure and add device pointer Lukasz Luba
2020-04-23 13:22 ` Daniel Lezcano [this message]
2020-04-23 15:28 ` Lukasz Luba
2020-04-10 8:42 ` [PATCH v6 04/10] PM / EM: add support for other devices than CPUs in Energy Model Lukasz Luba
2020-04-10 11:12 ` Luis Gerhorst
2020-04-10 11:34 ` Lukasz Luba
2020-04-23 15:12 ` Daniel Lezcano
2020-04-23 16:57 ` Lukasz Luba
2020-04-23 17:15 ` Daniel Lezcano
2020-04-23 17:19 ` Lukasz Luba
2020-04-10 8:42 ` [PATCH v6 05/10] PM / EM: remove em_register_perf_domain Lukasz Luba
2020-04-23 15:14 ` Daniel Lezcano
2020-04-10 8:42 ` [PATCH v6 06/10] PM / EM: change name of em_pd_energy to em_cpu_energy Lukasz Luba
2020-04-23 15:28 ` Daniel Lezcano
2020-04-10 8:42 ` [PATCH v6 07/10] Documentation: power: update Energy Model description Lukasz Luba
2020-04-23 16:07 ` Daniel Lezcano
2020-04-10 8:42 ` [PATCH v6 08/10] OPP: refactor dev_pm_opp_of_register_em() and update related drivers Lukasz Luba
2020-04-23 16:47 ` Daniel Lezcano
2020-04-10 8:42 ` [PATCH v6 09/10] thermal: devfreq_cooling: Refactor code and switch to use Energy Model Lukasz Luba
2020-04-23 17:57 ` Daniel Lezcano
2020-04-24 10:02 ` Lukasz Luba
2020-04-24 10:43 ` Daniel Lezcano
2020-04-10 8:42 ` [PATCH v6 10/10] drm/panfrost: Register devfreq cooling and attempt to add " Lukasz Luba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200423132243.GA65632@linaro.org \
--to=daniel.lezcano@linaro$(echo .)org \
--cc=Dietmar.Eggemann@arm$(echo .)com \
--cc=agross@kernel$(echo .)org \
--cc=airlied@linux$(echo .)ie \
--cc=alyssa.rosenzweig@collabora$(echo .)com \
--cc=amit.kucheria@verdurent$(echo .)com \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=bjorn.andersson@linaro$(echo .)org \
--cc=bsegall@google$(echo .)com \
--cc=cw00.choi@samsung$(echo .)com \
--cc=daniel@ffwll$(echo .)ch \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=festevam@gmail$(echo .)com \
--cc=juri.lelli@redhat$(echo .)com \
--cc=kernel@pengutronix$(echo .)de \
--cc=khilman@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-arm-msm@vger$(echo .)kernel.org \
--cc=linux-imx@nxp$(echo .)com \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=liviu.dudau@arm$(echo .)com \
--cc=lorenzo.pieralisi@arm$(echo .)com \
--cc=lukasz.luba@arm$(echo .)com \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mgorman@suse$(echo .)de \
--cc=mingo@redhat$(echo .)com \
--cc=mka@chromium$(echo .)org \
--cc=nm@ti$(echo .)com \
--cc=orjan.eide@arm$(echo .)com \
--cc=patrick.bellasi@matbug$(echo .)net \
--cc=peterz@infradead$(echo .)org \
--cc=qperret@google$(echo .)com \
--cc=rdunlap@infradead$(echo .)org \
--cc=rjw@rjwysocki$(echo .)net \
--cc=robh@kernel$(echo .)org \
--cc=rostedt@goodmis$(echo .)org \
--cc=rui.zhang@intel$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=sboyd@kernel$(echo .)org \
--cc=shawnguo@kernel$(echo .)org \
--cc=steven.price@arm$(echo .)com \
--cc=sudeep.holla@arm$(echo .)com \
--cc=tomeu.vizoso@collabora$(echo .)com \
--cc=viresh.kumar@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox