From: Al Viro <viro@zeniv•linux.org.uk>
To: ira.weiny@intel•com
Cc: Peter Zijlstra <peterz@infradead•org>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Dave Hansen <dave.hansen@linux•intel.com>,
dri-devel@lists•freedesktop.org, linux-mips@vger•kernel.org,
"James E.J. Bottomley" <James.Bottomley@hansenpartnership•com>,
Max Filippov <jcmvbkbc@gmail•com>, Huang Rui <ray.huang@amd•com>,
Paul Mackerras <paulus@samba•org>,
"H. Peter Anvin" <hpa@zytor•com>,
sparclinux@vger•kernel.org,
Dan Williams <dan.j.williams@intel•com>,
Helge Deller <deller@gmx•de>,
x86@kernel•org, linux-csky@vger•kernel.org,
Ingo Molnar <mingo@redhat•com>,
linux-snps-arc@lists•infradead.org,
linux-xtensa@linux-xtensa•org, Borislav Petkov <bp@alien8•de>,
Andy Lutomirski <luto@kernel•org>,
Thomas Gleixner <tglx@linutronix•de>,
linux-arm-kernel@lists•infradead.org,
Chris Zankel <chris@zankel•net>,
Thomas Bogendoerfer <tsbogend@alpha•franken.de>,
linux-parisc@vger•kernel.org, linux-kernel@vger•kernel.org,
Christian Koenig <christian.koenig@amd•com>,
Andrew Morton <akpm@linux-foundation•org>,
linuxppc-dev@lists•ozlabs.org,
"David S. Miller" <davem@davemloft•net>
Subject: Re: [PATCH V1 09/10] arch/kmap: Define kmap_atomic_prot() for all arch's
Date: Fri, 1 May 2020 03:37:34 +0100 [thread overview]
Message-ID: <20200501023734.GF23230@ZenIV.linux.org.uk> (raw)
In-Reply-To: <20200430203845.582900-10-ira.weiny@intel.com>
On Thu, Apr 30, 2020 at 01:38:44PM -0700, ira.weiny@intel•com wrote:
> -static inline void *kmap_atomic(struct page *page)
> +static inline void *kmap_atomic_prot(struct page *page, pgprot_t prot)
> {
> preempt_disable();
> pagefault_disable();
> if (!PageHighMem(page))
> return page_address(page);
> - return kmap_atomic_high(page);
> + return kmap_atomic_high_prot(page, prot);
> }
> +#define kmap_atomic(page) kmap_atomic_prot(page, kmap_prot)
OK, so it *was* just a bisect hazard - you return to original semantics
wrt preempt_disable()...
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-01 2:38 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-30 20:38 [PATCH V1 00/10] Remove duplicated kmap code ira.weiny
2020-04-30 20:38 ` [PATCH V1 01/10] arch/kmap: Remove BUG_ON() ira.weiny
2020-05-01 8:35 ` Christoph Hellwig
2020-04-30 20:38 ` [PATCH V1 02/10] arch/xtensa: Move kmap build bug out of the way ira.weiny
2020-05-01 8:36 ` Christoph Hellwig
2020-04-30 20:38 ` [PATCH V1 03/10] arch/kmap: Remove redundant arch specific kmaps ira.weiny
2020-05-01 8:37 ` Christoph Hellwig
2020-04-30 20:38 ` [PATCH V1 04/10] arch/kunmap: Remove duplicate kunmap implementations ira.weiny
2020-05-01 8:38 ` Christoph Hellwig
2020-04-30 20:38 ` [PATCH V1 05/10] arch/kmap_atomic: Consolidate duplicate code ira.weiny
2020-05-01 2:09 ` Al Viro
2020-05-01 8:39 ` Christoph Hellwig
2020-04-30 20:38 ` [PATCH V1 06/10] arch/kunmap_atomic: " ira.weiny
2020-05-01 8:39 ` Christoph Hellwig
2020-04-30 20:38 ` [PATCH V1 07/10] arch/kmap: Ensure kmap_prot visibility ira.weiny
2020-05-01 8:44 ` sparc-related comment, to " Christoph Hellwig
2020-05-01 15:35 ` Ira Weiny
2020-04-30 20:38 ` [PATCH V1 08/10] arch/kmap: Don't hard code kmap_prot values ira.weiny
2020-05-01 2:16 ` Al Viro
2020-05-01 8:47 ` Christoph Hellwig
2020-04-30 20:38 ` [PATCH V1 09/10] arch/kmap: Define kmap_atomic_prot() for all arch's ira.weiny
2020-05-01 2:37 ` Al Viro [this message]
2020-05-01 3:20 ` Al Viro
2020-05-03 3:11 ` Ira Weiny
2020-05-01 8:48 ` Christoph Hellwig
2020-04-30 20:38 ` [PATCH V1 10/10] drm: Remove drm specific kmap_atomic code ira.weiny
2020-05-01 7:23 ` Christian König
2020-05-01 8:49 ` Christoph Hellwig
2020-05-01 2:29 ` [PATCH V1 00/10] Remove duplicated kmap code Michael Ellerman
2020-05-01 8:54 ` Christoph Hellwig
2020-05-01 17:18 ` Ira Weiny
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501023734.GF23230@ZenIV.linux.org.uk \
--to=viro@zeniv$(echo .)linux.org.uk \
--cc=James.Bottomley@hansenpartnership$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bp@alien8$(echo .)de \
--cc=chris@zankel$(echo .)net \
--cc=christian.koenig@amd$(echo .)com \
--cc=dan.j.williams@intel$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=deller@gmx$(echo .)de \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=hpa@zytor$(echo .)com \
--cc=ira.weiny@intel$(echo .)com \
--cc=jcmvbkbc@gmail$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-csky@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-parisc@vger$(echo .)kernel.org \
--cc=linux-snps-arc@lists$(echo .)infradead.org \
--cc=linux-xtensa@linux-xtensa$(echo .)org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=luto@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=peterz@infradead$(echo .)org \
--cc=ray.huang@amd$(echo .)com \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox