From: Jonathan Cameron <jic23@kernel•org>
To: Krzysztof Kozlowski <krzk@kernel•org>
Cc: kstewart@linuxfoundation•org, linux-samsung-soc@vger•kernel.org,
lars@metafoo•de, linux-iio@vger•kernel.org, mpe@ellerman•id.au,
Jonathan Bakker <xc-racer2@live•ca>,
linux-kernel@vger•kernel.org, swboyd@chromium•org,
cw00.choi@samsung•com, kgene@kernel•org, pmeerw@pmeerw•net,
knaack.h@gmx•de, tglx@linutronix•de,
linux-arm-kernel@lists•infradead.org, m.szyprowski@samsung•com
Subject: Re: [PATCH] iio: adc: Add scaling support to exynos adc driver
Date: Sat, 16 May 2020 19:19:14 +0100 [thread overview]
Message-ID: <20200516191914.3b028794@archlinux> (raw)
In-Reply-To: <20200511074232.GA7134@kozik-lap>
On Mon, 11 May 2020 09:42:32 +0200
Krzysztof Kozlowski <krzk@kernel•org> wrote:
> On Sun, May 10, 2020 at 11:24:17AM +0100, Jonathan Cameron wrote:
> > On Fri, 8 May 2020 14:14:00 -0700
> > Jonathan Bakker <xc-racer2@live•ca> wrote:
> >
> > > Currently the driver only exposes the raw counts. As we
> > > have the regulator voltage and the maximum value (stored in
> > > the data mask), we can trivially produce a scaling fraction
> > > of voltage / max value.
> > >
> > > This assumes that the regulator voltage is in fact the max
> > > voltage, which appears to be the case for all mainline dts
> > > and cross referenced with the public Exynos4412 and S5PV210
> > > datasheets.
> > >
> > > Signed-off-by: Jonathan Bakker <xc-racer2@live•ca>
> >
> > Seems reasonable to me. I'd like an exynos Ack though before applying.
>
>
> It's correct, at least with ARMv7 Exynos datasheets
>
> The few ARMv8 Exynos chips are silent about the voltage levels. The
> Exynos 7 DTS board in mainline kernel does not have regulator but it
> looks clearly like mistake.
>
> I think they behave the same, so for Exynos:
> Reviewed-by: Krzysztof Kozlowski <krzk@kernel•org>
Applied to the togreg branch of iio.git and pushed out as testing
for the autobuilders to poke at it.
Thanks,
Jonathan
>
> Best regards,
> Krzysztof
>
> > thanks,
> >
> > Jonathan
> >
> >
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2020-05-16 18:19 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-08 21:14 [PATCH] iio: adc: Add scaling support to exynos adc driver Jonathan Bakker
2020-05-10 10:24 ` Jonathan Cameron
2020-05-11 7:42 ` Krzysztof Kozlowski
2020-05-16 18:19 ` Jonathan Cameron [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200516191914.3b028794@archlinux \
--to=jic23@kernel$(echo .)org \
--cc=cw00.choi@samsung$(echo .)com \
--cc=kgene@kernel$(echo .)org \
--cc=knaack.h@gmx$(echo .)de \
--cc=krzk@kernel$(echo .)org \
--cc=kstewart@linuxfoundation$(echo .)org \
--cc=lars@metafoo$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=m.szyprowski@samsung$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=pmeerw@pmeerw$(echo .)net \
--cc=swboyd@chromium$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=xc-racer2@live$(echo .)ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox