From: Catalin Marinas <catalin.marinas@arm•com>
To: Zhenyu Ye <yezhenyu2@huawei•com>
Cc: mark.rutland@arm•com, peterz@infradead•org, linux-mm@kvack•org,
guohanjun@huawei•com, will@kernel•org,
linux-arch@vger•kernel.org, yuzhao@google•com,
aneesh.kumar@linux•ibm.com, steven.price@arm•com, arm@kernel•org,
Dave.Martin@arm•com, arnd@arndb•de, suzuki.poulose@arm•com,
npiggin@gmail•com, zhangshaokun@hisilicon•com,
broonie@kernel•org, rostedt@goodmis•org,
prime.zeng@hisilicon•com, kuhn.chenqun@huawei•com,
tglx@linutronix•de, linux-arm-kernel@lists•infradead.org,
xiexiangyou@huawei•com, linux-kernel@vger•kernel.org,
maz@kernel•org, akpm@linux-foundation•org
Subject: Re: [PATCH v2 2/6] arm64: Add level-hinted TLB invalidation helper
Date: Fri, 22 May 2020 16:50:17 +0100 [thread overview]
Message-ID: <20200522155017.GG26492@gaia> (raw)
In-Reply-To: <20200423135656.2712-3-yezhenyu2@huawei.com>
On Thu, Apr 23, 2020 at 09:56:52PM +0800, Zhenyu Ye wrote:
> diff --git a/arch/arm64/include/asm/tlbflush.h b/arch/arm64/include/asm/tlbflush.h
> index bc3949064725..5f9f189bc6d2 100644
> --- a/arch/arm64/include/asm/tlbflush.h
> +++ b/arch/arm64/include/asm/tlbflush.h
> @@ -10,6 +10,7 @@
>
> #ifndef __ASSEMBLY__
>
> +#include <linux/bitfield.h>
> #include <linux/mm_types.h>
> #include <linux/sched.h>
> #include <asm/cputype.h>
> @@ -59,6 +60,35 @@
> __ta; \
> })
>
> +#define TLBI_TTL_MASK GENMASK_ULL(47, 44)
> +
> +#define __tlbi_level(op, addr, level) \
> + do { \
Nitpick: move "do {" on the same line as __tlbi_level() to reduce the
indentation levels of the whole block.
Reviewed-by: Catalin Marinas <catalin.marinas@arm•com>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-05-22 15:50 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-23 13:56 [PATCH v2 0/6] arm64: tlb: add support for TTL feature Zhenyu Ye
2020-04-23 13:56 ` [PATCH v2 1/6] arm64: Detect the ARMv8.4 " Zhenyu Ye
2020-05-22 15:50 ` Catalin Marinas
2020-04-23 13:56 ` [PATCH v2 2/6] arm64: Add level-hinted TLB invalidation helper Zhenyu Ye
2020-05-22 15:50 ` Catalin Marinas [this message]
2020-05-25 6:54 ` Zhenyu Ye
2020-04-23 13:56 ` [PATCH v2 3/6] arm64: Add tlbi_user_level " Zhenyu Ye
2020-05-22 15:49 ` Catalin Marinas
2020-05-25 6:57 ` Zhenyu Ye
2020-04-23 13:56 ` [PATCH v2 4/6] tlb: mmu_gather: add tlb_flush_*_range APIs Zhenyu Ye
2020-05-22 15:50 ` Catalin Marinas
2020-04-23 13:56 ` [PATCH v2 5/6] mm: tlb: Provide flush_*_tlb_range wrappers Zhenyu Ye
2020-05-22 15:42 ` Catalin Marinas
2020-05-25 7:19 ` Zhenyu Ye
2020-05-26 14:52 ` Catalin Marinas
2020-05-30 10:24 ` Zhenyu Ye
2020-06-01 11:56 ` Catalin Marinas
2020-06-01 13:36 ` Zhenyu Ye
2020-04-23 13:56 ` [PATCH v2 6/6] arm64: tlb: Set the TTL field in flush_tlb_range Zhenyu Ye
2020-05-26 14:56 ` Catalin Marinas
2020-05-11 12:41 ` [PATCH v2 0/6] arm64: tlb: add support for TTL feature Zhenyu Ye
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200522155017.GG26492@gaia \
--to=catalin.marinas@arm$(echo .)com \
--cc=Dave.Martin@arm$(echo .)com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=aneesh.kumar@linux$(echo .)ibm.com \
--cc=arm@kernel$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=broonie@kernel$(echo .)org \
--cc=guohanjun@huawei$(echo .)com \
--cc=kuhn.chenqun@huawei$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=maz@kernel$(echo .)org \
--cc=npiggin@gmail$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=prime.zeng@hisilicon$(echo .)com \
--cc=rostedt@goodmis$(echo .)org \
--cc=steven.price@arm$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=will@kernel$(echo .)org \
--cc=xiexiangyou@huawei$(echo .)com \
--cc=yezhenyu2@huawei$(echo .)com \
--cc=yuzhao@google$(echo .)com \
--cc=zhangshaokun@hisilicon$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox