public inbox for linux-arm-kernel@lists.infradead.org 
 help / color / mirror / Atom feed
From: Pavel Machek <pavel@ucw•cz>
To: Ondrej Jirman <megous@megous•com>
Cc: devicetree@vger•kernel.org, Samuel Holland <samuel@sholland•org>,
	David Airlie <airlied@linux•ie>,
	Linus Walleij <linus.walleij@linaro•org>,
	Bhushan Shah <bshah@kde•org>, Chen-Yu Tsai <wens@csie•org>,
	Maxime Ripard <mripard@kernel•org>,
	linux-kernel@vger•kernel.org, Martijn Braam <martijn@brixit•nl>,
	linux-sunxi@googlegroups•com, Rob Herring <robh+dt@kernel•org>,
	Thierry Reding <thierry.reding@gmail•com>,
	dri-devel@lists•freedesktop.org, Daniel Vetter <daniel@ffwll•ch>,
	Sam Ravnborg <sam@ravnborg•org>, Luca Weiss <luca@z3ntu•xyz>,
	linux-arm-kernel@lists•infradead.org,
	Icenowy Zheng <icenowy@aosc•io>
Subject: Re: [PATCH v3 4/5] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone
Date: Fri, 29 May 2020 18:27:28 +0200	[thread overview]
Message-ID: <20200529162728.GB3709@amd> (raw)
In-Reply-To: <20200513212451.1919013-5-megous@megous.com>


[-- Attachment #1.1: Type: text/plain, Size: 1265 bytes --]

Hi!

> PinePhone uses PWM backlight and a XBD599 LCD panel over DSI for
> display.
> 
> Backlight levels curve was optimized by Martijn Braam using a
> lux meter.

If it was possible to preserve lux values for individual settings in
the comment somewhere... that would be nice :-).

One day, it would be nice to have brightness settings in lux, so I
could easily set matching levels on multiple devices, for example...

Best regards,

								Pavel

> +
> +&backlight {
> +	power-supply = <&reg_ldo_io0>;
> +	/*
> +	 * PWM backlight circuit on this PinePhone revision was changed since
> +	 * 1.0, and the lowest PWM duty cycle that doesn't lead to backlight
> +	 * being off is around 20%. Duty cycle for the lowest brightness level
> +	 * also varries quite a bit between individual boards, so the lowest
> +	 * value here was chosen as a safe default.
> +	 */
> +	brightness-levels = <
> +		774  793  814  842
> +		882  935  1003 1088
> +		1192 1316 1462 1633
> +		1830 2054 2309 2596
> +		2916 3271 3664 4096>;
> +	num-interpolated-steps = <50>;
> +	default-brightness-level = <400>;

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

[-- Attachment #1.2: Digital signature --]
[-- Type: application/pgp-signature, Size: 181 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  reply	other threads:[~2020-05-29 16:27 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-13 21:24 [PATCH v3 0/5] Add support for PinePhone LCD panel Ondrej Jirman
2020-05-13 21:24 ` [PATCH v3 1/5] dt-bindings: vendor-prefixes: Add Xingbangda Ondrej Jirman
2020-05-28  2:40   ` Rob Herring
2020-05-13 21:24 ` [PATCH v3 2/5] dt-bindings: panel: Add binding for Xingbangda XBD599 panel Ondrej Jirman
2020-05-26 11:22   ` Linus Walleij
2020-05-28  2:41   ` Rob Herring
2020-05-13 21:24 ` [PATCH v3 3/5] drm: panel: Add Xingbangda XBD599 panel (ST7703 controller) Ondrej Jirman
2020-05-26 11:32   ` Linus Walleij
2020-06-17  2:00     ` [linux-sunxi] " Ondřej Jirman
2020-05-28  3:31   ` Samuel Holland
2020-05-13 21:24 ` [PATCH v3 4/5] arm64: dts: sun50i-a64-pinephone: Enable LCD support on PinePhone Ondrej Jirman
2020-05-29 16:27   ` Pavel Machek [this message]
2020-05-13 21:24 ` [PATCH v3 5/5] arm64: dts: sun50i-a64-pinephone: Add touchscreen support Ondrej Jirman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20200529162728.GB3709@amd \
    --to=pavel@ucw$(echo .)cz \
    --cc=airlied@linux$(echo .)ie \
    --cc=bshah@kde$(echo .)org \
    --cc=daniel@ffwll$(echo .)ch \
    --cc=devicetree@vger$(echo .)kernel.org \
    --cc=dri-devel@lists$(echo .)freedesktop.org \
    --cc=icenowy@aosc$(echo .)io \
    --cc=linus.walleij@linaro$(echo .)org \
    --cc=linux-arm-kernel@lists$(echo .)infradead.org \
    --cc=linux-kernel@vger$(echo .)kernel.org \
    --cc=linux-sunxi@googlegroups$(echo .)com \
    --cc=luca@z3ntu$(echo .)xyz \
    --cc=martijn@brixit$(echo .)nl \
    --cc=megous@megous$(echo .)com \
    --cc=mripard@kernel$(echo .)org \
    --cc=robh+dt@kernel$(echo .)org \
    --cc=sam@ravnborg$(echo .)org \
    --cc=samuel@sholland$(echo .)org \
    --cc=thierry.reding@gmail$(echo .)com \
    --cc=wens@csie$(echo .)org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox