From: Dave Martin <Dave.Martin@arm•com>
To: Mark Rutland <mark.rutland@arm•com>
Cc: hk92.kim@samsung•com, Catalin Marinas <catalin.marinas@arm•com>,
Bhupesh Sharma <bhsharma@redhat•com>,
yb.song@samsung•com, yj.yim@samsung•com,
Julien Grall <julien.grall@arm•com>,
Vincenzo Frascino <vincenzo.frascino@arm•com>,
Will Deacon <will@kernel•org>,
jinsoo37.kim@samsung•com, hyewon.ryu@samsung•com,
yhwan.joo@samsung•com, Anisse Astier <aastier@freebox•fr>,
Marc Zyngier <maz@kernel•org>,
dongww.kim@samsung•com, Allison Randal <allison@lohutok•net>,
jihun.kim@samsung•com, Kees Cook <keescook@chromium•org>,
Suzuki K Poulose <suzuki.poulose@arm•com>,
Wooki Min <wooki.min@samsung•com>,
Wooyeon Kim <wooy88.kim@samsung•com>,
junik.lee@samsung•com, sgun.bae@samsung•com,
Jeongtae Park <jtp.park@samsung•com>,
kgene.kim@samsung•com,
Kristina Martsenko <kristina.martsenko@arm•com>,
Thomas Gleixner <tglx@linutronix•de>,
Sanghoon Lee <shoon114.lee@samsung•com>,
linux-arm-kernel@lists•infradead.org,
Sudeep Holla <sudeep.holla@arm•com>,
Steve Capper <steve.capper@arm•com>,
hyeyeon5.shim@samsung•com, linux-kernel@vger•kernel.org,
James Morse <james.morse@arm•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
dh.han@samsung•com
Subject: Re: [PATCH] arm64: fpsimd: Added API to manage fpsimd state inside kernel
Date: Mon, 8 Jun 2020 11:34:00 +0100 [thread overview]
Message-ID: <20200608103340.GA31466@arm.com> (raw)
In-Reply-To: <20200605103705.GD85498@C02TD0UTHF1T.local>
On Fri, Jun 05, 2020 at 11:37:05AM +0100, Mark Rutland wrote:
> Hi Wooyeon,
>
> There are a *lot* of people Cc' here, many of whomo will find this
> irrelevant. Please try to keep the Cc list constrained to a reasonable
> number of interested parties.
>
> On Fri, Jun 05, 2020 at 04:30:52PM +0900, Wooyeon Kim wrote:
> > From: Wooki Min <wooki.min@samsung•com>
> >
> > This is an patch to use FPSIMD register in Kernel space.
> > It need to manage to use FPSIMD register without damaging it
> > of the user task.
> > Following items have been implemented and added.
>
> Please introduce the problem you are trying to solve in more detail. We
> already have kernel_neon_{begin,end}() for kernel-mode NEON; why is that
> not sufficient for your needs? Please answer this before considering
> other details.
>
> What do you want to use this for?
>
> >
> > 1. Using FPSIMD in ISR (in_interrupt)
> > It can used __efi_fpsimd_begin/__efi_fpsimd_end
> > which is already implemented.
> > Save fpsimd state before entering ISR,
> > and restore fpsimd state after ISR ends.
> > For use in external kernel module,
> > it is declared as EXPORT_SYMBOL.
>
> This patch adds no in-tree modular users of this, so per the usual
> conventions, NAK to EXPORT_SYMBOL().
Ack, this looks supicious. Can you explain why your usecase _requires_
FPSIMD in hardirq context?
For now, these functions are strictly for EFI use only and should never
be used by modules.
Cheers
---Dave
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-08 10:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200605073214epcas2p1576f3f90dbcefaad6180f2559ca5980d@epcas2p1.samsung.com>
2020-06-05 7:30 ` [PATCH] arm64: fpsimd: Added API to manage fpsimd state inside kernel Wooyeon Kim
2020-06-05 10:37 ` Mark Rutland
2020-06-08 10:34 ` Dave Martin [this message]
2020-06-11 9:17 ` ???
2020-06-11 12:47 ` Mark Rutland
2020-06-11 9:42 ` Wooyeon Kim
2020-06-11 14:11 ` Catalin Marinas
2020-06-15 10:30 ` Dave Martin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200608103340.GA31466@arm.com \
--to=dave.martin@arm$(echo .)com \
--cc=aastier@freebox$(echo .)fr \
--cc=allison@lohutok$(echo .)net \
--cc=bhsharma@redhat$(echo .)com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dh.han@samsung$(echo .)com \
--cc=dongww.kim@samsung$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hk92.kim@samsung$(echo .)com \
--cc=hyewon.ryu@samsung$(echo .)com \
--cc=hyeyeon5.shim@samsung$(echo .)com \
--cc=james.morse@arm$(echo .)com \
--cc=jihun.kim@samsung$(echo .)com \
--cc=jinsoo37.kim@samsung$(echo .)com \
--cc=jtp.park@samsung$(echo .)com \
--cc=julien.grall@arm$(echo .)com \
--cc=junik.lee@samsung$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kgene.kim@samsung$(echo .)com \
--cc=kristina.martsenko@arm$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=mark.rutland@arm$(echo .)com \
--cc=maz@kernel$(echo .)org \
--cc=sgun.bae@samsung$(echo .)com \
--cc=shoon114.lee@samsung$(echo .)com \
--cc=steve.capper@arm$(echo .)com \
--cc=sudeep.holla@arm$(echo .)com \
--cc=suzuki.poulose@arm$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=vincenzo.frascino@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=wooki.min@samsung$(echo .)com \
--cc=wooy88.kim@samsung$(echo .)com \
--cc=yb.song@samsung$(echo .)com \
--cc=yhwan.joo@samsung$(echo .)com \
--cc=yj.yim@samsung$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox