From: Kees Cook <keescook@chromium•org>
To: Alexander Popov <alex.popov@linux•com>
Cc: kernel-hardening@lists•openwall.com,
Catalin Marinas <catalin.marinas@arm•com>,
Masahiro Yamada <yamada.masahiro@socionext•com>,
Vincenzo Frascino <vincenzo.frascino@arm•com>,
Will Deacon <will@kernel•org>,
Naohiro Aota <naohiro.aota@wdc•com>,
Sven Schnelle <svens@stackframe•org>,
Masahiro Yamada <masahiroy@kernel•org>,
x86@kernel•org, Emese Revfy <re.emese@gmail•com>,
Iurii Zaikin <yzaikin@google•com>,
PaX Team <pageexec@freemail•hu>,
Laura Abbott <labbott@redhat•com>,
Mathias Krause <minipli@googlemail•com>,
linux-kbuild@vger•kernel.org,
Alexander Monakov <amonakov@ispras•ru>,
Michal Marek <michal.lkml@markovi•net>,
Thomas Gleixner <tglx@linutronix•de>,
Peter Collingbourne <pcc@google•com>,
linux-arm-kernel@lists•infradead.org, notify@kernel•org,
Florian Weimer <fweimer@redhat•com>,
gcc@gcc•gnu.org, Brad Spengler <spender@grsecurity•net>,
linux-kernel@vger•kernel.org,
Miguel Ojeda <miguel.ojeda.sandonis@gmail•com>,
Luis Chamberlain <mcgrof@kernel•org>,
Jessica Yu <jeyu@kernel•org>,
Andrew Morton <akpm@linux-foundation•org>,
Thiago Jung Bauermann <bauerman@linux•ibm.com>
Subject: Re: [PATCH 4/5] gcc-plugins/stackleak: Don't instrument itself
Date: Tue, 9 Jun 2020 11:48:07 -0700 [thread overview]
Message-ID: <202006091147.1B8E3ABE@keescook> (raw)
In-Reply-To: <20200604134957.505389-5-alex.popov@linux.com>
On Thu, Jun 04, 2020 at 04:49:56PM +0300, Alexander Popov wrote:
> There is no need to try instrumenting functions in kernel/stackleak.c.
> Otherwise that can cause issues if the cleanup pass of stackleak gcc plugin
> is disabled.
>
> Signed-off-by: Alexander Popov <alex.popov@linux•com>
Acked-by: Kees Cook <keescook@chromium•org>
--
Kees Cook
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-06-09 18:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-04 13:49 [PATCH 0/5] Improvements of the stackleak gcc plugin Alexander Popov
2020-06-04 13:49 ` [PATCH 1/5] gcc-plugins/stackleak: Exclude alloca() from the instrumentation logic Alexander Popov
2020-06-04 14:01 ` Jann Horn
2020-06-04 15:23 ` Alexander Popov
2020-06-09 18:39 ` Kees Cook
2020-06-10 15:24 ` Alexander Popov
2020-06-04 13:49 ` [PATCH 2/5] gcc-plugins/stackleak: Use asm instrumentation to avoid useless register saving Alexander Popov
2020-06-04 15:05 ` Miguel Ojeda
2020-06-09 18:46 ` Kees Cook
2020-06-10 15:47 ` Alexander Popov
2020-06-10 20:03 ` Kees Cook
2020-06-11 23:45 ` Alexander Popov
2020-06-04 13:49 ` [PATCH 3/5] gcc-plugins/stackleak: Add 'verbose' plugin parameter Alexander Popov
2020-06-09 18:47 ` Kees Cook
2020-06-10 15:52 ` Alexander Popov
2020-06-10 20:04 ` Kees Cook
2020-06-04 13:49 ` [PATCH 4/5] gcc-plugins/stackleak: Don't instrument itself Alexander Popov
2020-06-09 18:48 ` Kees Cook [this message]
2020-06-04 13:49 ` [PATCH 5/5] gcc-plugins/stackleak: Don't instrument vgettimeofday.c in arm64 VDSO Alexander Popov
2020-06-04 13:58 ` Will Deacon
2020-06-04 14:14 ` Jann Horn
2020-06-04 14:20 ` Alexander Popov
2020-06-04 14:25 ` Jann Horn
2020-06-04 14:44 ` Alexander Popov
2020-06-09 19:09 ` Kees Cook
2020-06-10 7:30 ` Will Deacon
2020-06-10 15:18 ` Alexander Popov
2020-06-04 21:39 ` [PATCH 0/5] Improvements of the stackleak gcc plugin Kees Cook
2020-06-09 19:15 ` Kees Cook
2020-06-10 15:14 ` Alexander Popov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202006091147.1B8E3ABE@keescook \
--to=keescook@chromium$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=alex.popov@linux$(echo .)com \
--cc=amonakov@ispras$(echo .)ru \
--cc=bauerman@linux$(echo .)ibm.com \
--cc=catalin.marinas@arm$(echo .)com \
--cc=fweimer@redhat$(echo .)com \
--cc=gcc@gcc$(echo .)gnu.org \
--cc=jeyu@kernel$(echo .)org \
--cc=kernel-hardening@lists$(echo .)openwall.com \
--cc=labbott@redhat$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kbuild@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=masahiroy@kernel$(echo .)org \
--cc=mcgrof@kernel$(echo .)org \
--cc=michal.lkml@markovi$(echo .)net \
--cc=miguel.ojeda.sandonis@gmail$(echo .)com \
--cc=minipli@googlemail$(echo .)com \
--cc=naohiro.aota@wdc$(echo .)com \
--cc=notify@kernel$(echo .)org \
--cc=pageexec@freemail$(echo .)hu \
--cc=pcc@google$(echo .)com \
--cc=re.emese@gmail$(echo .)com \
--cc=spender@grsecurity$(echo .)net \
--cc=svens@stackframe$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=vincenzo.frascino@arm$(echo .)com \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=yamada.masahiro@socionext$(echo .)com \
--cc=yzaikin@google$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox