Subject: Re: [PATCH] Changes blacklist to blocklist in ecode.c file

From: Russell King - ARM Linux admin <[email-masked]>
Date: Tue, 14 Jul 2020 15:20:41 +0100

On Tue, Jul 14, 2020 at 11:35:57PM +0930, [email-masked] wrote:
> From: Paul Schulz <[email-masked]>
> 
> ---
>  arch/arm/mach-rpc/ecard.c | 22 +++++++++++-----------
>  1 file changed, 11 insertions(+), 11 deletions(-)
> 
> diff --git a/arch/arm/mach-rpc/ecard.c b/arch/arm/mach-rpc/ecard.c
> index 75cfad2cb143..b3d70389ac9a 100644
> --- a/arch/arm/mach-rpc/ecard.c
> +++ b/arch/arm/mach-rpc/ecard.c
> @@ -63,7 +63,7 @@ struct ecard_request {
>  	struct completion *complete;
>  };
>  
> -struct expcard_blacklist {
> +struct expcard_blocklist {

I don't like this change - this is not about "blocking" anything, so
this change results in nonsense.

expcard_quirklist would be better.

>  	unsigned short	 manufacturer;
>  	unsigned short	 product;
>  	const char	*type;
> @@ -79,7 +79,7 @@ static void atomwide_3p_quirk(ecard_t *ec);
>  /* List of descriptions of cards which don't have an extended
>   * identification, or chunk directories containing a description.
>   */
> -static struct expcard_blacklist __initdata blacklist[] = {
> +static struct expcard_blocklist __initdata blocklist[] = {

Reading the comment above illustrates my point above; this list is
not about blocking anything, so calling it a "block" list is just
rediculous.

-- 
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel