Subject: Re: [PATCH 12/14] spi: spi-at91-usart: Make use of the defined 'struct of_device_id'

From: Alexandre Belloni <[email-masked]>
Date: Wed, 15 Jul 2020 23:24:43 +0200

Hi Lee,

On 15/07/2020 16:06:30+0100, Lee Jones wrote:
> It's there so why not use it.
> 

Is that the correct resolution? Isn't the proper thing to do simply
removing at91_usart_spi_dt_ids as the only way it will ever be probed is
through drivers/mfd/at91-usart.c and I would think matching the driver
name is enough.

> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/spi/spi-at91-usart.c:684:34: warning: ‘at91_usart_spi_dt_ids’ defined but not used [-Wunused-const-variable=]
>  684 | static const struct of_device_id at91_usart_spi_dt_ids[] = {
>  | ^~~~~~~~~~~~~~~~~~~~~
> 
> Cc: Radu Pirea <[email-masked]>
> Cc: Nicolas Ferre <[email-masked]>
> Cc: Alexandre Belloni <[email-masked]>
> Cc: Ludovic Desroches <[email-masked]>
> Signed-off-by: Lee Jones <[email-masked]>
> ---
>  drivers/spi/spi-at91-usart.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/spi-at91-usart.c b/drivers/spi/spi-at91-usart.c
> index 88033422a42ae..d47a20be43ccd 100644
> --- a/drivers/spi/spi-at91-usart.c
> +++ b/drivers/spi/spi-at91-usart.c
> @@ -692,6 +692,7 @@ static struct platform_driver at91_usart_spi_driver = {
>  	.driver = {
>  		.name = "at91_usart_spi",
>  		.pm = &at91_usart_spi_pm_ops,
> +		.of_match_table = at91_usart_spi_dt_ids,
>  	},
>  	.probe = at91_usart_spi_probe,
>  	.remove = at91_usart_spi_remove,
> -- 
> 2.25.1
> 

-- 
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel