Subject: Re: [PATCH 08/30] iio: resolver: ad2s1200: Change ordering of compiler attribute macro

From: Jonathan Cameron <[email-masked]>
Date: Sat, 18 Jul 2020 16:41:06 +0100

On Fri, 17 Jul 2020 17:55:16 +0100
Lee Jones <[email-masked]> wrote:

> Kerneldoc gets confused if the variable does not follow the
> type/attribute definitions.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/iio/resolver/ad2s1200.c:44: warning: Function parameter or member '____cacheline_aligned' not described in 'ad2s1200_state'
> 
> Cc: Michael Hennerich <[email-masked]>
> Cc: David Veenstra <[email-masked]>
> Cc: Graff Yang <[email-masked]>
> Signed-off-by: Lee Jones <[email-masked]>
Holding this for now whilst we discuss whether to just fix it in
the kernel-doc script.

J
> ---
>  drivers/iio/resolver/ad2s1200.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/resolver/ad2s1200.c b/drivers/iio/resolver/ad2s1200.c
> index a391f46ee06b7..29cfd57eff9e7 100644
> --- a/drivers/iio/resolver/ad2s1200.c
> +++ b/drivers/iio/resolver/ad2s1200.c
> @@ -40,7 +40,7 @@ struct ad2s1200_state {
>  	struct spi_device *sdev;
>  	struct gpio_desc *sample;
>  	struct gpio_desc *rdvel;
> -	__be16 rx ____cacheline_aligned;
> +	__be16 ____cacheline_aligned rx;
>  };
>  
>  static int ad2s1200_read_raw(struct iio_dev *indio_dev,

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel