Subject: Re: [PATCH 22/30] iio: adc: mcp320x: Change ordering of compiler attribute macro

From: Jonathan Cameron <[email-masked]>
Date: Sat, 18 Jul 2020 17:00:33 +0100

On Fri, 17 Jul 2020 17:55:30 +0100
Lee Jones <[email-masked]> wrote:

> Kerneldoc gets confused if the variable does not follow th
> type/attribute definitions.
> 
> Fixes the following W=1 kernel build warning(s):
> 
>  drivers/iio/adc/mcp320x.c:96: warning: Function parameter or member '____cacheline_aligned' not described in 'mcp320x'
> 
> Cc: Oskar Andero <[email-masked]>
> Cc: Bendorff Jensen <[email-masked]>
> Cc: Soren Andersen <[email-masked]>
> Signed-off-by: Lee Jones <[email-masked]>
Holding this one whilst we discuss the right fix for this sort of issue.

J
> ---
>  drivers/iio/adc/mcp320x.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/iio/adc/mcp320x.c b/drivers/iio/adc/mcp320x.c
> index 2c0eb5de110ca..191a8f644ffe7 100644
> --- a/drivers/iio/adc/mcp320x.c
> +++ b/drivers/iio/adc/mcp320x.c
> @@ -91,7 +91,7 @@ struct mcp320x {
>  	struct mutex lock;
>  	const struct mcp320x_chip_info *chip_info;
>  
> -	u8 tx_buf ____cacheline_aligned;
> +	u8 ____cacheline_aligned tx_buf;
>  	u8 rx_buf[4];
>  };
>  

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel