Subject: Re: [PATCH v2 16/17] drivers/firmware/sdei: Retrieve event signaled property on registration

From: Jonathan Cameron <[email-masked]>
Date: Thu, 23 Jul 2020 16:24:23 +0100

On Wed, 22 Jul 2020 19:57:39 +1000
Gavin Shan <[email-masked]> wrote:

> This retrieves the event signaled property when it's created for the
> first time. The property will be needed when SDEI virtualization is
> supported.
> 
> Signed-off-by: Gavin Shan <[email-masked]>

These last two patches are probably fine but hard to tell without a user.

Jonathan

> ---
>  drivers/firmware/arm_sdei.c | 6 ++++++
>  include/linux/arm_sdei.h    | 1 +
>  2 files changed, 7 insertions(+)
> 
> diff --git a/drivers/firmware/arm_sdei.c b/drivers/firmware/arm_sdei.c
> index cf10fec57f2a..7518d3febf53 100644
> --- a/drivers/firmware/arm_sdei.c
> +++ b/drivers/firmware/arm_sdei.c
> @@ -204,6 +204,12 @@ static struct sdei_event *sdei_event_create(u32 event_num,
>  		goto fail;
>  	event->type = result;
>  
> +	err = sdei_api_event_get_info(event_num, SDEI_EVENT_INFO_EV_SIGNALED,
> +				      &result);
> +	if (err)
> +		goto fail;
> +	event->signaled = result;
> +
>  	if (event->type == SDEI_EVENT_TYPE_SHARED) {
>  		reg = kzalloc(sizeof(*reg), GFP_KERNEL);
>  		if (!reg) {
> diff --git a/include/linux/arm_sdei.h b/include/linux/arm_sdei.h
> index 11af6410dd52..7f3ed7e4b680 100644
> --- a/include/linux/arm_sdei.h
> +++ b/include/linux/arm_sdei.h
> @@ -51,6 +51,7 @@ struct sdei_event {
>  	u32			event_num;
>  	u8			type;
>  	u8			priority;
> +	u8			signaled;
>  
>  	/* This pointer is handed to firmware as the event argument. */
>  	union {

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel