Subject: Re: [PATCH v7 05/25] coresight: export global symbols

From: Tingwei Zhang <[email-masked]>
Date: Thu, 6 Aug 2020 09:43:47 +0800

On Wed, Aug 05, 2020 at 07:13:43PM +0800, Suzuki K Poulose wrote:
> On 08/05/2020 03:54 AM, Tingwei Zhang wrote:
> >From: Mian Yousaf Kaukab <[email-masked]>
> >
> >Export symbols used among coresight modules.
> >
> >Signed-off-by: Mian Yousaf Kaukab <[email-masked]>
> >Signed-off-by: Tingwei Zhang <[email-masked]>
> >Tested-by: Mike Leach <[email-masked]>
> >---
> >  drivers/hwtracing/coresight/coresight-etm-perf.c | 1 +
> >  drivers/hwtracing/coresight/coresight-sysfs.c    | 2 ++
> >  drivers/hwtracing/coresight/coresight-tmc-etr.c  | 6 ++++++
> >  drivers/hwtracing/coresight/coresight.c          | 8 ++++++++
> >  4 files changed, 17 insertions(+)
> >
> 
> ...
> 
> >
> >  struct bus_type coresight_bustype = {
> >  	.name	= "coresight",
> >@@ -1553,6 +1560,7 @@ bool coresight_loses_context_with_cpu(struct device
> >*dev)
> >  	return fwnode_property_present(dev_fwnode(dev),
> >  				       "arm,coresight-loses-context-with-cpu");
> >  }
> >+EXPORT_SYMBOL_GPL(coresight_loses_context_with_cpu);
> 
> minor nit: This function is a good candidate for moving to the header
> file as a static inline, rather than being exported.
>
That's a good point.  I'll move it. 
> Either ways,
> 
> Reviewed-by: Suzuki K Poulose <[email-masked]>
> 
> 
> 

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel