From: Vaibhav Gupta <vaibhavgupta40@gmail•com>
To: Sam Ravnborg <sam@ravnborg•org>
Cc: linux-fbdev@vger•kernel.org, Antonino Daplas <adaplas@gmail•com>,
Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung•com>,
Vaibhav Gupta <vaibhav.varodek@gmail•com>,
Shuah Khan <skhan@linuxfoundation•org>,
Russell King <linux@armlinux•org.uk>,
dri-devel@lists•freedesktop.org, linux-kernel@vger•kernel.org,
Bjorn Helgaas <bjorn@helgaas•com>,
Bjorn Helgaas <helgaas@kernel•org>,
linux-arm-kernel@lists•infradead.org,
Andres Salomon <dilinger@queued•net>,
Bjorn Helgaas <bhelgaas@google•com>,
Paul Mackerras <paulus@samba•org>,
linux-kernel-mentees@lists•linuxfoundation.org,
linux-geode@lists•infradead.org
Subject: Re: [PATCH v1 01/12] fbdev: gxfb: use generic power management
Date: Mon, 10 Aug 2020 15:14:13 +0530 [thread overview]
Message-ID: <20200810094413.GA7579@gmail.com> (raw)
In-Reply-To: <20200810093948.GB6615@gmail.com>
> > > -static int gxfb_suspend(struct pci_dev *pdev, pm_message_t state)
> > > +static int __maybe_unused gxfb_suspend(struct device *dev)
> > > {
> > > - struct fb_info *info = pci_get_drvdata(pdev);
> > > + struct fb_info *info = dev_get_drvdata(dev);
> > I do not see any dev_set_drvdata() so I guess we get a NULL pointer
> > here which is not intended.
> > Adding a dev_set_data() to gxfb_probe() would do the trick.
> >
> gxfb_probe() invokes pci_set_drvdata(pdev, info) which in turn calls
> dev_set_drvdata(&pdev->dev, data). Adding dev_get_drvdata() will be redundant.
>
s/dev_get_drvdata/dev_set_drvdata
Thanks
Vaibhav Gupta
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-10 9:47 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-05 18:07 [PATCH v1 00/12] video: fbdev: use generic power management Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 01/12] fbdev: gxfb: " Vaibhav Gupta
2020-08-05 20:19 ` Bjorn Helgaas
2020-08-06 5:59 ` Vaibhav Gupta
2020-08-08 11:17 ` Sam Ravnborg
2020-08-10 9:39 ` Vaibhav Gupta
2020-08-10 9:44 ` Vaibhav Gupta [this message]
2020-08-10 16:54 ` Sam Ravnborg
2020-08-10 17:58 ` Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 00/12] video: fbdev: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 01/12] fbdev: gxfb: " Vaibhav Gupta
2020-08-16 20:16 ` Sam Ravnborg
2020-08-17 7:45 ` Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 02/12] fbdev: lxfb: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 03/12] fbdev: via-core: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 04/12] fbdev: aty: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 05/12] fbdev: aty128fb: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 06/12] fbdev: nvidia: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 07/12] fbdev: savagefb: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 08/12] fbdev: cyber2000fb: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 09/12] fbdev: i740fb: " Vaibhav Gupta
2020-08-16 20:24 ` Sam Ravnborg
2020-08-17 7:46 ` Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 10/12] fbdev: vt8623fb: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 11/12] fbdev: s3fb: " Vaibhav Gupta
2020-08-10 18:57 ` [PATCH v2 12/12] fbdev: arkfb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 02/12] fbdev: lxfb: " Vaibhav Gupta
2020-08-08 11:19 ` Sam Ravnborg
2020-08-05 18:07 ` [PATCH v1 03/12] fbdev: via-core: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 04/12] fbdev: aty: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 05/12] fbdev: aty128fb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 06/12] fbdev: nvidia: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 07/12] fbdev: savagefb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 08/12] fbdev: cyber2000fb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 09/12] fbdev: i740fb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 10/12] fbdev: vt8623fb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 11/12] fbdev: s3fb: " Vaibhav Gupta
2020-08-05 18:07 ` [PATCH v1 12/12] fbdev: arkfb: " Vaibhav Gupta
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200810094413.GA7579@gmail.com \
--to=vaibhavgupta40@gmail$(echo .)com \
--cc=adaplas@gmail$(echo .)com \
--cc=b.zolnierkie@samsung$(echo .)com \
--cc=bhelgaas@google$(echo .)com \
--cc=bjorn@helgaas$(echo .)com \
--cc=dilinger@queued$(echo .)net \
--cc=dri-devel@lists$(echo .)freedesktop.org \
--cc=helgaas@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-fbdev@vger$(echo .)kernel.org \
--cc=linux-geode@lists$(echo .)infradead.org \
--cc=linux-kernel-mentees@lists$(echo .)linuxfoundation.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=paulus@samba$(echo .)org \
--cc=sam@ravnborg$(echo .)org \
--cc=skhan@linuxfoundation$(echo .)org \
--cc=vaibhav.varodek@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox