[PATCH v3 14/17] x86/setup: simplify reserve_crashkernel()

From: Mike Rapoport <rppt@kernel•org>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: Thomas Gleixner <tglx@linutronix•de>,
	Emil Renner Berthing <kernel@esmil•dk>,
	linux-sh@vger•kernel.org, Peter Zijlstra <peterz@infradead•org>,
	Benjamin Herrenschmidt <benh@kernel•crashing.org>,
	Dave Hansen <dave.hansen@linux•intel.com>,
	linux-mips@vger•kernel.org, Max Filippov <jcmvbkbc@gmail•com>,
	Paul Mackerras <paulus@samba•org>,
	sparclinux@vger•kernel.org, linux-riscv@lists•infradead.org,
	Will Deacon <will@kernel•org>, Christoph Hellwig <hch@lst•de>,
	Marek Szyprowski <m.szyprowski@samsung•com>,
	linux-arch@vger•kernel.org, linux-s390@vger•kernel.org,
	linux-c6x-dev@linux-c6x•org, Baoquan He <bhe@redhat•com>,
	Michael Ellerman <mpe@ellerman•id.au>,
	x86@kernel•org, Russell King <linux@armlinux•org.uk>,
	Mike Rapoport <rppt@linux•ibm.com>,
	clang-built-linux@googlegroups•com,
	Ingo Molnar <mingo@redhat•com>,
	linux-arm-kernel@lists•infradead.org,
	Catalin Marinas <catalin.marinas@arm•com>,
	uclinux-h8-devel@lists•sourceforge.jp,
	linux-xtensa@linux-xtensa•org, openrisc@lists•librecores.org,
	Borislav Petkov <bp@alien8•de>, Andy Lutomirski <luto@kernel•org>,
	Paul Walmsley <paul.walmsley@sifive•com>,
	Stafford Horne <shorne@gmail•com>,
	Hari Bathini <hbathini@linux•ibm.com>,
	Daniel Axtens <dja@axtens•net>, Michal Simek <monstr@monstr•eu>,
	Yoshinori Sato <ysato@users•sourceforge.jp>,
	linux-mm@kvack•org, linux-kernel@vger•kernel.org,
	iommu@lists•linux-foundation.org, Ingo Molnar <mingo@kernel•org>,
	Palmer Dabbelt <palmer@dabbelt•com>,
	linuxppc-dev@lists•ozlabs.org, Mike Rapoport <rppt@kernel•org>
Subject: [PATCH v3 14/17] x86/setup: simplify reserve_crashkernel()
Date: Tue, 18 Aug 2020 18:16:31 +0300	[thread overview]
Message-ID: <20200818151634.14343-15-rppt@kernel.org> (raw)
In-Reply-To: <20200818151634.14343-1-rppt@kernel.org>

From: Mike Rapoport <rppt@linux•ibm.com>

* Replace magic numbers with defines
* Replace memblock_find_in_range() + memblock_reserve() with
  memblock_phys_alloc_range()
* Stop checking for low memory size in reserve_crashkernel_low(). The
  allocation from limited range will anyway fail if there is no enough
  memory, so there is no need for extra traversal of memblock.memory

Signed-off-by: Mike Rapoport <rppt@linux•ibm.com>
Acked-by: Ingo Molnar <mingo@kernel•org>
Reviewed-by: Baoquan He <bhe@redhat•com>
---
 arch/x86/kernel/setup.c | 40 ++++++++++++++--------------------------
 1 file changed, 14 insertions(+), 26 deletions(-)

diff --git a/arch/x86/kernel/setup.c b/arch/x86/kernel/setup.c
index 2cac39ade2e3..52e83ba607b3 100644
--- a/arch/x86/kernel/setup.c
+++ b/arch/x86/kernel/setup.c
@@ -420,13 +420,13 @@ static int __init reserve_crashkernel_low(void)
 {
 #ifdef CONFIG_X86_64
 	unsigned long long base, low_base = 0, low_size = 0;
-	unsigned long total_low_mem;
+	unsigned long low_mem_limit;
 	int ret;
 
-	total_low_mem = memblock_mem_size(1UL << (32 - PAGE_SHIFT));
+	low_mem_limit = min(memblock_phys_mem_size(), CRASH_ADDR_LOW_MAX);
 
 	/* crashkernel=Y,low */
-	ret = parse_crashkernel_low(boot_command_line, total_low_mem, &low_size, &base);
+	ret = parse_crashkernel_low(boot_command_line, low_mem_limit, &low_size, &base);
 	if (ret) {
 		/*
 		 * two parts from kernel/dma/swiotlb.c:
@@ -444,23 +444,17 @@ static int __init reserve_crashkernel_low(void)
 			return 0;
 	}
 
-	low_base = memblock_find_in_range(0, 1ULL << 32, low_size, CRASH_ALIGN);
+	low_base = memblock_phys_alloc_range(low_size, CRASH_ALIGN, 0, CRASH_ADDR_LOW_MAX);
 	if (!low_base) {
 		pr_err("Cannot reserve %ldMB crashkernel low memory, please try smaller size.\n",
 		       (unsigned long)(low_size >> 20));
 		return -ENOMEM;
 	}
 
-	ret = memblock_reserve(low_base, low_size);
-	if (ret) {
-		pr_err("%s: Error reserving crashkernel low memblock.\n", __func__);
-		return ret;
-	}
-
-	pr_info("Reserving %ldMB of low memory at %ldMB for crashkernel (System low RAM: %ldMB)\n",
+	pr_info("Reserving %ldMB of low memory at %ldMB for crashkernel (low RAM limit: %ldMB)\n",
 		(unsigned long)(low_size >> 20),
 		(unsigned long)(low_base >> 20),
-		(unsigned long)(total_low_mem >> 20));
+		(unsigned long)(low_mem_limit >> 20));
 
 	crashk_low_res.start = low_base;
 	crashk_low_res.end   = low_base + low_size - 1;
@@ -504,13 +498,13 @@ static void __init reserve_crashkernel(void)
 		 * unless "crashkernel=size[KMG],high" is specified.
 		 */
 		if (!high)
-			crash_base = memblock_find_in_range(CRASH_ALIGN,
-						CRASH_ADDR_LOW_MAX,
-						crash_size, CRASH_ALIGN);
+			crash_base = memblock_phys_alloc_range(crash_size,
+						CRASH_ALIGN, CRASH_ALIGN,
+						CRASH_ADDR_LOW_MAX);
 		if (!crash_base)
-			crash_base = memblock_find_in_range(CRASH_ALIGN,
-						CRASH_ADDR_HIGH_MAX,
-						crash_size, CRASH_ALIGN);
+			crash_base = memblock_phys_alloc_range(crash_size,
+						CRASH_ALIGN, CRASH_ALIGN,
+						CRASH_ADDR_HIGH_MAX);
 		if (!crash_base) {
 			pr_info("crashkernel reservation failed - No suitable area found.\n");
 			return;
@@ -518,19 +512,13 @@ static void __init reserve_crashkernel(void)
 	} else {
 		unsigned long long start;
 
-		start = memblock_find_in_range(crash_base,
-					       crash_base + crash_size,
-					       crash_size, 1 << 20);
+		start = memblock_phys_alloc_range(crash_size, SZ_1M, crash_base,
+						  crash_base + crash_size);
 		if (start != crash_base) {
 			pr_info("crashkernel reservation failed - memory is in use.\n");
 			return;
 		}
 	}
-	ret = memblock_reserve(crash_base, crash_size);
-	if (ret) {
-		pr_err("%s: Error reserving crashkernel memblock.\n", __func__);
-		return;
-	}
 
 	if (crash_base >= (1ULL << 32) && reserve_crashkernel_low()) {
 		memblock_free(crash_base, crash_size);
-- 
2.26.2


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
