From: Tony Lindgren <tony@atomide•com>
To: Adam Ford <aford173@gmail•com>
Cc: Amit Kucheria <amitk@kernel•org>,
linux-kernel@vger•kernel.org, linux-pm@vger•kernel.org,
Keerthy <j-keerthy@ti•com>,
Daniel Lezcano <daniel.lezcano@linaro•org>,
aford@beaconembedded•com, Russell King <linux@armlinux•org.uk>,
Eduardo Valentin <edubezval@gmail•com>,
Zhang Rui <rui.zhang@intel•com>,
linux-omap@vger•kernel.org, linux-arm-kernel@lists•infradead.org
Subject: Re: [PATCH 1/2] thermal: ti-soc-thermal: Enable addition power management
Date: Wed, 19 Aug 2020 07:59:14 +0300 [thread overview]
Message-ID: <20200819045914.GS2994@atomide.com> (raw)
In-Reply-To: <20200818154633.5421-1-aford173@gmail.com>
* Adam Ford <aford173@gmail•com> [200818 15:46]:
> @@ -1153,6 +1166,38 @@ static int ti_bandgap_suspend(struct device *dev)
> return err;
> }
>
> +static int bandgap_omap_cpu_notifier(struct notifier_block *nb,
> + unsigned long cmd, void *v)
> +{
> + struct ti_bandgap *bgp;
> +
> + bgp = container_of(nb, struct ti_bandgap, nb);
> +
> + spin_lock(&bgp->lock);
> + switch (cmd) {
> + case CPU_CLUSTER_PM_ENTER:
> + if (bgp->is_suspended)
> + break;
> + ti_bandgap_save_ctxt(bgp);
> + ti_bandgap_power(bgp, false);
> + if (TI_BANDGAP_HAS(bgp, CLK_CTRL))
> + clk_disable(bgp->fclock);
> + break;
> + case CPU_CLUSTER_PM_ENTER_FAILED:
> + case CPU_CLUSTER_PM_EXIT:
> + if (bgp->is_suspended)
> + break;
> + if (TI_BANDGAP_HAS(bgp, CLK_CTRL))
> + clk_enable(bgp->fclock);
> + ti_bandgap_power(bgp, true);
> + ti_bandgap_restore_ctxt(bgp);
> + break;
> + }
> + spin_unlock(&bgp->lock);
> +
> + return NOTIFY_OK;
> +}
Hmm to me it looks like is_suspended is not used right now?
I guess you want to set it in ti_bandgap_suspend() and clear
it in ti_bandgap_resume()?
Otherwise looks good to me, I can't test the power consumption
right now though so you may want to check it to make sure
device still hits off mode during idle.
Regards,
Tony
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-19 5:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 15:46 [PATCH 1/2] thermal: ti-soc-thermal: Enable addition power management Adam Ford
2020-08-18 15:46 ` [PATCH 2/2] ARM: omap2plus_defconfig: Enable OMAP3_THERMAL Adam Ford
2020-08-19 4:59 ` Tony Lindgren [this message]
2020-08-19 12:21 ` [PATCH 1/2] thermal: ti-soc-thermal: Enable addition power management Adam Ford
2020-08-19 12:54 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2020-09-11 12:31 Adam Ford
2020-10-08 20:59 ` Adam Ford
2020-10-08 23:23 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200819045914.GS2994@atomide.com \
--to=tony@atomide$(echo .)com \
--cc=aford173@gmail$(echo .)com \
--cc=aford@beaconembedded$(echo .)com \
--cc=amitk@kernel$(echo .)org \
--cc=daniel.lezcano@linaro$(echo .)org \
--cc=edubezval@gmail$(echo .)com \
--cc=j-keerthy@ti$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-omap@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux@armlinux$(echo .)org.uk \
--cc=rui.zhang@intel$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox