From: Krzysztof Kozlowski <krzk@kernel•org>
To: "Thierry Reding" <thierry.reding@gmail•com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>,
"Lee Jones" <lee.jones@linaro•org>,
"Nicolas Saenz Julienne" <nsaenzjulienne@suse•de>,
"Florian Fainelli" <f.fainelli@gmail•com>,
"Ray Jui" <rjui@broadcom•com>,
"Scott Branden" <sbranden@broadcom•com>,
bcm-kernel-feedback-list@broadcom•com,
"Paul Cercueil" <paul@crapouillou•net>,
"Heiko Stuebner" <heiko@sntech•de>,
"Palmer Dabbelt" <palmer@dabbelt•com>,
"Paul Walmsley" <paul.walmsley@sifive•com>,
"Orson Zhai" <orsonzhai@gmail•com>,
"Baolin Wang" <baolin.wang7@gmail•com>,
"Chunyan Zhang" <zhang.lyra@gmail•com>,
"Maxime Ripard" <mripard@kernel•org>,
"Chen-Yu Tsai" <wens@csie•org>,
linux-pwm@vger•kernel.org, linux-rpi-kernel@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
linux-kernel@vger•kernel.org, linux-rockchip@lists•infradead.org,
linux-riscv@lists•infradead.org
Cc: Krzysztof Kozlowski <krzk@kernel•org>
Subject: [PATCH 6/6] pwm: sun4i: Simplify with dev_err_probe()
Date: Wed, 26 Aug 2020 16:47:47 +0200 [thread overview]
Message-ID: <20200826144747.9436-6-krzk@kernel.org> (raw)
In-Reply-To: <20200826144747.9436-1-krzk@kernel.org>
Common pattern of handling deferred probe can be simplified with
dev_err_probe(). Less code and also it prints the error value.
Signed-off-by: Krzysztof Kozlowski <krzk@kernel•org>
---
drivers/pwm/pwm-sun4i.c | 36 ++++++++++++------------------------
1 file changed, 12 insertions(+), 24 deletions(-)
diff --git a/drivers/pwm/pwm-sun4i.c b/drivers/pwm/pwm-sun4i.c
index 961c59c99bb3..38a4c5c1317b 100644
--- a/drivers/pwm/pwm-sun4i.c
+++ b/drivers/pwm/pwm-sun4i.c
@@ -423,38 +423,26 @@ static int sun4i_pwm_probe(struct platform_device *pdev)
* back to the first clock of the PWM.
*/
pwm->clk = devm_clk_get_optional(&pdev->dev, "mod");
- if (IS_ERR(pwm->clk)) {
- if (PTR_ERR(pwm->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "get mod clock failed %pe\n",
- pwm->clk);
- return PTR_ERR(pwm->clk);
- }
+ if (IS_ERR(pwm->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(pwm->clk),
+ "get mod clock failed\n");
if (!pwm->clk) {
pwm->clk = devm_clk_get(&pdev->dev, NULL);
- if (IS_ERR(pwm->clk)) {
- if (PTR_ERR(pwm->clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "get unnamed clock failed %pe\n",
- pwm->clk);
- return PTR_ERR(pwm->clk);
- }
+ if (IS_ERR(pwm->clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(pwm->clk),
+ "get unnamed clock failed\n");
}
pwm->bus_clk = devm_clk_get_optional(&pdev->dev, "bus");
- if (IS_ERR(pwm->bus_clk)) {
- if (PTR_ERR(pwm->bus_clk) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "get bus clock failed %pe\n",
- pwm->bus_clk);
- return PTR_ERR(pwm->bus_clk);
- }
+ if (IS_ERR(pwm->bus_clk))
+ return dev_err_probe(&pdev->dev, PTR_ERR(pwm->bus_clk),
+ "get bus clock failed\n");
pwm->rst = devm_reset_control_get_optional_shared(&pdev->dev, NULL);
- if (IS_ERR(pwm->rst)) {
- if (PTR_ERR(pwm->rst) != -EPROBE_DEFER)
- dev_err(&pdev->dev, "get reset failed %pe\n",
- pwm->rst);
- return PTR_ERR(pwm->rst);
- }
+ if (IS_ERR(pwm->rst))
+ return dev_err_probe(&pdev->dev, PTR_ERR(pwm->rst),
+ "get reset failed\n");
/* Deassert reset */
ret = reset_control_deassert(pwm->rst);
--
2.17.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-08-26 14:50 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-26 14:47 [PATCH 1/6] pwm: bcm2835: Simplify with dev_err_probe() Krzysztof Kozlowski
2020-08-26 14:47 ` [PATCH 2/6] pwm: jz4740: " Krzysztof Kozlowski
2020-09-02 7:12 ` Uwe Kleine-König
2020-08-26 14:47 ` [PATCH 3/6] pwm: rockchip: " Krzysztof Kozlowski
2020-09-02 7:13 ` Uwe Kleine-König
2020-08-26 14:47 ` [PATCH 4/6] pwm: sifive: " Krzysztof Kozlowski
2020-08-26 16:22 ` Palmer Dabbelt
2020-09-02 7:13 ` Uwe Kleine-König
2020-08-26 14:47 ` [PATCH 5/6] pwm: sprd: " Krzysztof Kozlowski
2020-08-27 2:01 ` Chunyan Zhang
2020-09-02 7:14 ` Uwe Kleine-König
2020-08-26 14:47 ` Krzysztof Kozlowski [this message]
2020-09-02 7:15 ` [PATCH 6/6] pwm: sun4i: " Uwe Kleine-König
2020-08-26 17:21 ` [PATCH 1/6] pwm: bcm2835: " Florian Fainelli
2020-09-02 7:12 ` Uwe Kleine-König
2020-09-23 11:59 ` Thierry Reding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200826144747.9436-6-krzk@kernel.org \
--to=krzk@kernel$(echo .)org \
--cc=baolin.wang7@gmail$(echo .)com \
--cc=bcm-kernel-feedback-list@broadcom$(echo .)com \
--cc=f.fainelli@gmail$(echo .)com \
--cc=heiko@sntech$(echo .)de \
--cc=lee.jones@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pwm@vger$(echo .)kernel.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-rockchip@lists$(echo .)infradead.org \
--cc=linux-rpi-kernel@lists$(echo .)infradead.org \
--cc=mripard@kernel$(echo .)org \
--cc=nsaenzjulienne@suse$(echo .)de \
--cc=orsonzhai@gmail$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=paul@crapouillou$(echo .)net \
--cc=rjui@broadcom$(echo .)com \
--cc=sbranden@broadcom$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
--cc=wens@csie$(echo .)org \
--cc=zhang.lyra@gmail$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox