Re: [PATCH 11/16] iio: chemical: scd30: Simplify with dev_err_probe()

From: Tomasz Duszynski <tomasz.duszynski@octakon•com>
To: Krzysztof Kozlowski <krzk@kernel•org>
Cc: Peter Meerwald-Stadler <pmeerw@pmeerw•net>,
	Neil Armstrong <narmstrong@baylibre•com>,
	Jonathan Bakker <xc-racer2@live•ca>,
	Tomasz Duszynski <tomasz.duszynski@octakon•com>,
	linux-stm32@st-md-mailman•stormreply.com,
	Jerome Brunet <jbrunet@baylibre•com>,
	Lars-Peter Clausen <lars@metafoo•de>,
	Kevin Hilman <khilman@baylibre•com>,
	Marek Vasut <marek.vasut@gmail•com>,
	Kukjin Kim <kgene@kernel•org>,
	Alexandru Ardelean <alexandru.ardelean@analog•com>,
	Linus Walleij <linus.walleij@linaro•org>,
	Alexandre Torgue <alexandre.torgue@st•com>,
	Michael Hennerich <Michael.Hennerich@analog•com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail•com>,
	linux-samsung-soc@vger•kernel.org,
	linux-amlogic@lists•infradead.org,
	linux-arm-kernel@lists•infradead.org,
	linux-kernel@vger•kernel.org,
	Beniamin Bia <beniamin.bia@analog•com>,
	Maxime Coquelin <mcoquelin.stm32@gmail•com>,
	Hartmut Knaack <knaack.h@gmx•de>, Peter Rosin <peda@axentia•se>,
	Jonathan Cameron <jic23@kernel•org>
Subject: Re: [PATCH 11/16] iio: chemical: scd30: Simplify with dev_err_probe()
Date: Wed, 26 Aug 2020 17:34:34 +0200	[thread overview]
Message-ID: <20200826153434.GA7468@arch> (raw)
In-Reply-To: <20200826145153.10444-11-krzk@kernel.org>

On Wed, Aug 26, 2020 at 04:51:48PM +0200, Krzysztof Kozlowski wrote:
> Common pattern of handling deferred probe can be simplified with
> dev_err_probe().  Less code and also it prints the error value.
>
> Signed-off-by: Krzysztof Kozlowski <krzk@kernel•org>
> ---
>  drivers/iio/chemical/scd30_core.c | 10 +++-------
>  1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c
> index eac76972f83e..92358797796d 100644
> --- a/drivers/iio/chemical/scd30_core.c
> +++ b/drivers/iio/chemical/scd30_core.c
> @@ -705,13 +705,9 @@ int scd30_probe(struct device *dev, int irq, const char *name, void *priv,
>  	indio_dev->available_scan_masks = scd30_scan_masks;
>
>  	state->vdd = devm_regulator_get(dev, "vdd");
> -	if (IS_ERR(state->vdd)) {
> -		if (PTR_ERR(state->vdd) == -EPROBE_DEFER)
> -			return -EPROBE_DEFER;
> -
> -		dev_err(dev, "failed to get regulator\n");
> -		return PTR_ERR(state->vdd);
> -	}
> +	if (IS_ERR(state->vdd))
> +		return dev_err_probe(dev, PTR_ERR(state->vdd),
> +				     "failed to get regulator\n");

I'd say that removing like break would slightly improve readability.
Besides, staying within 100 columns seems socially acceptable now.
Otherwise,

Acked-by: Tomasz Duszynski <tomasz.duszynski@octakon•com>

>
>  	ret = regulator_enable(state->vdd);
>  	if (ret)
> --
> 2.17.1
>

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel