From: Rob Herring <robh@kernel•org>
To: Zhen Lei <thunder.leizhen@huawei•com>
Cc: devicetree <devicetree@vger•kernel.org>,
Lubomir Rintel <lkundrak@v3•sk>, Lee Jones <lee.jones@linaro•org>,
linux-kernel <linux-kernel@vger•kernel.org>,
Rob Herring <robh+dt@kernel•org>,
linux-spi <linux-spi@vger•kernel.org>,
Guenter Roeck <groeck@chromium•org>,
Mark Brown <broonie@kernel•org>, Dan Murphy <dmurphy@ti•com>,
Pavel Machek <pavel@ucw•cz>,
Enric Balletbo i Serra <enric.balletbo@collabora•com>,
Benson Leung <bleung@chromium•org>,
linux-leds <linux-leds@vger•kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists•infradead.org>
Subject: Re: [PATCH 3/6] spi: dt-bindings: spi-controller: explicitly require #address-cells=<0> for slave mode
Date: Wed, 14 Oct 2020 08:41:52 -0500 [thread overview]
Message-ID: <20201014134152.GA1560405@bogus> (raw)
In-Reply-To: <20201013160845.1772-4-thunder.leizhen@huawei.com>
On Wed, 14 Oct 2020 00:08:42 +0800, Zhen Lei wrote:
> scripts/dtc/checks.c:
> if (get_property(node, "spi-slave"))
> spi_addr_cells = 0;
> if (node_addr_cells(node) != spi_addr_cells)
> FAIL(c, dti, node, "incorrect #address-cells for SPI bus");
> if (node_size_cells(node) != 0)
> FAIL(c, dti, node, "incorrect #size-cells for SPI bus");
>
> The above code in check_spi_bus_bridge() require that the number of address
> cells must be 0. So we should explicitly declare "#address-cells = <0>".
>
> Signed-off-by: Zhen Lei <thunder.leizhen@huawei•com>
> ---
> .../devicetree/bindings/spi/spi-controller.yaml | 20 ++++++++++++++------
> 1 file changed, 14 insertions(+), 6 deletions(-)
>
Applied, thanks!
Note that I tried fixing this in dtc, but that was rejected. So this
gets the schema in sync with dtc.
Rob
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-14 13:43 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-13 16:08 [PATCH 0/6] fix all errors except one reported by dt_binding_check Zhen Lei
2020-10-13 16:08 ` [PATCH 1/6] dt-bindings: leds: choose correct color value of multi-led Zhen Lei
2020-10-13 16:17 ` Dan Murphy
2020-10-13 17:04 ` Pavel Machek
2020-10-14 1:08 ` Leizhen (ThunderTown)
2020-10-13 16:08 ` [PATCH 2/6] dt-bindings: mfd: google, cros-ec: explicitly allow additional properties Zhen Lei
2020-10-13 17:53 ` [PATCH 2/6] dt-bindings: mfd: google,cros-ec: " Dan Murphy
2020-10-14 1:52 ` Leizhen (ThunderTown)
2020-10-14 13:38 ` Rob Herring
2020-10-15 6:55 ` Leizhen (ThunderTown)
2020-10-13 16:08 ` [PATCH 3/6] spi: dt-bindings: spi-controller: explicitly require #address-cells=<0> for slave mode Zhen Lei
2020-10-14 13:41 ` Rob Herring [this message]
2020-10-13 16:08 ` [PATCH 4/6] dt-bindings: misc: explicitly add #address-cells " Zhen Lei
2020-10-14 13:42 ` Rob Herring
2020-10-13 16:08 ` [PATCH 5/6] ARM: dts: mmp2-olpc-xo-1-75: explicitly add #address-cells=<0> " Zhen Lei
2020-10-15 9:56 ` Leizhen (ThunderTown)
2020-12-04 7:48 ` Leizhen (ThunderTown)
2020-10-13 16:08 ` [PATCH 6/6] dt-bindings: misc: correct the property name cmd-gpios to cmd-gpio Zhen Lei
2020-10-13 17:32 ` Dan Murphy
2020-10-14 1:29 ` Leizhen (ThunderTown)
2020-10-14 13:50 ` Rob Herring
2020-10-15 3:23 ` Leizhen (ThunderTown)
2020-10-16 14:13 ` Rob Herring
2020-10-15 7:12 ` Lubomir Rintel
2020-10-15 7:32 ` Leizhen (ThunderTown)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014134152.GA1560405@bogus \
--to=robh@kernel$(echo .)org \
--cc=bleung@chromium$(echo .)org \
--cc=broonie@kernel$(echo .)org \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=dmurphy@ti$(echo .)com \
--cc=enric.balletbo@collabora$(echo .)com \
--cc=groeck@chromium$(echo .)org \
--cc=lee.jones@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=linux-spi@vger$(echo .)kernel.org \
--cc=lkundrak@v3$(echo .)sk \
--cc=pavel@ucw$(echo .)cz \
--cc=robh+dt@kernel$(echo .)org \
--cc=thunder.leizhen@huawei$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox