From: Ingo Molnar <mingo@kernel•org>
To: Kalesh Singh <kaleshsingh@google•com>
Cc: joelaf@google•com, Mark Rutland <mark.rutland@arm•com>,
Gavin Shan <gshan@redhat•com>, Brian Geffon <bgeffon@google•com>,
Peter Zijlstra <peterz@infradead•org>,
Catalin Marinas <catalin.marinas@arm•com>,
Ram Pai <linuxram@us•ibm.com>,
Dave Hansen <dave.hansen@intel•com>,
Will Deacon <will@kernel•org>,
lokeshgidra@google•com, linux-kselftest@vger•kernel.org,
"H . Peter Anvin" <hpa@zytor•com>,
Christian Brauner <christian.brauner@ubuntu•com>,
Shuah Khan <shuah@kernel•org>,
Mina Almasry <almasrymina@google•com>, Jia He <justin.he@arm•com>,
Arnd Bergmann <arnd@arndb•de>,
"Aneesh Kumar K.V" <aneesh.kumar@linux•ibm.com>,
Masahiro Yamada <masahiroy@kernel•org>,
x86@kernel•org, Krzysztof Kozlowski <krzk@kernel•org>,
Steven Price <steven.price@arm•com>,
Ingo Molnar <mingo@redhat•com>,
Sami Tolvanen <samitolvanen@google•com>,
kernel-team@android•com, Hassan Naveed <hnaveed@wavecomp•com>,
Masami Hiramatsu <mhiramat@kernel•org>,
Ralph Campbell <rcampbell@nvidia•com>,
Kees Cook <keescook@chromium•org>,
minchan@google•com, Anshuman Khandual <anshuman.khandual@arm•com>,
John Hubbard <jhubbard@nvidia•com>,
Frederic Weisbecker <frederic@kernel•org>,
Borislav Petkov <bp@alien8•de>,
Thomas Gleixner <tglx@linutronix•de>, Zi Yan <ziy@nvidia•com>,
surenb@google•com, linux-arm-kernel@lists•infradead.org,
SeongJae Park <sjpark@amazon•de>,
linux-mm@kvack•org, linux-kernel@vger•kernel.org,
Mike Rapoport <rppt@kernel•org>,
Andrew Morton <akpm@linux-foundation•org>,
"Kirill A . Shutemov" <kirill.shutemov@linux•intel.com>,
Sandipan Das <sandipan@linux•ibm.com>
Subject: Re: [PATCH v4 5/5] x86: mremap speedup - Enable HAVE_MOVE_PUD
Date: Wed, 14 Oct 2020 17:53:18 +0200 [thread overview]
Message-ID: <20201014155318.GA3014922@gmail.com> (raw)
In-Reply-To: <20201014005320.2233162-6-kaleshsingh@google.com>
* Kalesh Singh <kaleshsingh@google•com> wrote:
> HAVE_MOVE_PUD enables remapping pages at the PUD level if both the
> source and destination addresses are PUD-aligned.
>
> With HAVE_MOVE_PUD enabled it can be inferred that there is approximately
> a 13x improvement in performance on x86. (See data below).
>
> ------- Test Results ---------
>
> The following results were obtained using a 5.4 kernel, by remapping
> a PUD-aligned, 1GB sized region to a PUD-aligned destination.
> The results from 10 iterations of the test are given below:
>
> Total mremap times for 1GB data on x86. All times are in nanoseconds.
>
> Control HAVE_MOVE_PUD
>
> 180394 15089
> 235728 14056
> 238931 25741
> 187330 13838
> 241742 14187
> 177925 14778
> 182758 14728
> 160872 14418
> 205813 15107
> 245722 13998
>
> 205721.5 15594 <-- Mean time in nanoseconds
>
> A 1GB mremap completion time drops from ~205 microseconds
> to ~15 microseconds on x86. (~13x speed up).
>
> Signed-off-by: Kalesh Singh <kaleshsingh@google•com>
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux•intel.com>
> Cc: Andrew Morton <akpm@linux-foundation•org>
> Cc: Thomas Gleixner <tglx@linutronix•de>
> Cc: Ingo Molnar <mingo@redhat•com>
> Cc: Borislav Petkov <bp@alien8•de>
> Cc: H. Peter Anvin <hpa@zytor•com>
Nice!
Assuming it's all correct code:
Acked-by: Ingo Molnar <mingo@kernel•org>
Thanks,
Ingo
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-14 15:54 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-14 0:53 [PATCH v4 0/5] Speed up mremap on large regions Kalesh Singh
2020-10-14 0:53 ` [PATCH v4 1/5] kselftests: vm: Add mremap tests Kalesh Singh
2020-10-14 19:02 ` Kalesh Singh
2020-10-14 0:53 ` [PATCH v4 2/5] arm64: mremap speedup - Enable HAVE_MOVE_PMD Kalesh Singh
2020-10-15 10:55 ` Will Deacon
2020-10-14 0:53 ` [PATCH v4 4/5] arm64: mremap speedup - Enable HAVE_MOVE_PUD Kalesh Singh
2020-10-14 0:53 ` [PATCH v4 5/5] x86: " Kalesh Singh
2020-10-14 15:53 ` Ingo Molnar [this message]
2020-10-15 20:40 ` [PATCH v4 0/5] Speed up mremap on large regions Will Deacon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201014155318.GA3014922@gmail.com \
--to=mingo@kernel$(echo .)org \
--cc=akpm@linux-foundation$(echo .)org \
--cc=almasrymina@google$(echo .)com \
--cc=aneesh.kumar@linux$(echo .)ibm.com \
--cc=anshuman.khandual@arm$(echo .)com \
--cc=arnd@arndb$(echo .)de \
--cc=bgeffon@google$(echo .)com \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=christian.brauner@ubuntu$(echo .)com \
--cc=dave.hansen@intel$(echo .)com \
--cc=frederic@kernel$(echo .)org \
--cc=gshan@redhat$(echo .)com \
--cc=hnaveed@wavecomp$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=jhubbard@nvidia$(echo .)com \
--cc=joelaf@google$(echo .)com \
--cc=justin.he@arm$(echo .)com \
--cc=kaleshsingh@google$(echo .)com \
--cc=keescook@chromium$(echo .)org \
--cc=kernel-team@android$(echo .)com \
--cc=kirill.shutemov@linux$(echo .)intel.com \
--cc=krzk@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linuxram@us$(echo .)ibm.com \
--cc=lokeshgidra@google$(echo .)com \
--cc=mark.rutland@arm$(echo .)com \
--cc=masahiroy@kernel$(echo .)org \
--cc=mhiramat@kernel$(echo .)org \
--cc=minchan@google$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=rcampbell@nvidia$(echo .)com \
--cc=rppt@kernel$(echo .)org \
--cc=samitolvanen@google$(echo .)com \
--cc=sandipan@linux$(echo .)ibm.com \
--cc=shuah@kernel$(echo .)org \
--cc=sjpark@amazon$(echo .)de \
--cc=steven.price@arm$(echo .)com \
--cc=surenb@google$(echo .)com \
--cc=tglx@linutronix$(echo .)de \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=ziy@nvidia$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox