From: Stephan Gerhold <stephan@gerhold•net>
To: Sudeep Holla <sudeep.holla@arm•com>
Cc: Nishanth Menon <nm@ti•com>, Len Brown <len.brown@intel•com>,
ulf.hansson@linaro•org, linux-samsung-soc@vger•kernel.org,
Vincent Guittot <vincent.guittot@linaro•org>,
Kevin Hilman <khilman@kernel•org>,
Stephen Boyd <sboyd@kernel•org>,
Viresh Kumar <viresh.kumar@linaro•org>,
linux-pm@vger•kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki•net>,
linux-kernel@vger•kernel.org,
Krzysztof Kozlowski <krzk@kernel•org>,
nks@flawful•org, Kukjin Kim <kgene@kernel•org>,
Pavel Machek <pavel@ucw•cz>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
georgi.djakov@linaro•org, linux-arm-kernel@lists•infradead.org,
Viresh Kumar <vireshk@kernel•org>
Subject: Re: [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER
Date: Fri, 16 Oct 2020 17:28:02 +0200 [thread overview]
Message-ID: <20201016152802.GA3966@gerhold.net> (raw)
In-Reply-To: <20201016111222.lvakbmjhlrocpogt@bogus>
On Fri, Oct 16, 2020 at 12:12:22PM +0100, Sudeep Holla wrote:
> On Fri, Oct 16, 2020 at 07:00:21AM +0100, Sudeep Holla wrote:
> > On Fri, Oct 16, 2020 at 09:54:34AM +0530, Viresh Kumar wrote:
> > > On 15-10-20, 19:05, Sudeep Holla wrote:
> > > > OK, this breaks with SCMI which doesn't provide clocks but manage OPPs
> > > > directly. Before this change clk_get(dev..) was allowed to fail and
> > > > --EPROBE_DEFER was not an error.
> > >
> > > I think the change in itself is fine. We should be returning from
> > > there if we get EPROBE_DEFER. The question is rather why are you
> > > getting EPROBE_DEFER here ?
> > >
> >
> > Ah OK, I didn't spend too much time, saw -EPROBE_DEFER, just reverted
> > this patch and it worked. I need to check it in detail yet.
> >
>
> You confused me earlier. As I said there will be no clock provider
> registered for SCMI CPU/Dev DVFS.
> opp_table->clk = clk_get(dev, NULL);
> will always return -EPROBE_DEFER as there is no clock provider for dev.
Shouldn't it return -ENOENT if there is no clock for the SCMI case?
With -EPROBE_DEFER I would expect that it shows up at some point.
I tried to avoid a situation like this by ignoring all errors
!= -EPROBE_DEFER. So if clk_get(dev, NULL) would return -ENOENT
everything should work as expected...
Thanks,
Stephan
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-10-16 15:29 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-24 9:09 [PATCH V2 1/2] opp: Allow dev_pm_opp_get_opp_table() to return -EPROBE_DEFER Viresh Kumar
2020-08-24 9:17 ` Krzysztof Kozlowski
2020-08-24 11:08 ` Ulf Hansson
2020-08-24 11:39 ` Stephan Gerhold
2020-10-15 18:05 ` Sudeep Holla
2020-10-16 4:24 ` Viresh Kumar
2020-10-16 6:00 ` Sudeep Holla
2020-10-16 11:12 ` Sudeep Holla
2020-10-16 15:28 ` Stephan Gerhold [this message]
2020-10-19 4:58 ` Viresh Kumar
2020-10-19 9:17 ` Sudeep Holla
2020-10-19 9:24 ` Viresh Kumar
2020-10-19 10:12 ` Sudeep Holla
2020-10-19 10:35 ` Viresh Kumar
2020-10-19 14:10 ` Sudeep Holla
2020-10-20 5:05 ` Viresh Kumar
2020-10-20 5:54 ` Viresh Kumar
2020-10-20 9:37 ` Sudeep Holla
2020-10-20 9:41 ` Viresh Kumar
2020-10-20 9:52 ` Sudeep Holla
2020-10-20 9:59 ` Viresh Kumar
2020-10-27 22:24 ` Guenter Roeck
2020-10-28 4:06 ` Viresh Kumar
2020-10-28 17:29 ` Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201016152802.GA3966@gerhold.net \
--to=stephan@gerhold$(echo .)net \
--cc=georgi.djakov@linaro$(echo .)org \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=kgene@kernel$(echo .)org \
--cc=khilman@kernel$(echo .)org \
--cc=krzk@kernel$(echo .)org \
--cc=len.brown@intel$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-pm@vger$(echo .)kernel.org \
--cc=linux-samsung-soc@vger$(echo .)kernel.org \
--cc=nks@flawful$(echo .)org \
--cc=nm@ti$(echo .)com \
--cc=pavel@ucw$(echo .)cz \
--cc=rjw@rjwysocki$(echo .)net \
--cc=sboyd@kernel$(echo .)org \
--cc=sudeep.holla@arm$(echo .)com \
--cc=ulf.hansson@linaro$(echo .)org \
--cc=vincent.guittot@linaro$(echo .)org \
--cc=viresh.kumar@linaro$(echo .)org \
--cc=vireshk@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox