From: Andrew Lunn <andrew@lunn•ch>
To: Baruch Siach <baruch@tkos•co.il>
Cc: linux-pwm@vger•kernel.org,
"Sascha Hauer" <s.hauer@pengutronix•de>,
"Jason Cooper" <jason@lakedaemon•net>,
linux-gpio@vger•kernel.org,
"Linus Walleij" <linus.walleij@linaro•org>,
"Chris Packham" <chris.packham@alliedtelesis•co.nz>,
"Bartosz Golaszewski" <bgolaszewski@baylibre•com>,
"Thierry Reding" <thierry.reding@gmail•com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin•com>,
"Uwe Kleine-König" <u.kleine-koenig@pengutronix•de>,
"Ralph Sennhauser" <ralph.sennhauser@gmail•com>,
"Lee Jones" <lee.jones@linaro•org>,
"Gregory Clement" <gregory.clement@bootlin•com>,
linux-arm-kernel@lists•infradead.org,
"Sebastian Hesselbarth" <sebastian.hesselbarth@gmail•com>
Subject: Re: [PATCH 3/5] gpio: mvebu: add pwm support for Armada 8K/7K
Date: Thu, 19 Nov 2020 14:34:29 +0100 [thread overview]
Message-ID: <20201119133429.GS1804098@lunn.ch> (raw)
In-Reply-To: <878sax6f43.fsf@tarshish>
> >> @@ -1200,6 +1235,13 @@ static int mvebu_gpio_probe(struct platform_device *pdev)
> >>
> >> devm_gpiochip_add_data(&pdev->dev, &mvchip->chip, mvchip);
> >>
> >> + /* Some MVEBU SoCs have simple PWM support for GPIO lines */
> >> + if (IS_ENABLED(CONFIG_PWM)) {
> >> + err = mvebu_pwm_probe(pdev, mvchip, id);
> >> + if (err)
> >> + return err;
> >> + }
> >> +
> >
> > The existing error handling looks odd here. Why is there no goto
> > err_domain when probing the PWMs fails? I wonder if this a bug from me
> > from a long time again?
>
> What would you release under the err_domain label? As far as I can see
> all resources are allocated using devres, and released automatically on
> failure exit.
The IRQ domain is still registers. So once the memory is automatically
freed, don't we have a potential use after free?
Andrew
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-11-19 13:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-18 10:30 [PATCH 0/5] gpio: mvebu: Armada 8K/7K PWM support Baruch Siach
2020-11-18 10:30 ` [PATCH 1/5] gpio: mvebu: update Armada XP per-CPU comment Baruch Siach
2020-11-18 22:47 ` Andrew Lunn
2020-11-18 10:30 ` [PATCH 2/5] gpio: mvebu: switch pwm duration registers to regmap Baruch Siach
2020-11-18 22:59 ` Andrew Lunn
2020-11-18 10:30 ` [PATCH 3/5] gpio: mvebu: add pwm support for Armada 8K/7K Baruch Siach
2020-11-18 23:18 ` Andrew Lunn
2020-11-19 6:21 ` Baruch Siach
2020-11-19 13:34 ` Andrew Lunn [this message]
2020-11-19 13:47 ` Baruch Siach
2020-12-01 18:16 ` Bartosz Golaszewski
2020-12-01 18:21 ` Baruch Siach
2020-11-18 10:30 ` [PATCH 4/5] arm64: dts: armada: add pwm offsets for ap/cp gpios Baruch Siach
2020-11-18 10:30 ` [PATCH 5/5] dt-bindings: ap806: document gpio pwm-offset property Baruch Siach
2020-11-18 22:46 ` [PATCH 0/5] gpio: mvebu: Armada 8K/7K PWM support Andrew Lunn
2020-11-19 5:49 ` Baruch Siach
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201119133429.GS1804098@lunn.ch \
--to=andrew@lunn$(echo .)ch \
--cc=baruch@tkos$(echo .)co.il \
--cc=bgolaszewski@baylibre$(echo .)com \
--cc=chris.packham@alliedtelesis$(echo .)co.nz \
--cc=gregory.clement@bootlin$(echo .)com \
--cc=jason@lakedaemon$(echo .)net \
--cc=lee.jones@linaro$(echo .)org \
--cc=linus.walleij@linaro$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-gpio@vger$(echo .)kernel.org \
--cc=linux-pwm@vger$(echo .)kernel.org \
--cc=ralph.sennhauser@gmail$(echo .)com \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=sebastian.hesselbarth@gmail$(echo .)com \
--cc=thierry.reding@gmail$(echo .)com \
--cc=thomas.petazzoni@bootlin$(echo .)com \
--cc=u.kleine-koenig@pengutronix$(echo .)de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox