From: Mike Rapoport <rppt@linux•ibm.com>
To: Andrew Morton <akpm@linux-foundation•org>
Cc: Mark Rutland <mark.rutland@arm•com>,
David Hildenbrand <david@redhat•com>,
Peter Zijlstra <peterz@infradead•org>,
Catalin Marinas <catalin.marinas@arm•com>,
Dave Hansen <dave.hansen@linux•intel.com>,
linux-mm@kvack•org, linux-kselftest@vger•kernel.org,
"H. Peter Anvin" <hpa@zytor•com>,
Christopher Lameter <cl@linux•com>, Shuah Khan <shuah@kernel•org>,
Thomas Gleixner <tglx@linutronix•de>,
Elena Reshetova <elena.reshetova@intel•com>,
linux-arch@vger•kernel.org, Tycho Andersen <tycho@tycho•ws>,
linux-nvdimm@lists•01.org, Will Deacon <will@kernel•org>,
x86@kernel•org, Matthew Wilcox <willy@infradead•org>,
Ingo Molnar <mingo@redhat•com>,
Michael Kerrisk <mtk.manpages@gmail•com>,
Palmer Dabbelt <palmerdabbelt@google•com>,
Arnd Bergmann <arnd@arndb•de>,
James Bottomley <jejb@linux•ibm.com>,
Borislav Petkov <bp@alien8•de>,
Alexander Viro <viro@zeniv•linux.org.uk>,
Andy Lutomirski <luto@kernel•org>,
Paul Walmsley <paul.walmsley@sifive•com>,
"Kirill A. Shutemov" <kirill@shutemov•name>,
Dan Williams <dan.j.williams@intel•com>,
linux-arm-kernel@lists•infradead.org, linux-api@vger•kernel.org,
linux-kernel@vger•kernel.org, linux-riscv@lists•infradead.org,
Palmer Dabbelt <palmer@dabbelt•com>,
linux-fsdevel@vger•kernel.org, Shakeel Butt <shakeelb@google•com>,
Rick Edgecombe <rick.p.edgecombe@intel•com>,
Roman Gushchin <guro@fb•com>, Mike Rapoport <rppt@kernel•org>
Subject: Re: [PATCH v14 09/10] arch, mm: wire up memfd_secret system call were relevant
Date: Sun, 6 Dec 2020 13:30:48 +0200 [thread overview]
Message-ID: <20201206113048.GC123287@linux.ibm.com> (raw)
In-Reply-To: <20201203153916.91f0f80dcb8a0fa81fc341fa@linux-foundation.org>
On Thu, Dec 03, 2020 at 03:39:16PM -0800, Andrew Morton wrote:
> On Thu, 3 Dec 2020 08:29:48 +0200 Mike Rapoport <rppt@kernel•org> wrote:
>
> > From: Mike Rapoport <rppt@linux•ibm.com>
> >
> > Wire up memfd_secret system call on architectures that define
> > ARCH_HAS_SET_DIRECT_MAP, namely arm64, risc-v and x86.
> >
> > ...
> >
> > --- a/include/uapi/asm-generic/unistd.h
> > +++ b/include/uapi/asm-generic/unistd.h
> > @@ -861,9 +861,13 @@ __SYSCALL(__NR_faccessat2, sys_faccessat2)
> > __SYSCALL(__NR_process_madvise, sys_process_madvise)
> > #define __NR_watch_mount 441
> > __SYSCALL(__NR_watch_mount, sys_watch_mount)
> > +#ifdef __ARCH_WANT_MEMFD_SECRET
> > +#define __NR_memfd_secret 442
> > +__SYSCALL(__NR_memfd_secret, sys_memfd_secret)
> > +#endif
>
> Why do we add the ifdef? Can't we simply define the syscall on all
> architectures and let sys_ni do its thing?
I quite blindly copied it from clone3. I agree there is no real need for
it and sys_ni handles this just fine.
--
Sincerely yours,
Mike.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-06 11:34 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-03 6:29 [PATCH v14 00/10] mm: introduce memfd_secret system call to create "secret" memory areas Mike Rapoport
2020-12-03 6:29 ` [PATCH v14 01/10] mm: add definition of PMD_PAGE_ORDER Mike Rapoport
2020-12-03 6:29 ` [PATCH v14 02/10] mmap: make mlock_future_check() global Mike Rapoport
2020-12-03 6:29 ` [PATCH v14 03/10] set_memory: allow set_direct_map_*_noflush() for multiple pages Mike Rapoport
2020-12-03 6:29 ` [PATCH v14 04/10] set_memory: allow querying whether set_direct_map_*() is actually enabled Mike Rapoport
2020-12-03 23:36 ` Andrew Morton
2020-12-06 11:28 ` Mike Rapoport
2020-12-03 6:29 ` [PATCH v14 05/10] mm: introduce memfd_secret system call to create "secret" memory areas Mike Rapoport
2021-01-19 20:22 ` Matthew Wilcox
2021-01-20 15:05 ` Mike Rapoport
2021-01-20 16:02 ` Matthew Wilcox
2021-01-20 17:04 ` Mike Rapoport
2020-12-03 6:29 ` [PATCH v14 06/10] secretmem: use PMD-size pages to amortize direct map fragmentation Mike Rapoport
2020-12-03 6:29 ` [PATCH v14 07/10] secretmem: add memcg accounting Mike Rapoport
2020-12-03 15:47 ` Shakeel Butt
2020-12-03 6:29 ` [PATCH v14 08/10] PM: hibernate: disable when there are active secretmem users Mike Rapoport
2020-12-03 6:29 ` [PATCH v14 09/10] arch, mm: wire up memfd_secret system call were relevant Mike Rapoport
2020-12-03 23:39 ` Andrew Morton
2020-12-06 11:30 ` Mike Rapoport [this message]
2020-12-07 14:45 ` Qian Cai
2020-12-07 16:00 ` Mike Rapoport
2020-12-08 1:34 ` Andrew Morton
2020-12-03 6:29 ` [PATCH v14 10/10] secretmem: test: add basic selftest for memfd_secret(2) Mike Rapoport
2020-12-12 6:16 ` John Hubbard
2020-12-12 13:59 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201206113048.GC123287@linux.ibm.com \
--to=rppt@linux$(echo .)ibm.com \
--cc=akpm@linux-foundation$(echo .)org \
--cc=arnd@arndb$(echo .)de \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=cl@linux$(echo .)com \
--cc=dan.j.williams@intel$(echo .)com \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=david@redhat$(echo .)com \
--cc=elena.reshetova@intel$(echo .)com \
--cc=guro@fb$(echo .)com \
--cc=hpa@zytor$(echo .)com \
--cc=jejb@linux$(echo .)ibm.com \
--cc=kirill@shutemov$(echo .)name \
--cc=linux-api@vger$(echo .)kernel.org \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-fsdevel@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-kselftest@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-nvdimm@lists$(echo .)01.org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=luto@kernel$(echo .)org \
--cc=mark.rutland@arm$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=mtk.manpages@gmail$(echo .)com \
--cc=palmer@dabbelt$(echo .)com \
--cc=palmerdabbelt@google$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=rick.p.edgecombe@intel$(echo .)com \
--cc=rppt@kernel$(echo .)org \
--cc=shakeelb@google$(echo .)com \
--cc=shuah@kernel$(echo .)org \
--cc=tglx@linutronix$(echo .)de \
--cc=tycho@tycho$(echo .)ws \
--cc=viro@zeniv$(echo .)linux.org.uk \
--cc=will@kernel$(echo .)org \
--cc=willy@infradead$(echo .)org \
--cc=x86@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox