From: Will Deacon <will@kernel•org>
To: linux-arm-kernel@lists•infradead.org
Cc: linux-arch@vger•kernel.org, Marc Zyngier <maz@kernel•org>,
kernel-team@android•com,
Vincent Guittot <vincent.guittot@linaro•org>,
Juri Lelli <juri.lelli@redhat•com>,
Quentin Perret <qperret@google•com>,
Peter Zijlstra <peterz@infradead•org>,
Catalin Marinas <catalin.marinas@arm•com>,
Johannes Weiner <hannes@cmpxchg•org>,
linux-kernel@vger•kernel.org, Qais Yousef <qais.yousef@arm•com>,
Suren Baghdasaryan <surenb@google•com>,
Ingo Molnar <mingo@redhat•com>, Li Zefan <lizefan@huawei•com>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Tejun Heo <tj@kernel•org>, Will Deacon <will@kernel•org>,
Morten Rasmussen <morten.rasmussen@arm•com>
Subject: [PATCH v5 07/15] cpuset: Don't use the cpu_possible_mask as a last resort for cgroup v1
Date: Tue, 8 Dec 2020 13:28:27 +0000 [thread overview]
Message-ID: <20201208132835.6151-8-will@kernel.org> (raw)
In-Reply-To: <20201208132835.6151-1-will@kernel.org>
If the scheduler cannot find an allowed CPU for a task,
cpuset_cpus_allowed_fallback() will widen the affinity to cpu_possible_mask
if cgroup v1 is in use.
In preparation for allowing architectures to provide their own fallback
mask, just return early if we're not using cgroup v2 and allow
select_fallback_rq() to figure out the mask by itself.
Cc: Li Zefan <lizefan@huawei•com>
Cc: Tejun Heo <tj@kernel•org>
Cc: Johannes Weiner <hannes@cmpxchg•org>
Reviewed-by: Quentin Perret <qperret@google•com>
Signed-off-by: Will Deacon <will@kernel•org>
---
kernel/cgroup/cpuset.c | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/kernel/cgroup/cpuset.c b/kernel/cgroup/cpuset.c
index 57b5b5d0a5fd..e970737c3ed2 100644
--- a/kernel/cgroup/cpuset.c
+++ b/kernel/cgroup/cpuset.c
@@ -3299,9 +3299,11 @@ void cpuset_cpus_allowed(struct task_struct *tsk, struct cpumask *pmask)
void cpuset_cpus_allowed_fallback(struct task_struct *tsk)
{
+ if (!is_in_v2_mode())
+ return; /* select_fallback_rq will try harder */
+
rcu_read_lock();
- do_set_cpus_allowed(tsk, is_in_v2_mode() ?
- task_cs(tsk)->cpus_allowed : cpu_possible_mask);
+ do_set_cpus_allowed(tsk, task_cs(tsk)->cpus_allowed);
rcu_read_unlock();
/*
--
2.29.2.576.ga3fc446d84-goog
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2020-12-08 13:31 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-08 13:28 [PATCH v5 00/15] An alternative series for asymmetric AArch32 systems Will Deacon
2020-12-08 13:28 ` [PATCH v5 01/15] arm64: cpuinfo: Split AArch32 registers out into a separate struct Will Deacon
2020-12-08 13:28 ` [PATCH v5 02/15] arm64: Allow mismatched 32-bit EL0 support Will Deacon
2020-12-08 13:28 ` [PATCH v5 03/15] KVM: arm64: Kill 32-bit vCPUs on systems with mismatched " Will Deacon
2020-12-08 13:28 ` [PATCH v5 04/15] arm64: Kill 32-bit applications scheduled on 64-bit-only CPUs Will Deacon
2020-12-08 13:28 ` [PATCH v5 05/15] arm64: Advertise CPUs capable of running 32-bit applications in sysfs Will Deacon
2020-12-08 13:28 ` [PATCH v5 06/15] sched: Introduce task_cpu_possible_mask() to limit fallback rq selection Will Deacon
2020-12-08 13:28 ` Will Deacon [this message]
2020-12-17 12:15 ` [PATCH v5 07/15] cpuset: Don't use the cpu_possible_mask as a last resort for cgroup v1 Qais Yousef
2020-12-17 13:44 ` Peter Zijlstra
2020-12-17 14:59 ` Will Deacon
2020-12-17 15:00 ` Qais Yousef
2020-12-08 13:28 ` [PATCH v5 08/15] cpuset: Honour task_cpu_possible_mask() in guarantee_online_cpus() Will Deacon
2020-12-28 3:54 ` Suren Baghdasaryan
2020-12-08 13:28 ` [PATCH v5 09/15] sched: Reject CPU affinity changes based on task_cpu_possible_mask() Will Deacon
2020-12-08 13:28 ` [PATCH v5 10/15] sched: Introduce force_compatible_cpus_allowed_ptr() to limit CPU affinity Will Deacon
2020-12-28 4:29 ` Suren Baghdasaryan
2020-12-08 13:28 ` [PATCH v5 11/15] arm64: Implement task_cpu_possible_mask() Will Deacon
2020-12-08 13:28 ` [PATCH v5 12/15] arm64: exec: Adjust affinity for compat tasks with mismatched 32-bit EL0 Will Deacon
2020-12-08 13:28 ` [PATCH v5 13/15] arm64: Prevent offlining first CPU with 32-bit EL0 on mismatched system Will Deacon
2020-12-08 13:28 ` [PATCH v5 14/15] arm64: Hook up cmdline parameter to allow mismatched 32-bit EL0 Will Deacon
2020-12-08 13:28 ` [PATCH v5 15/15] arm64: Remove logic to kill 32-bit tasks on 64-bit-only cores Will Deacon
2020-12-15 17:36 ` [PATCH v5 00/15] An alternative series for asymmetric AArch32 systems Peter Zijlstra
2020-12-15 18:50 ` Will Deacon
2020-12-17 10:55 ` Peter Zijlstra
2020-12-16 11:16 ` Qais Yousef
2020-12-16 14:14 ` Will Deacon
2020-12-16 16:48 ` Qais Yousef
2020-12-16 18:21 ` Suren Baghdasaryan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201208132835.6151-8-will@kernel.org \
--to=will@kernel$(echo .)org \
--cc=catalin.marinas@arm$(echo .)com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hannes@cmpxchg$(echo .)org \
--cc=juri.lelli@redhat$(echo .)com \
--cc=kernel-team@android$(echo .)com \
--cc=linux-arch@vger$(echo .)kernel.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=lizefan@huawei$(echo .)com \
--cc=maz@kernel$(echo .)org \
--cc=mingo@redhat$(echo .)com \
--cc=morten.rasmussen@arm$(echo .)com \
--cc=peterz@infradead$(echo .)org \
--cc=qais.yousef@arm$(echo .)com \
--cc=qperret@google$(echo .)com \
--cc=surenb@google$(echo .)com \
--cc=tj@kernel$(echo .)org \
--cc=vincent.guittot@linaro$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox