Subject: Re: [PATCH 1/4] arm64: defconfig: Enable Librem5 Devkit components

From: Krzysztof Kozlowski <[email-masked]>
Date: Tue, 15 Dec 2020 10:17:29 +0100

On Sun, Dec 13, 2020 at 06:17:11PM +0100, Guido Günther wrote:
> This enables
> 
> - touchscreen: CONFIG_TOUCHSCREEN_GOODIX
> - charge controller: CONFIG_CHARGER_BQ25890
> - audio codec: CONFIG_SND_SOC_IMX_SGTL5000
> - rtc: CONFIG_RTC_DRV_M41T80
> - magnetometer: CONFIG_IIO_ST_MAGN_3AXIS
> - pwm: CONFIG_PWM_IMX27
> - modem codec: CONFIG_SND_SOC_GTM601
> - modem serial: CONFIG_USB_SERIAL_OPTION

Do not repeat the contents of the patch. We can easily see which configs
you enable. Instead, please name the devices you want to use, not the
CONFIG entries.  Several drivers actually support multiple devices.

Describe also the board you are enabling it for. You wrote only
"Librem5", but I am not sure whether this is specific enough. Is it even
on NXP i.MX processor? Maybe on something else?

This is a generic defconfig so your change will affect everyone.

Best regards,
Krzysztof

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel