From: Anand Moon <linux.amoon@gmail•com>
To: linux-phy@lists•infradead.org,
linux-arm-kernel@lists•infradead.org,
linux-amlogic@lists•infradead.org, linux-kernel@vger•kernel.org
Cc: Anand Moon <linux.amoon@gmail•com>,
Matt Corallo <oc2udbzfd@mattcorallo•com>,
Martin Blumenstingl <martin.blumenstingl@googlemail•com>,
Rob Herring <robh+dt@kernel•org>,
Neil Armstrong <narmstrong@baylibre•com>,
Kevin Hilman <khilman@baylibre•com>,
Jerome Brunet <jbrunet@baylibre•com>,
Kishon Vijay Abraham I <kishon@ti•com>,
Vinod Koul <vkoul@kernel•org>,
Emiliano Ingrassia <ingrassia@epigenesys•com>,
devicetree@vger•kernel.org
Subject: [PATCHv1 3/3] phy: amlogic: meson8b-usb2: don't log an error on -EPROBE_DEFER
Date: Tue, 13 Jul 2021 05:52:15 +0000 [thread overview]
Message-ID: <20210713055227.1142-4-linux.amoon@gmail.com> (raw)
In-Reply-To: <20210713055227.1142-1-linux.amoon@gmail.com>
devm_phy_create can return -EPROBE_DEFER if the phy-supply is not ready
yet. Silence this warning as the driver framework will re-attempt
registering the PHY. Use dev_err_probe() for phy resources to indicate
the deferral reason when waiting for the resource to come up.
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail•com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail•com>
Signed-off-by: Anand Moon <linux.amoon@gmail•com>
---
[0] https://patchwork.kernel.org/project/linux-amlogic/patch/20210617194154.2397-9-linux.amoon@gmail.com/
---
---
drivers/phy/amlogic/phy-meson8b-usb2.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/amlogic/phy-meson8b-usb2.c b/drivers/phy/amlogic/phy-meson8b-usb2.c
index 2aad45c55494..cf10bed40528 100644
--- a/drivers/phy/amlogic/phy-meson8b-usb2.c
+++ b/drivers/phy/amlogic/phy-meson8b-usb2.c
@@ -277,8 +277,8 @@ static int phy_meson8b_usb2_probe(struct platform_device *pdev)
phy = devm_phy_create(&pdev->dev, NULL, &phy_meson8b_usb2_ops);
if (IS_ERR(phy)) {
- dev_err(&pdev->dev, "failed to create PHY\n");
- return PTR_ERR(phy);
+ return dev_err_probe(&pdev->dev, PTR_ERR(phy),
+ "failed to create PHY\n");
}
phy_set_drvdata(phy, priv);
--
2.32.0
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-07-13 5:55 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-13 5:52 [PATCHv1 0/3] Meson-8b and Meson-gxbb Fix some missing code Anand Moon
2021-07-13 5:52 ` [PATCHv1 1/3] ARM: dts: meson8b: odroidc1: Add usb phy power node Anand Moon
2021-07-13 15:05 ` Martin Blumenstingl
2021-07-13 18:44 ` Anand Moon
2021-07-13 20:35 ` Martin Blumenstingl
2021-07-14 11:59 ` Anand Moon
2021-07-14 17:25 ` Anand Moon
2021-07-14 23:30 ` Martin Blumenstingl
2021-07-15 10:24 ` Anand Moon
2021-07-13 5:52 ` [PATCHv1 2/3] phy: amlogic: meson8b-usb2: Power off the PHY by putting it into reset mode Anand Moon
2021-07-13 15:10 ` Martin Blumenstingl
2021-07-13 5:52 ` Anand Moon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210713055227.1142-4-linux.amoon@gmail.com \
--to=linux.amoon@gmail$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=ingrassia@epigenesys$(echo .)com \
--cc=jbrunet@baylibre$(echo .)com \
--cc=khilman@baylibre$(echo .)com \
--cc=kishon@ti$(echo .)com \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-phy@lists$(echo .)infradead.org \
--cc=martin.blumenstingl@googlemail$(echo .)com \
--cc=narmstrong@baylibre$(echo .)com \
--cc=oc2udbzfd@mattcorallo$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=vkoul@kernel$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox