From: Jonathan Cameron <Jonathan.Cameron@Huawei•com>
To: Hui Liu <hui.liu@mediatek•com>
Cc: <robh+dt@kernel•org>, <jic23@kernel•org>, <lars@metafoo•de>,
<pmeerw@pmeerw•net>, <srv_heupstream@mediatek•com>,
<zhiyong.tao@mediatek•com>, <chun-hung.wu@mediatek•com>,
<yingjoe.chen@mediatek•com>, <seiya.wang@mediatek•com>,
<matthias.bgg@gmail•com>, <s.hauer@pengutronix•de>,
<devicetree@vger•kernel.org>, <linux-kernel@vger•kernel.org>,
<linux-arm-kernel@lists•infradead.org>,
<linux-iio@vger•kernel.org>, <linux-mediatek@lists•infradead.org>
Subject: Re: [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case
Date: Thu, 12 Aug 2021 19:07:25 +0100 [thread overview]
Message-ID: <20210812190725.00007449@Huawei.com> (raw)
In-Reply-To: <20210812054844.30575-2-hui.liu@mediatek.com>
On Thu, 12 Aug 2021 13:48:43 +0800
Hui Liu <hui.liu@mediatek•com> wrote:
> Add support IIO_CHAN_INFO_RAW case.
Why?
We almost never support both RAW and PROCESSED as userspace should be
fine to use either. There are a few reasons we've let drivers do
this but I would like know why it matters to you and it definitely
needs to be in the patch description.
>
> Signed-off-by: Hui Liu <hui.liu@mediatek•com>
> ---
> drivers/iio/adc/mt6577_auxadc.c | 16 +++++++++++++++-
> 1 file changed, 15 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iio/adc/mt6577_auxadc.c b/drivers/iio/adc/mt6577_auxadc.c
> index 79c1dd68b909..e995d43287b2 100644
> --- a/drivers/iio/adc/mt6577_auxadc.c
> +++ b/drivers/iio/adc/mt6577_auxadc.c
> @@ -60,7 +60,8 @@ static const struct mtk_auxadc_compatible mt6765_compat = {
> .type = IIO_VOLTAGE, \
> .indexed = 1, \
> .channel = (idx), \
> - .info_mask_separate = BIT(IIO_CHAN_INFO_PROCESSED), \
> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
> + BIT(IIO_CHAN_INFO_PROCESSED), \
> }
>
> static const struct iio_chan_spec mt6577_auxadc_iio_channels[] = {
> @@ -181,6 +182,19 @@ static int mt6577_auxadc_read_raw(struct iio_dev *indio_dev,
> struct mt6577_auxadc_device *adc_dev = iio_priv(indio_dev);
>
> switch (info) {
> + case IIO_CHAN_INFO_RAW:
> + *val = mt6577_auxadc_read(indio_dev, chan);
> + if (*val < 0) {
> + dev_notice(indio_dev->dev.parent,
> + "failed to sample data on channel[%d]\n",
> + chan->channel);
> + return *val;
> + }
> + if (adc_dev->dev_comp->sample_data_cali)
> + *val = mt_auxadc_get_cali_data(*val, true);
> +
> + return IIO_VAL_INT;
> +
> case IIO_CHAN_INFO_PROCESSED:
> *val = mt6577_auxadc_read(indio_dev, chan);
> if (*val < 0) {
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next parent reply other threads:[~2021-08-12 18:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20210812054844.30575-1-hui.liu@mediatek.com>
[not found] ` <20210812054844.30575-2-hui.liu@mediatek.com>
2021-08-12 18:07 ` Jonathan Cameron [this message]
[not found] ` <042625639032bffe73b60a5c6274511e58e34ef4.camel@mediatek.com>
2021-08-14 16:10 ` [PATCH v1 1/2] iio: mtk-auxadc: add support IIO_CHAN_INFO_RAW case Jonathan Cameron
[not found] ` <470d4a7fbbcbcaa35aa9dcbaab6a2b77f98dc528.camel@mediatek.com>
2021-08-17 15:54 ` Jonathan Cameron
[not found] ` <a6211ac1b3ab14931499744023ee60c1e82424a8.camel@mediatek.com>
[not found] ` <SI2PR03MB56901E5D00D47948BE0E9F989BC69@SI2PR03MB5690.apcprd03.prod.outlook.com>
[not found] ` <9fa19fb18910a593d25fb894237b3c59764db53e.camel@mediatek.com>
2021-08-29 14:15 ` Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210812190725.00007449@Huawei.com \
--to=jonathan.cameron@huawei$(echo .)com \
--cc=chun-hung.wu@mediatek$(echo .)com \
--cc=devicetree@vger$(echo .)kernel.org \
--cc=hui.liu@mediatek$(echo .)com \
--cc=jic23@kernel$(echo .)org \
--cc=lars@metafoo$(echo .)de \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-iio@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=pmeerw@pmeerw$(echo .)net \
--cc=robh+dt@kernel$(echo .)org \
--cc=s.hauer@pengutronix$(echo .)de \
--cc=seiya.wang@mediatek$(echo .)com \
--cc=srv_heupstream@mediatek$(echo .)com \
--cc=yingjoe.chen@mediatek$(echo .)com \
--cc=zhiyong.tao@mediatek$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox