Subject: Re: [v1 04/16] clk: mediatek: Add MT8186 topckgen clock support

From: kernel test robot <[email-masked]>
Date: Tue, 11 Jan 2022 05:13:59 +0800

Hi Chun-Jie,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on clk/clk-next]
[also build test ERROR on robh/for-next v5.16 next-20220110]
[cannot apply to mbgg-mediatek/for-next]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch]

url:    https://github.com/0day-ci/linux/commits/Chun-Jie-Chen/dt-bindings-ARM-Mediatek-Add-new-document-bindings-of-MT8186-clock/20220110-224451
base:   https://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git clk-next
config: nios2-allyesconfig (https://download.01.org/0day-ci/archive/20220111/[email-masked]/config)
compiler: nios2-linux-gcc (GCC) 11.2.0
reproduce (this is a W=1 build):
        wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
        chmod +x ~/bin/make.cross
        # https://github.com/0day-ci/linux/commit/265a72ef3e3b41a62f280049219cf4efe1d79171
        git remote add linux-review https://github.com/0day-ci/linux
        git fetch --no-tags linux-review Chun-Jie-Chen/dt-bindings-ARM-Mediatek-Add-new-document-bindings-of-MT8186-clock/20220110-224451
        git checkout 265a72ef3e3b41a62f280049219cf4efe1d79171
        # save the config file to linux build tree
        mkdir build_dir
        COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-11.2.0 make.cross O=build_dir ARCH=nios2 SHELL=/bin/bash

If you fix the issue, kindly add following tag as appropriate
Reported-by: kernel test robot <[email-masked]>

All errors (new ones prefixed by >>):

   drivers/clk/mediatek/clk-mt8186-topckgen.c: In function 'clk_mt8186_topck_probe':
>> drivers/clk/mediatek/clk-mt8186-topckgen.c:725:9: error: implicit declaration of function 'mtk_clk_unregister'; did you mean 'devm_clk_unregister'? [-Werror=implicit-function-declaration]
     725 |         mtk_clk_unregister(clk_data);
         |         ^~~~~~~~~~~~~~~~~~
         |         devm_clk_unregister
   cc1: some warnings being treated as errors

vim +725 drivers/clk/mediatek/clk-mt8186-topckgen.c

   691	
   692	static int clk_mt8186_topck_probe(struct platform_device *pdev)
   693	{
   694		struct clk_onecell_data *clk_data;
   695		struct device_node *node = pdev->dev.of_node;
   696		int r;
   697		void __iomem *base;
   698	
   699		base = devm_platform_ioremap_resource(pdev, 0);
   700		if (IS_ERR(base))
   701			return PTR_ERR(base);
   702	
   703		clk_data = mtk_alloc_clk_data(CLK_TOP_NR_CLK);
   704		if (!clk_data)
   705			return -ENOMEM;
   706	
   707		mtk_clk_register_fixed_clks(top_fixed_clks, ARRAY_SIZE(top_fixed_clks),
   708					    clk_data);
   709		mtk_clk_register_factors(top_divs, ARRAY_SIZE(top_divs), clk_data);
   710		mtk_clk_register_muxes(top_mtk_muxes, ARRAY_SIZE(top_mtk_muxes), node,
   711				       &mt8186_clk_lock, clk_data);
   712	
   713		mtk_clk_register_composites(top_muxes, ARRAY_SIZE(top_muxes), base,
   714					    &mt8186_clk_lock, clk_data);
   715		mtk_clk_register_composites(top_adj_divs, ARRAY_SIZE(top_adj_divs), base,
   716					    &mt8186_clk_lock, clk_data);
   717	
   718		r = of_clk_add_provider(node, of_clk_src_onecell_get, clk_data);
   719		if (r)
   720			goto unregister_clk;
   721	
   722		return r;
   723	
   724	unregister_clk:
 > 725		mtk_clk_unregister(clk_data);
   726		mtk_free_clk_data(clk_data);
   727		return r;
   728	}
   729	

---
0-DAY CI Kernel Test Service, Intel Corporation
https://lists.01.org/hyperkitty/list/[email-masked]

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel