From: Miles Chen <miles.chen@mediatek•com>
To: <sboyd@kernel•org>, Matthias Brugger <matthias.bgg@gmail•com>
Cc: <chun-jie.chen@mediatek•com>,
<linux-arm-kernel@lists•infradead.org>,
<linux-clk@vger•kernel.org>, <linux-kernel@vger•kernel.org>,
<linux-mediatek@lists•infradead.org>, <miles.chen@mediatek•com>,
<mturquette@baylibre•com>, <wenst@chromium•org>
Subject: Re: [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build
Date: Mon, 17 Jan 2022 17:18:04 +0800 [thread overview]
Message-ID: <20220117091807.13628-1-miles.chen@mediatek.com> (raw)
In-Reply-To: <20220114221930.660B5C36AE9@smtp.kernel.org>
>> I did not try it because we do not unload our clk modules.
>> After testing I understand that the clock driver does not unregister clks
>> we cannot remove then unload it.
>> I think I have to add some unregister logic to these drivers.
>
>Yes
I will do this later.
>
>> >that mtk_clk_simple_probe() doesn't actually unregister anything, it
>> >just frees some allocations. Please fix this before making these
>> >modules.
>> You meant that mtk_clk_simple_probe() has no unregister logic in error pa=
>
>Yes
I post a patch to fix this first:
https://lore.kernel.org/lkml/20220117090030.13064-1-miles.chen@mediatek.com/T/#u
After this, I think that I can use mtk_clk_simple_probe() in other mediatek clk
drivers by submitting some clean up patches.
Miles
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2022-01-17 9:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-10 17:09 clk: mediatek: support COMMON_CLK_MT8192 module build Miles Chen
2022-01-10 17:09 ` [PATCH 1/3] clk: mediatek: export mtk_clk_simple_probe Miles Chen
2022-01-14 2:12 ` Stephen Boyd
2022-01-14 8:36 ` Miles Chen
2022-01-10 17:09 ` [PATCH 2/3] clk: mediatek: clk-mt8192: drop CLK_OF_DECLARE_DRIVER Miles Chen
2022-01-10 17:09 ` [PATCH 3/3] clk: mediatek: support COMMON_CLK_MT8192 module build Miles Chen
2022-01-14 2:11 ` Stephen Boyd
2022-01-14 8:35 ` Miles Chen
2022-01-14 22:19 ` Stephen Boyd
2022-01-17 9:18 ` Miles Chen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220117091807.13628-1-miles.chen@mediatek.com \
--to=miles.chen@mediatek$(echo .)com \
--cc=chun-jie.chen@mediatek$(echo .)com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=mturquette@baylibre$(echo .)com \
--cc=sboyd@kernel$(echo .)org \
--cc=wenst@chromium$(echo .)org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox