From: Stephen Boyd <sboyd@kernel•org>
To: Jerome Brunet <jbrunet@baylibre•com>,
Kevin Hilman <khilman@baylibre•com>,
Liang Yang <liang.yang@amlogic•com>,
Michael Turquette <mturquette@baylibre•com>,
Neil Armstrong <narmstrong@baylibre•com>,
Rob Herring <robh+dt@kernel•org>,
linux-clk@vger•kernel.org
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail•com>,
Jianxin Pan <jianxin.pan@amlogic•com>,
Victor Wan <victor.wan@amlogic•com>,
XianWei Zhao <xianwei.zhao@amlogic•com>,
Kelvin Zhang <kelvin.zhang@amlogic•com>,
BiChao Zheng <bichao.zheng@amlogic•com>,
YongHui Yu <yonghui.yu@amlogic•com>,
linux-arm-kernel@lists•infradead.org,
linux-amlogic@lists•infradead.org, linux-kernel@vger•kernel.org
Subject: Re: [PATCH v9 4/4] clk: meson: add sub MMC clock controller driver
Date: Tue, 18 Jan 2022 18:22:19 -0800 [thread overview]
Message-ID: <20220119022221.3AF83C340E0@smtp.kernel.org> (raw)
In-Reply-To: <fe77fd6b-788f-1694-f260-f95e54cf4ef3@amlogic.com>
Quoting Liang Yang (2022-01-16 22:24:28)
>
>
> On 2022/1/15 7:01, Stephen Boyd wrote:
> > [ EXTERNAL EMAIL ]
> >
> > Quoting Liang Yang (2022-01-13 21:14:46)
> >> On 2022/1/14 5:35, Stephen Boyd wrote:
> >>> Quoting Liang Yang (2022-01-13 03:57:45)
> >>>> diff --git a/drivers/clk/meson/mmc-clkc.c b/drivers/clk/meson/mmc-clkc.c
> >>>> new file mode 100644
> >>>> index 000000000000..f53977f61390
> >>>> --- /dev/null
> >>>> +++ b/drivers/clk/meson/mmc-clkc.c
> >>>> @@ -0,0 +1,300 @@
> > [..]
> >>>> +
> >>>> +static int mmc_clkc_probe(struct platform_device *pdev)
> >>>> +{
> >>>> + struct clk_hw_onecell_data *onecell_data;
> >>>> + struct device *dev = &pdev->dev;
> >>>> + struct mmc_clkc_data *data;
> >>>> + struct regmap *map;
> >>>> + struct clk_regmap *clk, *core;
> >>>> + struct meson_sclk_div_data *div_data;
> >>>> +
> >>>> + /*cast to drop the const in match->data*/
> >>>
> >>> Space after *, also why do we need to cast away const? The user of this
> >>> pointer passes it all the way down to mmc_clkc_register_clk() which
> >>> could take the data as const void pointer and decide to cast away const
> >>> there.
> >>
> >> if use 'const' here, it will report a warning:
> >> drivers/clk/meson/mmc-clkc.c:224:7: error: assignment discards ‘const’
> >> qualifier from pointer targe
> >> t type [-Werror=discarded-qualifiers]
> >>
> >> data = (const struct mmc_clkc_data *)of_device_get_match_data(dev);
> >
> > Of course. The type declaration up above needs const added to it.The parm of mmc_clkc_register_clk_with_parent(...., void *data) does not
> have 'const', so make the type declaration cause a further 'const' cast
> warning. Could i copy these infos just like below:
Why can't you push const down to the function that really cares to
remove const?
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-19 2:23 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-13 11:57 [PATCH v9 0/4] clk: meson: add a sub EMMC clock controller support Liang Yang
2022-01-13 11:57 ` [PATCH v9 1/4] clk: meson: add one based divider support for sclk Liang Yang
2022-01-13 21:28 ` Stephen Boyd
2022-01-14 3:07 ` Liang Yang
2022-01-13 11:57 ` [PATCH v9 2/4] clk: meson: add emmc sub clock phase delay driver Liang Yang
2022-01-13 21:29 ` Stephen Boyd
2022-01-14 3:08 ` Liang Yang
2022-01-13 11:57 ` [PATCH v9 3/4] clk: meson: add DT documentation for emmc clock controller Liang Yang
2022-01-13 21:29 ` Stephen Boyd
2022-01-14 3:06 ` Liang Yang
2022-01-14 22:59 ` Stephen Boyd
2022-01-17 2:43 ` Liang Yang
2022-01-15 0:09 ` Martin Blumenstingl
2022-01-17 7:03 ` Liang Yang
2022-01-13 11:57 ` [PATCH v9 4/4] clk: meson: add sub MMC clock controller driver Liang Yang
2022-01-13 21:35 ` Stephen Boyd
2022-01-14 5:14 ` Liang Yang
2022-01-14 23:01 ` Stephen Boyd
2022-01-17 6:24 ` Liang Yang
2022-01-19 2:22 ` Stephen Boyd [this message]
2022-01-19 2:55 ` Liang Yang
-- strict thread matches above, loose matches on Subject: below --
2019-01-08 13:50 [PATCH RESEND v9 0/4] clk: meson: add a sub EMMC clock controller support Jianxin Pan
2019-01-08 13:50 ` [PATCH v9 4/4] clk: meson: add sub MMC clock controller driver Jianxin Pan
2019-01-22 9:25 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220119022221.3AF83C340E0@smtp.kernel.org \
--to=sboyd@kernel$(echo .)org \
--cc=bichao.zheng@amlogic$(echo .)com \
--cc=jbrunet@baylibre$(echo .)com \
--cc=jianxin.pan@amlogic$(echo .)com \
--cc=kelvin.zhang@amlogic$(echo .)com \
--cc=khilman@baylibre$(echo .)com \
--cc=liang.yang@amlogic$(echo .)com \
--cc=linux-amlogic@lists$(echo .)infradead.org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-clk@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=martin.blumenstingl@googlemail$(echo .)com \
--cc=mturquette@baylibre$(echo .)com \
--cc=narmstrong@baylibre$(echo .)com \
--cc=robh+dt@kernel$(echo .)org \
--cc=victor.wan@amlogic$(echo .)com \
--cc=xianwei.zhao@amlogic$(echo .)com \
--cc=yonghui.yu@amlogic$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox