Subject: RE: [PATCH v2 04/16] clk: samsung: fsd: Add initial clock support

From: Stephen Boyd <[email-masked]>
Date: Thu, 20 Jan 2022 09:46:57 -0800

Quoting Alim Akhtar (2022-01-20 05:53:31)
> Hi Stephen
> 
> >-----Original Message-----
> >From: Stephen Boyd [mailto:[email-masked]]
> >Sent: Thursday, January 20, 2022 1:45 AM
> >To: Alim Akhtar <[email-masked]>; linux-arm-
> >[email-masked]; [email-masked]
> >Cc: [email-masked]; [email-masked]; [email-masked];
> >[email-masked]; [email-masked]; [email-masked];
> >[email-masked]; [email-masked];
> >[email-masked]; [email-masked]; linux-
> >[email-masked]; [email-masked]; Alim Akhtar
> ><[email-masked]>; [email-masked]; Jayati Sahu
> ><[email-masked]>; Ajay Kumar <[email-masked]>
> >Subject: Re: [PATCH v2 04/16] clk: samsung: fsd: Add initial clock support
> >
> >Quoting Alim Akhtar (2022-01-18 06:48:39)
> >> diff --git a/drivers/clk/samsung/clk-fsd.c
> >> b/drivers/clk/samsung/clk-fsd.c new file mode 100644 index
> >> 000000000000..2669396d81b9
> >> --- /dev/null
> >> +++ b/drivers/clk/samsung/clk-fsd.c
> >> @@ -0,0 +1,308 @@
> >> +// SPDX-License-Identifier: GPL-2.0-only
> >> +/*
> >> + * Copyright (c) 2017-2022 Samsung Electronics Co., Ltd.
> >> + *             https://www.samsung.com
> >> + * Copyright (c) 2017-2022 Tesla, Inc.
> >> + *             https://www.tesla.com
> >> + *
> >> + * Common Clock Framework support for FSD SoC.
> >> + */
> >> +
> >> +#include <linux/clk-provider.h>
> >> +#include <linux/of.h>
> >
> >include init.h for __initconst and kernel.h for ARRAY_SIZE
> >
> I did not face any compilation error.
> Do I need to explicitly add these header files in driver? I see clk.h implicitly includes kernel.h
> Same is the case of other driver in this directory.

Yes they should be included. Depending on implicit includes leads to
pain later when that include is moved out of the header and compilation
breaks here. Include what you use, thanks!

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel