Subject: Re: [PATCH] ARM: dts: imx: Add missing LVDS decoder on M53Menlo

From: Shawn Guo <[email-masked]>
Date: Wed, 26 Jan 2022 20:19:01 +0800

On Sat, Dec 18, 2021 at 04:25:16PM +0100, Marek Vasut wrote:
> The M53Menlo display unit uses an LVDS-to-DPI bridge, TI DS90CF364A.
> Describe this bridge in DT, otherwise the DT incorrectly describes
> DPI panel attached directly to LVDS source.
> 
> Fixes: 716be61d1869 ("ARM: dts: imx53: Add Menlosystems M53 board")
> Signed-off-by: Marek Vasut <[email-masked]>
> Cc: Shawn Guo <[email-masked]>
> Cc: Fabio Estevam <[email-masked]>
> Cc: NXP Linux Team <[email-masked]>
> ---
>  arch/arm/boot/dts/imx53-m53menlo.dts | 27 +++++++++++++++++++++++++--
>  1 file changed, 25 insertions(+), 2 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx53-m53menlo.dts b/arch/arm/boot/dts/imx53-m53menlo.dts
> index 4f88e96d81dd..a1eb36229ef8 100644
> --- a/arch/arm/boot/dts/imx53-m53menlo.dts
> +++ b/arch/arm/boot/dts/imx53-m53menlo.dts
> @@ -53,6 +53,29 @@ eth {
>  		};
>  	};
>  
> +	lvds-decoder {
> +		compatible = "ti,ds90cf364a", "lvds-decoder";

Is this "ti,ds90cf364a" documented anywhere?

> +
> +		ports {
> +			#address-cells = <1>;
> +			#size-cells = <0>;
> +
> +			port@0 {
> +				reg = <0>;

Please have a newline between property and child node.

Shawn

> +				lvds_decoder_in: endpoint {
> +					remote-endpoint = <&lvds0_out>;
> +				};
> +			};
> +
> +			port@1 {
> +				reg = <1>;
> +				lvds_decoder_out: endpoint {
> +					remote-endpoint = <&panel_in>;
> +				};
> +			};
> +		};
> +	};
> +
>  	panel {
>  		compatible = "edt,etm0700g0dh6";
>  		pinctrl-0 = <&pinctrl_display_gpio>;
> @@ -61,7 +84,7 @@ panel {
>  
>  		port {
>  			panel_in: endpoint {
> -				remote-endpoint = <&lvds0_out>;
> +				remote-endpoint = <&lvds_decoder_out>;
>  			};
>  		};
>  	};
> @@ -450,7 +473,7 @@ port@2 {
>  			reg = <2>;
>  
>  			lvds0_out: endpoint {
> -				remote-endpoint = <&panel_in>;
> +				remote-endpoint = <&lvds_decoder_in>;
>  			};
>  		};
>  	};
> -- 
> 2.33.0
> 

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel