From: Oscar Salvador <osalvador@suse•de>
To: David Hildenbrand <david@redhat•com>
Cc: linux-kernel@vger•kernel.org, linux-mm@kvack•org,
Andrew Morton <akpm@linux-foundation•org>,
Greg Kroah-Hartman <gregkh@linuxfoundation•org>,
Michal Hocko <mhocko@suse•com>,
Catalin Marinas <catalin.marinas@arm•com>,
Will Deacon <will@kernel•org>,
Thomas Bogendoerfer <tsbogend@alpha•franken.de>,
Michael Ellerman <mpe@ellerman•id.au>,
Benjamin Herrenschmidt <benh@kernel•crashing.org>,
Paul Mackerras <paulus@samba•org>,
Paul Walmsley <paul.walmsley@sifive•com>,
Palmer Dabbelt <palmer@dabbelt•com>,
Albert Ou <aou@eecs•berkeley.edu>,
Heiko Carstens <hca@linux•ibm.com>,
Vasily Gorbik <gor@linux•ibm.com>,
Yoshinori Sato <ysato@users•sourceforge.jp>,
Rich Felker <dalias@libc•org>,
"David S. Miller" <davem@davemloft•net>,
Thomas Gleixner <tglx@linutronix•de>,
Ingo Molnar <mingo@redhat•com>, Borislav Petkov <bp@alien8•de>,
Dave Hansen <dave.hansen@linux•intel.com>,
"Rafael J. Wysocki" <rafael@kernel•org>,
x86@kernel•org, linux-arm-kernel@lists•infradead.org,
linux-ia64@vger•kernel.org, linux-mips@vger•kernel.org,
linuxppc-dev@lists•ozlabs.org, linux-riscv@lists•infradead.org,
linux-s390@vger•kernel.org, linux-sh@vger•kernel.org,
sparclinux@vger•kernel.org
Subject: Re: [PATCH RFC v1] drivers/base/node: consolidate node device subsystem initialization in node_dev_init()
Date: Mon, 31 Jan 2022 10:41:26 +0100 [thread overview]
Message-ID: <20220131094125.GB15392@linux> (raw)
In-Reply-To: <20220128151540.164759-1-david@redhat.com>
On Fri, Jan 28, 2022 at 04:15:40PM +0100, David Hildenbrand wrote:
> ... and call node_dev_init() after memory_dev_init() from driver_init(),
> so before any of the existing arch/subsys calls. All online nodes should
> be known at that point.
>
> This is in line with memory_dev_init(), which initializes the memory
> device subsystem and creates all memory block devices.
>
> Similar to memory_dev_init(), panic() if anything goes wrong, we don't
> want to continue with such basic initialization errors.
>
> The important part is that node_dev_init() gets called after
> memory_dev_init() and after cpu_dev_init(), but before any of the
> relevant archs call register_cpu() to register the new cpu device under
> the node device. The latter should be the case for the current users
> of topology_init().
>
> Cc: Andrew Morton <akpm@linux-foundation•org>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation•org>
> Cc: Michal Hocko <mhocko@suse•com>
> Cc: Oscar Salvador <osalvador@suse•de>
> Cc: Catalin Marinas <catalin.marinas@arm•com>
> Cc: Will Deacon <will@kernel•org>
> Cc: Thomas Bogendoerfer <tsbogend@alpha•franken.de>
> Cc: Michael Ellerman <mpe@ellerman•id.au>
> Cc: Benjamin Herrenschmidt <benh@kernel•crashing.org>
> Cc: Paul Mackerras <paulus@samba•org>
> Cc: Paul Walmsley <paul.walmsley@sifive•com>
> Cc: Palmer Dabbelt <palmer@dabbelt•com>
> Cc: Albert Ou <aou@eecs•berkeley.edu>
> Cc: Heiko Carstens <hca@linux•ibm.com>
> Cc: Vasily Gorbik <gor@linux•ibm.com>
> Cc: Yoshinori Sato <ysato@users•sourceforge.jp>
> Cc: Rich Felker <dalias@libc•org>
> Cc: "David S. Miller" <davem@davemloft•net>
> Cc: Thomas Gleixner <tglx@linutronix•de>
> Cc: Ingo Molnar <mingo@redhat•com>
> Cc: Borislav Petkov <bp@alien8•de>
> Cc: Dave Hansen <dave.hansen@linux•intel.com>
> Cc: "Rafael J. Wysocki" <rafael@kernel•org>
> Cc: x86@kernel•org
> Cc: linux-arm-kernel@lists•infradead.org
> Cc: linux-kernel@vger•kernel.org
> Cc: linux-ia64@vger•kernel.org
> Cc: linux-mips@vger•kernel.org
> Cc: linuxppc-dev@lists•ozlabs.org
> Cc: linux-riscv@lists•infradead.org
> Cc: linux-s390@vger•kernel.org
> Cc: linux-sh@vger•kernel.org
> Cc: sparclinux@vger•kernel.org
> Cc: linux-mm@kvack•org
> Signed-off-by: David Hildenbrand <david@redhat•com>
Reviewed-by: Oscar Salvador <osalvador@suse•de>
--
Oscar Salvador
SUSE Labs
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2022-01-31 9:42 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-28 15:15 [PATCH RFC v1] drivers/base/node: consolidate node device subsystem initialization in node_dev_init() David Hildenbrand
2022-01-31 6:23 ` Oscar Salvador
2022-01-31 7:48 ` David Hildenbrand
2022-01-31 9:40 ` Oscar Salvador
2022-02-01 10:17 ` David Hildenbrand
2022-01-31 9:41 ` Oscar Salvador [this message]
2022-02-01 10:02 ` Anatoly Pugachev
2022-02-02 13:45 ` David Hildenbrand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220131094125.GB15392@linux \
--to=osalvador@suse$(echo .)de \
--cc=akpm@linux-foundation$(echo .)org \
--cc=aou@eecs$(echo .)berkeley.edu \
--cc=benh@kernel$(echo .)crashing.org \
--cc=bp@alien8$(echo .)de \
--cc=catalin.marinas@arm$(echo .)com \
--cc=dalias@libc$(echo .)org \
--cc=dave.hansen@linux$(echo .)intel.com \
--cc=davem@davemloft$(echo .)net \
--cc=david@redhat$(echo .)com \
--cc=gor@linux$(echo .)ibm.com \
--cc=gregkh@linuxfoundation$(echo .)org \
--cc=hca@linux$(echo .)ibm.com \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-ia64@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-mips@vger$(echo .)kernel.org \
--cc=linux-mm@kvack$(echo .)org \
--cc=linux-riscv@lists$(echo .)infradead.org \
--cc=linux-s390@vger$(echo .)kernel.org \
--cc=linux-sh@vger$(echo .)kernel.org \
--cc=linuxppc-dev@lists$(echo .)ozlabs.org \
--cc=mhocko@suse$(echo .)com \
--cc=mingo@redhat$(echo .)com \
--cc=mpe@ellerman$(echo .)id.au \
--cc=palmer@dabbelt$(echo .)com \
--cc=paul.walmsley@sifive$(echo .)com \
--cc=paulus@samba$(echo .)org \
--cc=rafael@kernel$(echo .)org \
--cc=sparclinux@vger$(echo .)kernel.org \
--cc=tglx@linutronix$(echo .)de \
--cc=tsbogend@alpha$(echo .)franken.de \
--cc=will@kernel$(echo .)org \
--cc=x86@kernel$(echo .)org \
--cc=ysato@users$(echo .)sourceforge.jp \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox