Subject: Re: [PATCH] ARM: dts: add 533 MHz step to p4note GPU opp table

From: Martin Jücker <[email-masked]>
Date: Mon, 31 Jan 2022 13:15:59 +0100

On Mon, Jan 31, 2022 at 09:54:00AM +0100, Krzysztof Kozlowski wrote:
> On 29/01/2022 23:14, Martin Jücker wrote:
> > The p4note devices support 533 MHz GPU speed, so let's make use of it.
> > 
> 
> If there is going to be resend, please add prefix "exynos:" in subject.
> Just like other commits (git log --oneline arch/arm/boot/dts/exynos*).
> 
> > Signed-off-by: Martin Jücker <[email-masked]>
> > ---
> >  arch/arm/boot/dts/exynos4412-p4note.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/exynos4412-p4note.dtsi b/arch/arm/boot/dts/exynos4412-p4note.dtsi
> > index 4ae6eb3091c4..d277b2337ae0 100644
> > --- a/arch/arm/boot/dts/exynos4412-p4note.dtsi
> > +++ b/arch/arm/boot/dts/exynos4412-p4note.dtsi
> > @@ -355,6 +355,13 @@ &gpu {
> >  	status = "okay";
> >  };
> >  
> > +&gpu_opp_table {
> > +	opp-533000000 {
> > +		opp-hz = /bits/ 64 <533000000>;
> > +		opp-microvolt = <1075000>;
> > +	};
> > +};
> 
> This looks like Exynos4412 Prime. Please check also CPU frequencies and
> if they match, just include exynos4412-prime.dtsi (like Odroid U3).
> 
> > +
> >  &hsotg {
> >  	vusb_a-supply = <&ldo12_reg>;
> >  	dr_mode = "peripheral";
> 
> 
> Best regards,
> Krzysztof

I just noticed, that I overlooked a condition in the code which
decreases the step count by one which eliminates the 533 MHz step.
Please ignore this patch.

Kind Regards
Martin

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel