Re: [PATCH v1 6/7] dt-bindings: clock: imx6q: Allow single optional clock and add enet_ref_pad

From: Rob Herring <robh@kernel•org>
To: Oleksij Rempel <o.rempel@pengutronix•de>
Cc: Abel Vesa <abelvesa@kernel•org>,
	Michael Turquette <mturquette@baylibre•com>,
	 Stephen Boyd <sboyd@kernel•org>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro•org>,
	 Conor Dooley <conor+dt@kernel•org>,
	Shawn Guo <shawnguo@kernel•org>,
	 Sascha Hauer <s.hauer@pengutronix•de>,
	Herbert Xu <herbert@gondor•apana.org.au>,
	 "David S. Miller" <davem@davemloft•net>,
	Dmitry Torokhov <dmitry.torokhov@gmail•com>,
	 Ulf Hansson <ulf.hansson@linaro•org>,
	kernel@pengutronix•de, Peng Fan <peng.fan@nxp•com>,
	 Fabio Estevam <festevam@gmail•com>,
	NXP Linux Team <linux-imx@nxp•com>,
	 Daniel Lezcano <daniel.lezcano@linaro•org>,
	Thomas Gleixner <tglx@linutronix•de>,
	 Michael Trimarchi <michael@amarulasolutions•com>,
	Mark Brown <broonie@kernel•org>,
	 Dario Binacchi <dario.binacchi@amarulasolutions•com>,
	Anson Huang <Anson.Huang@nxp•com>,  Marek Vasut <marex@denx•de>,
	linux-clk@vger•kernel.org, devicetree@vger•kernel.org,
	 linux-arm-kernel@lists•infradead.org,
	linux-kernel@vger•kernel.org,  linux-crypto@vger•kernel.org,
	linux-input@vger•kernel.org,  linux-mmc@vger•kernel.org
Subject: Re: [PATCH v1 6/7] dt-bindings: clock: imx6q: Allow single optional clock and add enet_ref_pad
Date: Wed, 14 Jun 2023 13:18:08 -0600	[thread overview]
Message-ID: <20230614191808.GA2581397-robh@kernel.org> (raw)
In-Reply-To: <20230601101451.357662-7-o.rempel@pengutronix.de>

On Thu, Jun 01, 2023 at 12:14:50PM +0200, Oleksij Rempel wrote:
> All clocks for this driver are optional, so this change allows the

It's not about what the driver supports, but the h/w. You are saying 
this SoC can operate with only 1 of any of the clock inputs?

> 'clocks' and 'clock-names' properties to accept a single clock.
> Additionally, 'enet_ref_pad' clock is added. This resolves the following
> dtbs_check warning:
>   imx6dl-alti6p.dtb: clock-controller@20c4000: clocks: [[24]] is too short
>   From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> 
>   imx6dl-alti6p.dtb: clock-controller@20c4000: clock-names:0: 'osc' was
>     expected
>   From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> 
>   imx6dl-alti6p.dtb: clock-controller@20c4000: clock-names:
>     ['enet_ref_pad'] is too short
>   From schema: Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> 
> Signed-off-by: Oleksij Rempel <o.rempel@pengutronix•de>
> ---
>  .../devicetree/bindings/clock/imx6q-clock.yaml    | 15 +++++++++------
>  1 file changed, 9 insertions(+), 6 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> index bae4fcb3aacc..ed65d19c2e0e 100644
> --- a/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> +++ b/Documentation/devicetree/bindings/clock/imx6q-clock.yaml
> @@ -28,20 +28,23 @@ properties:
>      const: 1
>  
>    clocks:
> +    minItems: 1
>      items:
>        - description: 24m osc
>        - description: 32k osc
>        - description: ckih1 clock input
>        - description: anaclk1 clock input
>        - description: anaclk2 clock input
> +      - description: enet_ref_pad
>  
>    clock-names:
> -    items:
> -      - const: osc
> -      - const: ckil
> -      - const: ckih1
> -      - const: anaclk1
> -      - const: anaclk2
> +    enum:
> +      - osc
> +      - ckil
> +      - ckih1
> +      - anaclk1
> +      - anaclk2
> +      - enet_ref_pad
>  
>    fsl,pmic-stby-poweroff:
>      $ref: /schemas/types.yaml#/definitions/flag
> -- 
> 2.39.2
> 

_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel