Subject: Re: [PATCH v2 1/4] ARM: dts: am335x-pocketbeagle: update LED information

From: Trevor Woerner <[email-masked]>
Date: Tue, 22 Aug 2023 10:37:21 -0400

On Mon 2023-08-21 @ 10:36:34 AM, Robert Nelson wrote:
> On Sun, Aug 20, 2023 at 5:24 AM Trevor Woerner <[email-masked]> wrote:
> >
> > The "label" property is deprecated. Replace the "label" property with
> > "color" and "description" properties.
> >
> > Signed-off-by: Trevor Woerner <[email-masked]>
> > ---
> >  arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts | 13 +++++++++----
> >  1 file changed, 9 insertions(+), 4 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> > index 5dfe4d4bab93..1c11245f6864 100644
> > --- a/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> > +++ b/arch/arm/boot/dts/ti/omap/am335x-pocketbeagle.dts
> > @@ -8,6 +8,7 @@
> >
> >  #include "am33xx.dtsi"
> >  #include "am335x-osd335x-common.dtsi"
> > +#include <dt-bindings/leds/common.h>
> >
> >  / {
> >         model = "TI AM335x PocketBeagle";
> > @@ -24,28 +25,32 @@ leds {
> >                 compatible = "gpio-leds";
> >
> >                 led-usr0 {
> > -                       label = "beaglebone:green:usr0";
> > +                       color = <LED_COLOR_ID_BLUE>;
> > +                       function = LED_FUNCTION_HEARTBEAT;
> 
> So some background, while the LED are not Green, and this is not the BeagleBone.
> 
> We used these specific labels to keep all user documents going back to
> the original BeagleBone (white) (with 3.8.x kernel), the same so users
> could easily blink an led from user-space even on newer boards.
> 
> So it became our un-official abi for new users for the BeagleBoard
> family of devices..
> 
> It's even what we do on the BeaglePlay..
> 
> https://git.beagleboard.org/beagleboard/BeagleBoard-DeviceTrees/-/blob/v5.10.x-ti-unified/src/arm64/k3-am625-beagleplay.dts#L179-217

Thanks for the background. I've sent a v3 which simply adds the "color" and
"function" properties but leaves the "label" property intact.

_______________________________________________
linux-arm-kernel mailing list
[email-masked]
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel