From: Kees Cook <keescook@chromium•org>
To: Pavel Machek <pavel@ucw•cz>
Cc: Kees Cook <keescook@chromium•org>, Lee Jones <lee@kernel•org>,
Matthias Brugger <matthias.bgg@gmail•com>,
AngeloGioacchino Del Regno
<angelogioacchino.delregno@collabora•com>,
Gene Chen <gene_chen@richtek•com>,
Jacek Anaszewski <jacek.anaszewski@gmail•com>,
Andy Shevchenko <andriy.shevchenko@linux•intel.com>,
linux-leds@vger•kernel.org, linux-arm-kernel@lists•infradead.org,
linux-mediatek@lists•infradead.org,
Nathan Chancellor <nathan@kernel•org>,
Nick Desaulniers <ndesaulniers@google•com>,
Tom Rix <trix@redhat•com>,
linux-kernel@vger•kernel.org, llvm@lists•linux.dev,
linux-hardening@vger•kernel.org
Subject: [PATCH] leds: mt6360: Annotate struct mt6360_priv with __counted_by
Date: Fri, 15 Sep 2023 13:10:20 -0700 [thread overview]
Message-ID: <20230915201020.never.433-kees@kernel.org> (raw)
Prepare for the coming implementation by GCC and Clang of the __counted_by
attribute. Flexible array members annotated with __counted_by can have
their accesses bounds-checked at run-time checking via CONFIG_UBSAN_BOUNDS
(for array indexing) and CONFIG_FORTIFY_SOURCE (for strcpy/memcpy-family
functions).
As found with Coccinelle[1], add __counted_by for struct mt6360_priv.
[1] https://github.com/kees/kernel-tools/blob/trunk/coccinelle/examples/counted_by.cocci
Cc: Pavel Machek <pavel@ucw•cz>
Cc: Lee Jones <lee@kernel•org>
Cc: Matthias Brugger <matthias.bgg@gmail•com>
Cc: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora•com>
Cc: Gene Chen <gene_chen@richtek•com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail•com>
Cc: Andy Shevchenko <andriy.shevchenko@linux•intel.com>
Cc: linux-leds@vger•kernel.org
Cc: linux-arm-kernel@lists•infradead.org
Cc: linux-mediatek@lists•infradead.org
Signed-off-by: Kees Cook <keescook@chromium•org>
---
drivers/leds/flash/leds-mt6360.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/leds/flash/leds-mt6360.c b/drivers/leds/flash/leds-mt6360.c
index 1af6c5898343..b70dc689b33f 100644
--- a/drivers/leds/flash/leds-mt6360.c
+++ b/drivers/leds/flash/leds-mt6360.c
@@ -91,7 +91,7 @@ struct mt6360_priv {
unsigned int fled_torch_used;
unsigned int leds_active;
unsigned int leds_count;
- struct mt6360_led leds[];
+ struct mt6360_led leds[] __counted_by(leds_count);
};
static int mt6360_mc_brightness_set(struct led_classdev *lcdev,
--
2.34.1
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists•infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next reply other threads:[~2023-09-15 20:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-15 20:10 Kees Cook [this message]
2023-09-15 20:47 ` [PATCH] leds: mt6360: Annotate struct mt6360_priv with __counted_by Gustavo A. R. Silva
2023-09-18 8:27 ` AngeloGioacchino Del Regno
2023-09-20 13:50 ` (subset) " Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230915201020.never.433-kees@kernel.org \
--to=keescook@chromium$(echo .)org \
--cc=andriy.shevchenko@linux$(echo .)intel.com \
--cc=angelogioacchino.delregno@collabora$(echo .)com \
--cc=gene_chen@richtek$(echo .)com \
--cc=jacek.anaszewski@gmail$(echo .)com \
--cc=lee@kernel$(echo .)org \
--cc=linux-arm-kernel@lists$(echo .)infradead.org \
--cc=linux-hardening@vger$(echo .)kernel.org \
--cc=linux-kernel@vger$(echo .)kernel.org \
--cc=linux-leds@vger$(echo .)kernel.org \
--cc=linux-mediatek@lists$(echo .)infradead.org \
--cc=llvm@lists$(echo .)linux.dev \
--cc=matthias.bgg@gmail$(echo .)com \
--cc=nathan@kernel$(echo .)org \
--cc=ndesaulniers@google$(echo .)com \
--cc=pavel@ucw$(echo .)cz \
--cc=trix@redhat$(echo .)com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox